Re: Wget 1.21 and OS X 10.9

2021-01-01 Thread Jeffrey Walton
On Fri, Jan 1, 2021 at 5:08 PM Jeffrey Walton  wrote:
>
> On Fri, Jan 1, 2021 at 5:04 PM Darshit Shah  wrote:
> >
> > The Python tests look like they fail because the system does not have a
> > Python3 binary.
> >
> > From past experience, it is possible that you have python3 installed,
> > but the system does not have a python3 binary. Just Python. I don't have
> > a clean way to work around this problem.
>
> Ack, thanks.
>
> Yeah, this is an older MacBook circa 2010. It has had a few OS X
> upgrades but it is now frozen for performance reasons. It is basically
> unusable because of OS X bloat.
>
> It does have Python2, but I don't believe it has Python3.
>
>   $ python --version
>   Python 2.7.5

Yeah, it looks like Python2 only.

$ find /usr/bin -name '*python*'
/usr/bin/python
/usr/bin/python-config
/usr/bin/python2.5
/usr/bin/python2.5-config
/usr/bin/python2.6
/usr/bin/python2.6-config
/usr/bin/python2.7
/usr/bin/python2.7-config
/usr/bin/pythonw
/usr/bin/pythonw2.5
/usr/bin/pythonw2.6
/usr/bin/pythonw2.7

Jeff



Re: Wget 1.21 and OS X 10.9

2021-01-01 Thread Jeffrey Walton
On Fri, Jan 1, 2021 at 5:04 PM Darshit Shah  wrote:
>
> The Python tests look like they fail because the system does not have a
> Python3 binary.
>
> From past experience, it is possible that you have python3 installed,
> but the system does not have a python3 binary. Just Python. I don't have
> a clean way to work around this problem.

Ack, thanks.

Yeah, this is an older MacBook circa 2010. It has had a few OS X
upgrades but it is now frozen for performance reasons. It is basically
unusable because of OS X bloat.

It does have Python2, but I don't believe it has Python3.

  $ python --version
  Python 2.7.5

Jeff



Re: Wget 1.21 and OS X 10.9

2021-01-01 Thread Darshit Shah
Hi,

The Python tests look like they fail because the system does not have a
Python3 binary.

>From past experience, it is possible that you have python3 installed,
but the system does not have a python3 binary. Just Python. I don't have
a clean way to work around this problem.

On 01.01.21 21:59, Jeffrey Walton wrote:
> Hi Everyone,
> 
> It looks like things went sideways on OS X 10.9. OS X 10.9 has a Perl
> new enough so that I execute self tests.
> 
> $ perl -V
> Summary of my perl5 (revision 5 version 16 subversion 2)
> 
> Here's a sample:
> 
> gmake[4]: Entering directory '/Users/jwalton/Build-Scripts/wget-1.21/testenv'
> FAIL: Test-504.py
> FAIL: Test-416.py
> FAIL: Test-auth-basic-fail.py
> FAIL: Test-auth-basic.py
> FAIL: Test-auth-basic-netrc.py
> FAIL: Test-auth-basic-netrc-user-given.py
> FAIL: Test-auth-basic-netrc-pass-given.py
> FAIL: Test-auth-basic-no-netrc-fail.py
> FAIL: Test-auth-both.py
> FAIL: Test-auth-digest.py
> FAIL: Test-auth-no-challenge.py
> FAIL: Test-auth-no-challenge-url.py
> FAIL: Test-auth-retcode.py
> FAIL: Test-auth-with-content-disposition.py
> FAIL: Test-c-full.py
> FAIL: Test-condget.py
> FAIL: Test-Content-disposition-2.py
> FAIL: Test-Content-disposition.py
> FAIL: Test--convert-links--content-on-error.py
> FAIL: Test-cookie-401.py
> FAIL: Test-cookie-domain-mismatch.py
> FAIL: Test-cookie-expires.py
> FAIL: Test-cookie.py
> FAIL: Test-Head.py
> FAIL: Test-hsts.py
> FAIL: Test--https.py
> FAIL: Test--https-crl.py
> FAIL: Test-missing-scheme-retval.py
> FAIL: Test-O.py
> FAIL: Test-pinnedpubkey-der-https.py
> FAIL: Test-pinnedpubkey-der-no-check-https.py
> FAIL: Test-pinnedpubkey-hash-https.py
> FAIL: Test-pinnedpubkey-hash-no-check-fail-https.py
> FAIL: Test-pinnedpubkey-pem-fail-https.py
> FAIL: Test-pinnedpubkey-pem-https.py
> FAIL: Test-Post.py
> FAIL: Test-recursive-basic.py
> FAIL: Test-recursive-include.py
> FAIL: Test-recursive-redirect.py
> FAIL: Test-redirect.py
> FAIL: Test-redirect-crash.py
> FAIL: Test--rejected-log.py
> FAIL: Test-reserved-chars.py
> FAIL: Test--spider-r.py
> FAIL: Test-no_proxy-env.py
> 
> Testsuite summary for wget 1.21
> 
> # TOTAL: 45
> # PASS:  0
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  45
> # XPASS: 0
> # ERROR: 0
> 
> Jeff
> 



Re: Wget 1.21 and OS X 10.9

2021-01-01 Thread Jeffrey Walton
On Fri, Jan 1, 2021 at 4:32 PM Tim Rühsen  wrote:
>
> The failure is the same for all perl tests:
>
> Can't locate HTTP/Daemon.pm in @INC (you may need to install the
> HTTP::Daemon module) (@INC contains: .
> /opt/local/lib/perl5/site_perl/5.26/darwin-thread-multi-2level
> /opt/local/lib/perl5/site_perl/5.26
> /opt/local/lib/perl5/vendor_perl/5.26/darwin-thread-multi-2level
> /opt/local/lib/perl5/vendor_perl/5.26
> /opt/local/lib/perl5/5.26/darwin-thread-multi-2level
> /opt/local/lib/perl5/5.26 .) at HTTPServer.pm line 6.
>
> Looks like perl can't find HTTP/Daemon.pm.

Oh, that's interesting. I specifically test for HTTP::Daemon at
https://github.com/noloader/Build-Scripts/blob/master/build-wget.sh#L141
. Otherwise I disable self tests.

if ! perl -MHTTP::Daemon -e1 2>/dev/null
then
echo "Wget requires Perl's HTTP::Daemon. Skipping Wget self tests."
echo "To fix this issue, please install HTTP-Daemon."
SKIP_WGET_TESTS=1
fi

Jeff



Re: Wget 1.21 and OS X 10.9

2021-01-01 Thread Tim Rühsen

The failure is the same for all perl tests:

Can't locate HTTP/Daemon.pm in @INC (you may need to install the 
HTTP::Daemon module) (@INC contains: . 
/opt/local/lib/perl5/site_perl/5.26/darwin-thread-multi-2level 
/opt/local/lib/perl5/site_perl/5.26 
/opt/local/lib/perl5/vendor_perl/5.26/darwin-thread-multi-2level 
/opt/local/lib/perl5/vendor_perl/5.26 
/opt/local/lib/perl5/5.26/darwin-thread-multi-2level 
/opt/local/lib/perl5/5.26 .) at HTTPServer.pm line 6.


Looks like perl can't find HTTP/Daemon.pm.

Regards, Tim

On 01.01.21 21:59, Jeffrey Walton wrote:

Hi Everyone,

It looks like things went sideways on OS X 10.9. OS X 10.9 has a Perl
new enough so that I execute self tests.

 $ perl -V
 Summary of my perl5 (revision 5 version 16 subversion 2)

Here's a sample:

gmake[4]: Entering directory '/Users/jwalton/Build-Scripts/wget-1.21/testenv'
FAIL: Test-504.py
FAIL: Test-416.py
FAIL: Test-auth-basic-fail.py
FAIL: Test-auth-basic.py
FAIL: Test-auth-basic-netrc.py
FAIL: Test-auth-basic-netrc-user-given.py
FAIL: Test-auth-basic-netrc-pass-given.py
FAIL: Test-auth-basic-no-netrc-fail.py
FAIL: Test-auth-both.py
FAIL: Test-auth-digest.py
FAIL: Test-auth-no-challenge.py
FAIL: Test-auth-no-challenge-url.py
FAIL: Test-auth-retcode.py
FAIL: Test-auth-with-content-disposition.py
FAIL: Test-c-full.py
FAIL: Test-condget.py
FAIL: Test-Content-disposition-2.py
FAIL: Test-Content-disposition.py
FAIL: Test--convert-links--content-on-error.py
FAIL: Test-cookie-401.py
FAIL: Test-cookie-domain-mismatch.py
FAIL: Test-cookie-expires.py
FAIL: Test-cookie.py
FAIL: Test-Head.py
FAIL: Test-hsts.py
FAIL: Test--https.py
FAIL: Test--https-crl.py
FAIL: Test-missing-scheme-retval.py
FAIL: Test-O.py
FAIL: Test-pinnedpubkey-der-https.py
FAIL: Test-pinnedpubkey-der-no-check-https.py
FAIL: Test-pinnedpubkey-hash-https.py
FAIL: Test-pinnedpubkey-hash-no-check-fail-https.py
FAIL: Test-pinnedpubkey-pem-fail-https.py
FAIL: Test-pinnedpubkey-pem-https.py
FAIL: Test-Post.py
FAIL: Test-recursive-basic.py
FAIL: Test-recursive-include.py
FAIL: Test-recursive-redirect.py
FAIL: Test-redirect.py
FAIL: Test-redirect-crash.py
FAIL: Test--rejected-log.py
FAIL: Test-reserved-chars.py
FAIL: Test--spider-r.py
FAIL: Test-no_proxy-env.py

Testsuite summary for wget 1.21

# TOTAL: 45
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  45
# XPASS: 0
# ERROR: 0

Jeff





OpenPGP_signature
Description: OpenPGP digital signature


Wget 1.21 and OS X 10.9

2021-01-01 Thread Jeffrey Walton
Hi Everyone,

It looks like things went sideways on OS X 10.9. OS X 10.9 has a Perl
new enough so that I execute self tests.

$ perl -V
Summary of my perl5 (revision 5 version 16 subversion 2)

Here's a sample:

gmake[4]: Entering directory '/Users/jwalton/Build-Scripts/wget-1.21/testenv'
FAIL: Test-504.py
FAIL: Test-416.py
FAIL: Test-auth-basic-fail.py
FAIL: Test-auth-basic.py
FAIL: Test-auth-basic-netrc.py
FAIL: Test-auth-basic-netrc-user-given.py
FAIL: Test-auth-basic-netrc-pass-given.py
FAIL: Test-auth-basic-no-netrc-fail.py
FAIL: Test-auth-both.py
FAIL: Test-auth-digest.py
FAIL: Test-auth-no-challenge.py
FAIL: Test-auth-no-challenge-url.py
FAIL: Test-auth-retcode.py
FAIL: Test-auth-with-content-disposition.py
FAIL: Test-c-full.py
FAIL: Test-condget.py
FAIL: Test-Content-disposition-2.py
FAIL: Test-Content-disposition.py
FAIL: Test--convert-links--content-on-error.py
FAIL: Test-cookie-401.py
FAIL: Test-cookie-domain-mismatch.py
FAIL: Test-cookie-expires.py
FAIL: Test-cookie.py
FAIL: Test-Head.py
FAIL: Test-hsts.py
FAIL: Test--https.py
FAIL: Test--https-crl.py
FAIL: Test-missing-scheme-retval.py
FAIL: Test-O.py
FAIL: Test-pinnedpubkey-der-https.py
FAIL: Test-pinnedpubkey-der-no-check-https.py
FAIL: Test-pinnedpubkey-hash-https.py
FAIL: Test-pinnedpubkey-hash-no-check-fail-https.py
FAIL: Test-pinnedpubkey-pem-fail-https.py
FAIL: Test-pinnedpubkey-pem-https.py
FAIL: Test-Post.py
FAIL: Test-recursive-basic.py
FAIL: Test-recursive-include.py
FAIL: Test-recursive-redirect.py
FAIL: Test-redirect.py
FAIL: Test-redirect-crash.py
FAIL: Test--rejected-log.py
FAIL: Test-reserved-chars.py
FAIL: Test--spider-r.py
FAIL: Test-no_proxy-env.py

Testsuite summary for wget 1.21

# TOTAL: 45
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  45
# XPASS: 0
# ERROR: 0

Jeff
<>
<>


Re: Wget 1.21 and PowerMac results

2021-01-01 Thread Jeffrey Walton
On Fri, Jan 1, 2021 at 1:53 PM Tim Rühsen  wrote:
>
> On 01.01.21 19:50, Jeffrey Walton wrote:
> > On Fri, Jan 1, 2021 at 1:42 PM Tim Rühsen  wrote:
> >>
> >> Hi Jeff,
> >>
> >> we recently updated gnulib for wget 1.21.
> >>
> >> Gnulib is C99 and at least in L288 it looks like your compiler doesn't
> >> like a C99 construct. Possibly you need to explicitly switch on C99 mode !?
> >
> > I _think_ the only thing available nowadays on the PowerMacs is GCC 4.2.1.
> >
> > In the old days we could use a modern GCC or Clang from MacPorts. But
> > the standard c++ library no longer builds on the PowerMac, so the
> > compilers don't build.
>
> gcc 4.2.1 should be ok [1]. Try using
>
> CFLAGS=-std=gnu99 ./configure
> ...

Here's the patch that sidesteps the issues using GCC 4.2.1 on the
PowerMac, if interested:
https://github.com/noloader/Build-Scripts/blob/master/patch/wget.patch

Jeff



Re: Wget 1.21 and PowerMac results

2021-01-01 Thread Paul Eggert

On 1/1/21 10:40 AM, Jeffrey Walton wrote:

tempname.c: In function 'random_bits':
tempname.c:90: warning: integer constant is too large for 'long' type
tempname.c:90: warning: this decimal constant is unsigned only in ISO C90
tempname.c: In function 'try_tempname_len':
tempname.c:288: error: 'for' loop initial declaration used outside C99 mode


Presumably your compiler has a flag to enable C99-or-better mode. If 
not, you're out of luck: Gnulib assumes C99 nowadays. If so, please 
investigate why 'configure' did not set that flag.


With ancient GCC, 'configure' should try the -std=gnu99 option; why 
didn't that work for you? Please check your config.log to find out.




Re: Wget 1.21 and PowerMac results

2021-01-01 Thread Tim Rühsen

On 01.01.21 19:50, Jeffrey Walton wrote:

On Fri, Jan 1, 2021 at 1:42 PM Tim Rühsen  wrote:


Hi Jeff,

we recently updated gnulib for wget 1.21.

Gnulib is C99 and at least in L288 it looks like your compiler doesn't
like a C99 construct. Possibly you need to explicitly switch on C99 mode !?


I _think_ the only thing available nowadays on the PowerMacs is GCC 4.2.1.

In the old days we could use a modern GCC or Clang from MacPorts. But
the standard c++ library no longer builds on the PowerMac, so the
compilers don't build.


gcc 4.2.1 should be ok [1]. Try using

CFLAGS=-std=gnu99 ./configure
...

Regards, Tim

[1] https://gcc.gnu.org/gcc-4.2/changes.html



OpenPGP_signature
Description: OpenPGP digital signature


Re: Wget 1.21 and PowerMac results

2021-01-01 Thread Jeffrey Walton
On Fri, Jan 1, 2021 at 1:42 PM Tim Rühsen  wrote:
>
> Hi Jeff,
>
> we recently updated gnulib for wget 1.21.
>
> Gnulib is C99 and at least in L288 it looks like your compiler doesn't
> like a C99 construct. Possibly you need to explicitly switch on C99 mode !?

I _think_ the only thing available nowadays on the PowerMacs is GCC 4.2.1.

In the old days we could use a modern GCC or Clang from MacPorts. But
the standard c++ library no longer builds on the PowerMac, so the
compilers don't build.

Jeff



Re: Wget 1.21 and PowerMac results

2021-01-01 Thread Tim Rühsen

FYI, with CFLAGS="-std=c89" I run into this:

tempname.c: In function 'try_tempname_len':
tempname.c:288:7: error: 'for' loop initial declarations are only 
allowed in C99 or C11 mode

  288 |   for (size_t i = 0; i < x_suffix_len; i++)
  |   ^~~

Regards, Tim

On 01.01.21 19:42, Tim Rühsen wrote:

Hi Jeff,

we recently updated gnulib for wget 1.21.

Gnulib is C99 and at least in L288 it looks like your compiler doesn't 
like a C99 construct. Possibly you need to explicitly switch on C99 mode !?


Regards, Tim

On 01.01.21 19:38, Jeffrey Walton wrote:

Hi Everyone,

Here are the results of building Wget 1.21 on an old PowerMac G5.

 gcc -DHAVE_CONFIG_H -I. -I../src
-DDEFAULT_TEXT_DOMAIN=\"wget-gnulib\" -I/usr/local/include -DNDEBUG
-I/usr/local/include -I/usr/local/include -I/opt/local/include
-DNDEBUG -g2 -O2 -mlong-double-64 -fPIC -pthread -MT tempname.o -MD
-MP -MF $depbase.Tpo -c -o tempname.o tempname.c &&\
 mv -f $depbase.Tpo $depbase.Po
tempname.c: In function 'random_bits':
tempname.c:90: warning: integer constant is too large for 'long' type
tempname.c:90: warning: this decimal constant is unsigned only in ISO C90
tempname.c: In function 'try_tempname_len':
tempname.c:288: error: 'for' loop initial declaration used outside C99 
mode

make[3]: *** [tempname.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Gnulib had a couple of commits related to tempname. Also see
https://www.mail-archive.com/bug-gnulib@gnu.org/msg39151.html and
https://www.mail-archive.com/bug-gnulib@gnu.org/msg38659.html.

Wget 1.20.3 is OK.

Jeff







OpenPGP_signature
Description: OpenPGP digital signature


Re: Wget 1.21 and PowerMac results

2021-01-01 Thread Tim Rühsen

Hi Jeff,

we recently updated gnulib for wget 1.21.

Gnulib is C99 and at least in L288 it looks like your compiler doesn't 
like a C99 construct. Possibly you need to explicitly switch on C99 mode !?


Regards, Tim

On 01.01.21 19:38, Jeffrey Walton wrote:

Hi Everyone,

Here are the results of building Wget 1.21 on an old PowerMac G5.

 gcc -DHAVE_CONFIG_H -I. -I../src
-DDEFAULT_TEXT_DOMAIN=\"wget-gnulib\" -I/usr/local/include -DNDEBUG
-I/usr/local/include -I/usr/local/include -I/opt/local/include
-DNDEBUG -g2 -O2 -mlong-double-64 -fPIC -pthread -MT tempname.o -MD
-MP -MF $depbase.Tpo -c -o tempname.o tempname.c &&\
 mv -f $depbase.Tpo $depbase.Po
tempname.c: In function 'random_bits':
tempname.c:90: warning: integer constant is too large for 'long' type
tempname.c:90: warning: this decimal constant is unsigned only in ISO C90
tempname.c: In function 'try_tempname_len':
tempname.c:288: error: 'for' loop initial declaration used outside C99 mode
make[3]: *** [tempname.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Gnulib had a couple of commits related to tempname. Also see
https://www.mail-archive.com/bug-gnulib@gnu.org/msg39151.html and
https://www.mail-archive.com/bug-gnulib@gnu.org/msg38659.html.

Wget 1.20.3 is OK.

Jeff





OpenPGP_signature
Description: OpenPGP digital signature


Wget 1.21 and PowerMac results

2021-01-01 Thread Jeffrey Walton
Hi Everyone,

Here are the results of building Wget 1.21 on an old PowerMac G5.

gcc -DHAVE_CONFIG_H -I. -I../src
-DDEFAULT_TEXT_DOMAIN=\"wget-gnulib\" -I/usr/local/include -DNDEBUG
-I/usr/local/include -I/usr/local/include -I/opt/local/include
-DNDEBUG -g2 -O2 -mlong-double-64 -fPIC -pthread -MT tempname.o -MD
-MP -MF $depbase.Tpo -c -o tempname.o tempname.c &&\
mv -f $depbase.Tpo $depbase.Po
tempname.c: In function 'random_bits':
tempname.c:90: warning: integer constant is too large for 'long' type
tempname.c:90: warning: this decimal constant is unsigned only in ISO C90
tempname.c: In function 'try_tempname_len':
tempname.c:288: error: 'for' loop initial declaration used outside C99 mode
make[3]: *** [tempname.o] Error 1
make[3]: *** Waiting for unfinished jobs
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Gnulib had a couple of commits related to tempname. Also see
https://www.mail-archive.com/bug-gnulib@gnu.org/msg39151.html and
https://www.mail-archive.com/bug-gnulib@gnu.org/msg38659.html.

Wget 1.20.3 is OK.

Jeff



Re: Wget 1.21 is OK on Ubuntu 18 sans the Perl problems

2021-01-01 Thread Tim Rühsen

Hi Jeff,

thank you for the feedback !

Regards, Tim

On 01.01.21 19:30, Jeffrey Walton wrote:

Hi Everyone,

Wget 1.21 is OK on Ubuntu 18.05 LTS, x86_64 sans the Perl problems.

Jeff





OpenPGP_signature
Description: OpenPGP digital signature


Wget 1.21 is OK on Ubuntu 18 sans the Perl problems

2021-01-01 Thread Jeffrey Walton
Hi Everyone,

Wget 1.21 is OK on Ubuntu 18.05 LTS, x86_64 sans the Perl problems.

Jeff



Re: wget 1.21 fails to build on macOS

2021-01-01 Thread Darshit Shah
Hi,

Thanks for the heads up. Luckily it has already been fixed in Gnulib
(just one hour after I updated gnulib to make the release).

I'll update our submodule right away and make a new point release in the
next week after accumulating any other complaints that might arise.


On 01.01.21 11:32, FX wrote:
> Hello all,
> 
> wget 1.21 fails to build from source on all macOS version (10.14, 10.15, and 
> 11). This comes from a bug in gnulib, as I understand it:
> In lib/utime.c, in the code block for REPLACE_FUNC_UTIME_FILE, errno and 
> EOVERFLOW are both used without  being included, leading to:
> 
> utime.c:279:38: error: use of undeclared identifier 'errno'
>   if (stat (name, ) == -1 && errno != EOVERFLOW)
>  ^
> utime.c:279:47: error: use of undeclared identifier 'EOVERFLOW'
>   if (stat (name, ) == -1 && errno != EOVERFLOW)
>   ^
> 2 errors generated.
> make[3]: *** [utime.o] Error 1
> 
> See https://github.com/Homebrew/homebrew-core/pull/68095 for full build log
> 
> 
> This was already reported to gnulib at 
> https://lists.gnu.org/archive/html/bug-gnulib/2020-12/msg00295.html
> and fix in 
> https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=6a76832db224ac5671599ce332717f985a2addc7
> 
> Could the fix please be applied to wget as well?
> 
> Thanks,
> FX Coudert
> 



wget 1.21 fails to build on macOS

2021-01-01 Thread FX
Hello all,

wget 1.21 fails to build from source on all macOS version (10.14, 10.15, and 
11). This comes from a bug in gnulib, as I understand it:
In lib/utime.c, in the code block for REPLACE_FUNC_UTIME_FILE, errno and 
EOVERFLOW are both used without  being included, leading to:

utime.c:279:38: error: use of undeclared identifier 'errno'
  if (stat (name, ) == -1 && errno != EOVERFLOW)
 ^
utime.c:279:47: error: use of undeclared identifier 'EOVERFLOW'
  if (stat (name, ) == -1 && errno != EOVERFLOW)
  ^
2 errors generated.
make[3]: *** [utime.o] Error 1

See https://github.com/Homebrew/homebrew-core/pull/68095 for full build log


This was already reported to gnulib at 
https://lists.gnu.org/archive/html/bug-gnulib/2020-12/msg00295.html
and fix in 
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=6a76832db224ac5671599ce332717f985a2addc7

Could the fix please be applied to wget as well?

Thanks,
FX Coudert