Re: [Bug-wget] [PATCH] Respect -o parameter

2016-11-09 Thread Dale R. Worley
Tim Rühsen  writes:
> Thanks, Piotr ! Commit has been pushed.

Great, thanks!

Dale



Re: [Bug-wget] [PATCH] Respect -o parameter

2016-11-09 Thread Tim Rühsen
On Mittwoch, 9. November 2016 10:57:01 CET Piotr Wajda wrote:
>  * log.c: don't choose log output dynamically when opt.lfilename is set
> ---
>  src/log.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/log.c b/src/log.c
> index e068acf..51f30c4 100644
> --- a/src/log.c
> +++ b/src/log.c
> @@ -956,11 +956,11 @@ static void
>  check_redirect_output (void)
>  {
>  #ifndef WINDOWS
> -  /* If it was redirected already to log file by SIGHUP or SIGUSR1,
> -   * it was permanent and since that redirect_request_signal_name is set.
> +  /* If it was redirected already to log file by SIGHUP, SIGUSR1 or -o
> parameter, +   * it was permanent.
> * If there was no SIGHUP or SIGUSR1 and shell is interactive
> * we check if process is fg or bg before every line is printed.*/
> -  if (!redirect_request_signal_name && shell_is_interactive)
> +  if (!redirect_request_signal_name && shell_is_interactive &&
> !opt.lfilename) {
>if (tcgetpgrp (STDIN_FILENO) != getpgrp ())
>  {

Thanks, Piotr ! Commit has been pushed.

Tim


signature.asc
Description: This is a digitally signed message part.


[Bug-wget] [PATCH] Respect -o parameter

2016-11-09 Thread Piotr Wajda
 * log.c: don't choose log output dynamically when opt.lfilename is set
---
 src/log.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/log.c b/src/log.c
index e068acf..51f30c4 100644
--- a/src/log.c
+++ b/src/log.c
@@ -956,11 +956,11 @@ static void
 check_redirect_output (void)
 {
 #ifndef WINDOWS
-  /* If it was redirected already to log file by SIGHUP or SIGUSR1,
-   * it was permanent and since that redirect_request_signal_name is set.
+  /* If it was redirected already to log file by SIGHUP, SIGUSR1 or -o 
parameter,
+   * it was permanent.
* If there was no SIGHUP or SIGUSR1 and shell is interactive
* we check if process is fg or bg before every line is printed.*/
-  if (!redirect_request_signal_name && shell_is_interactive)
+  if (!redirect_request_signal_name && shell_is_interactive && !opt.lfilename)
 {
   if (tcgetpgrp (STDIN_FILENO) != getpgrp ())
 {
-- 
1.9.1