Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-16 Thread Tim Rühsen 

On 05/16/2017 01:42 PM, Giuseppe Scrivano wrote:
> Tomas Hozza  writes:
> 
>> The option to turn off reading .netrc by configuration in .wgetrc is
>> still there. This command line option was supposed to be just
>> something extra. Anyway Tim already merged the change. Do you want to
>> revert it?
> 
> Tim, are you in favor of this change?

Definitely. I don't see much gain in .wgetrc commands that are 'hidden'
from the users by these kinds of 'obscurity' measurements. It's also a
waste of time to document commands and options separately.

> Well, not worth a revert probably, we are already exposing many options
> this way.
> 
> Giuseppe
> 
> 

With Best Regards, Tim



signature.asc
Description: OpenPGP digital signature

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-16 Thread Giuseppe Scrivano 
Tomas Hozza  writes:

> The option to turn off reading .netrc by configuration in .wgetrc is
> still there. This command line option was supposed to be just
> something extra. Anyway Tim already merged the change. Do you want to
> revert it?

Tim, are you in favor of this change?

Well, not worth a revert probably, we are already exposing many options
this way.

Giuseppe

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-16 Thread Giuseppe Scrivano 
Hi Tomas,

Tomas Hozza  writes:

> If you don't want to add new option, maybe just documenting the possibility 
> to turn off reading of .netrc would be good enough.
>
> Please let me know what is your preference as I don't have one.

I'd prefer if we just document how to turn off reading .netrc with what
we have now.  The advantage is that it can be done permanent adding the
same configuration in ~/.wgetrc.

Regards,
Giuseppe

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-16 Thread Tomas Hozza 
On 12.05.2017 22:12, Giuseppe Scrivano wrote:
> Hi Tomas,
> 
> Tomas Hozza  writes:
> 
>> Although internally code uses option for (not) reading .netrc for
>> credentials, it was not possible to turn this behavior off on command
>> line. Note that it was possible to turn it off using wgetrc.
>>
>> Idea for this change came from Bruce Jerrick (bmj...@gmail.com).
>> Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1425097
> 
> wouldn't "-e netrc=off" be sufficient?
> 
> Regards,
> Giuseppe
> 

Hello Giuseppe.

Possibly yes. The only downside is that this is not documented in man page nor 
in help message. I think that's the reason why the reporter in Fedora bug also 
proposed that this new option should be added.

If you don't want to add new option, maybe just documenting the possibility to 
turn off reading of .netrc would be good enough.

Please let me know what is your preference as I don't have one.

Thanks.

Regards,
Tomas
-- 
Tomas Hozza
Associate Manager, Software Engineering - EMEA ENG Mainstream RHEL

PGP: 1D9F3C2D
UTC+2 (CEST)
Red Hat Inc. http://cz.redhat.com

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-12 Thread Giuseppe Scrivano 
Hi Tomas,

Tomas Hozza  writes:

> Although internally code uses option for (not) reading .netrc for
> credentials, it was not possible to turn this behavior off on command
> line. Note that it was possible to turn it off using wgetrc.
>
> Idea for this change came from Bruce Jerrick (bmj...@gmail.com).
> Reference: https://bugzilla.redhat.com/show_bug.cgi?id=1425097

wouldn't "-e netrc=off" be sufficient?

Regards,
Giuseppe