Re: tests: portability fix

2023-08-03 Thread Tim Rühsen

Thanks, pushed.

On 8/2/23 11:35, Christian Weisgerber wrote:

There is a portability problem in wget's tests/Makefile, which
variously refers to "unit-tests" and "./unit-tests".  GNU make
recognizes "foo" and "./foo" as the same target.  Other make(1)
implementations may not; OpenBSD's doesn't.

Unbreak the test suite:

--- tests/Makefile.am.orig
+++ tests/Makefile.am
@@ -156,7 +156,7 @@ AM_CFLAGS = $(WERROR_CFLAGS) $(WARN_CFLAGS)
  
  CLEANFILES = *~ *.bak core core.[0-9]*
  
-TESTS = ./unit-tests$(EXEEXT) $(PX_TESTS)

+TESTS = unit-tests$(EXEEXT) $(PX_TESTS)
  TEST_EXTENSIONS = .px
  PX_LOG_COMPILER = $(PERL)
  AM_PX_LOG_FLAGS = -I$(srcdir)


OpenPGP_signature
Description: OpenPGP digital signature


tests: portability fix

2023-08-02 Thread Christian Weisgerber
There is a portability problem in wget's tests/Makefile, which
variously refers to "unit-tests" and "./unit-tests".  GNU make
recognizes "foo" and "./foo" as the same target.  Other make(1)
implementations may not; OpenBSD's doesn't.

Unbreak the test suite:

--- tests/Makefile.am.orig
+++ tests/Makefile.am
@@ -156,7 +156,7 @@ AM_CFLAGS = $(WERROR_CFLAGS) $(WARN_CFLAGS)
 
 CLEANFILES = *~ *.bak core core.[0-9]*
 
-TESTS = ./unit-tests$(EXEEXT) $(PX_TESTS)
+TESTS = unit-tests$(EXEEXT) $(PX_TESTS)
 TEST_EXTENSIONS = .px
 PX_LOG_COMPILER = $(PERL)
 AM_PX_LOG_FLAGS = -I$(srcdir)
-- 
Christian "naddy" Weisgerber  na...@mips.inka.de