[DragonFlyBSD - Bug #2993] sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
Issue #2993 has been updated by swildner.
Yes, I reported it some years ago to FreeBSD.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187831
Bug #2993: sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
http://bugs.dragonflybsd.org/issues/2993#change-13098
* Author: dcb
* Status: New
* Priority: Normal
* Assignee:
* Category:
* Target version:
sys/dev/raid/mfi/mfi_tbolt.c:1159]: (warning) Logical disjunction always
evaluates to true: EXPR != 40 || EXPR != 42.
Source code is
if (cdb[0] != 0x28 || cdb[0] != 0x2A) {
Maybe better code
if (cdb[0] != 0x28 && cdb[0] != 0x2A) {
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2993] sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
Issue #2993 has been updated by dillon.
This bug exists in FreeBSD too it seems. I don't know the correct logic
right-offhand.
-Matt
Bug #2993: sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
http://bugs.dragonflybsd.org/issues/2993#change-13093
* Author: dcb
* Status: New
* Priority: Normal
* Assignee:
* Category:
* Target version:
sys/dev/raid/mfi/mfi_tbolt.c:1159]: (warning) Logical disjunction always
evaluates to true: EXPR != 40 || EXPR != 42.
Source code is
if (cdb[0] != 0x28 || cdb[0] != 0x2A) {
Maybe better code
if (cdb[0] != 0x28 && cdb[0] != 0x2A) {
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2991] (Closed) sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition
Issue #2991 has been updated by dillon. Status changed from New to Closed fix committed to master Bug #2991: sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition http://bugs.dragonflybsd.org/issues/2991#change-13096 * Author: dcb * Status: Closed * Priority: Normal * Assignee: * Category: * Target version: sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((error = age_dma_alloc(sc) != 0)) goto fail; Maybe better code if ((error = age_dma_alloc(sc)) != 0) goto fail; -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2992] (Closed) sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition
Issue #2992 has been updated by dillon.
Status changed from New to Closed
fix committed to master
Bug #2992: sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition
http://bugs.dragonflybsd.org/issues/2992#change-13095
* Author: dcb
* Status: Closed
* Priority: Normal
* Assignee:
* Category:
* Target version:
sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition (assignment
+ comparison); Clarify expression with parentheses.
Source code is
if ((error = ((*type->constructor)(*nodepp)) != 0)) {
maybe better code
if ((error = ((*type->constructor)(*nodepp))) != 0) {
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2989] (Closed) sys/netgraph/fec/ng_fec.c:935: possible typo
Issue #2989 has been updated by dillon. Status changed from New to Closed fix committed to master Bug #2989: sys/netgraph/fec/ng_fec.c:935: possible typo http://bugs.dragonflybsd.org/issues/2989#change-13094 * Author: dcb * Status: Closed * Priority: Normal * Assignee: * Category: * Target version: 4.2.x sys/netgraph/fec/ng_fec.c:935] -> [dragonfly/sys/netgraph/fec/ng_fec.c:935]: (style) Same expression on both sides of '^'. Source code is port = (ip6->ip6_dst.s6_addr[15] ^ ip6->ip6_dst.s6_addr[15]) & mask; -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2994] (New) Intermittent boot hangs after git: hammer - HAMMER Version 7
Issue #2994 has been reported by davshao. Bug #2994: Intermittent boot hangs after git: hammer - HAMMER Version 7 http://bugs.dragonflybsd.org/issues/2994 * Author: davshao * Status: New * Priority: Normal * Assignee: * Category: * Target version: Bisected to git: hammer - HAMMER Version 7 commit 4c09d9c4fd910651904ede280ad90a4abf3fc5d7 Date: Fri Mar 17 14:06:24 2017 -0700 hammer - HAMMER Version 7 intermittent boot hangs stopping at ums0: on usb ums0: 3 buttons and [XYX] coordinates ID=0 no B_DEVMAGIC (bootdev=0) Boot proceeds normally when using verbose option which is why I can attach the verbose dmesg. The machine uses a refurbished Asus P8H77-V motherboard with several internal hard drives with different OSes using legacy BIOS. $ hammer info Volume identification Label ROOT No. Volumes 1 HAMMER Volumes /dev/serno/WD-WMAYP5624974.s3d Root Volume /dev/serno/WD-WMAYP5624974.s3d FSID9d8141cd-c974-11e5-9ccd-bd5ff4499104 HAMMER Version 6 Big-block information Total 29669 Used 9119 (30.74%) Reserved 70 (0.24%) Free20480 (69.03%) Space information No. Inodes 856028 Total size 232G (248881610752 bytes) Used 71G (30.74%) Reserved 560M (0.24%) Free 160G (69.03%) PFS information PFS# ModeSnaps 0 MASTER 0 (root PFS) ---Files p8h77v_dmesg.txt (63.3 KB) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2993] (New) sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
Issue #2993 has been reported by dcb.
Bug #2993: sys/dev/raid/mfi/mfi_tbolt.c:1159: bad expression ?
http://bugs.dragonflybsd.org/issues/2993
* Author: dcb
* Status: New
* Priority: Normal
* Assignee:
* Category:
* Target version:
sys/dev/raid/mfi/mfi_tbolt.c:1159]: (warning) Logical disjunction always
evaluates to true: EXPR != 40 || EXPR != 42.
Source code is
if (cdb[0] != 0x28 || cdb[0] != 0x2A) {
Maybe better code
if (cdb[0] != 0x28 && cdb[0] != 0x2A) {
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2992] (New) sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition
Issue #2992 has been reported by dcb.
Bug #2992: sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition
http://bugs.dragonflybsd.org/issues/2992
* Author: dcb
* Status: New
* Priority: Normal
* Assignee:
* Category:
* Target version:
sys/netgraph7/netgraph/ng_base.c:590]: (style) Suspicious condition (assignment
+ comparison); Clarify expression with parentheses.
Source code is
if ((error = ((*type->constructor)(*nodepp)) != 0)) {
maybe better code
if ((error = ((*type->constructor)(*nodepp))) != 0) {
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2991] sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition
Issue #2991 has been updated by dcb. Same thing in different file: dragonfly/sys/dev/netif/ale/if_ale.c:599]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Bug #2991: sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition http://bugs.dragonflybsd.org/issues/2991#change-13091 * Author: dcb * Status: New * Priority: Normal * Assignee: * Category: * Target version: sys/dev/netif/age/if_age.c:628]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((error = age_dma_alloc(sc) != 0)) goto fail; Maybe better code if ((error = age_dma_alloc(sc)) != 0) goto fail; -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2990] (New) sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition
Issue #2990 has been reported by dcb.
Bug #2990: sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition
http://bugs.dragonflybsd.org/issues/2990
* Author: dcb
* Status: New
* Priority: Normal
* Assignee:
* Category:
* Target version:
dragonfly/sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
Source code is
if ((status = bs->AllocatePool(EfiLoaderData, hsize,
(void **)) != EFI_SUCCESS)) {
Maybe better code
if ((status = bs->AllocatePool(EfiLoaderData, hsize,
(void **))) != EFI_SUCCESS) {
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://bugs.dragonflybsd.org/my/account
[DragonFlyBSD - Bug #2989] (New) sys/netgraph/fec/ng_fec.c:935: possible typo
Issue #2989 has been reported by dcb. Bug #2989: sys/netgraph/fec/ng_fec.c:935: possible typo http://bugs.dragonflybsd.org/issues/2989 * Author: dcb * Status: New * Priority: Normal * Assignee: * Category: * Target version: 4.2.x sys/netgraph/fec/ng_fec.c:935] -> [dragonfly/sys/netgraph/fec/ng_fec.c:935]: (style) Same expression on both sides of '^'. Source code is port = (ip6->ip6_dst.s6_addr[15] ^ ip6->ip6_dst.s6_addr[15]) & mask; -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
