DO NOT REPLY [Bug 9410] New: - Broken registry.c
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9410.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9410
Broken registry.c
Summary: Broken registry.c
Product: Apache httpd-2.0
Version: 2.0.36
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: Normal
Priority: Other
Component: mpm_winnt
AssignedTo: bugs@httpd.apache.org
ReportedBy: [EMAIL PROTECTED]
Service failing to read parameters supplied through
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Apache2\ImagePath
registry key.
Problem is in registry.c file, method ap_registry_get_array. It used to read
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Apache2
\Parameters\ConfigArgs value, which in my case is empty. But original
implementation failing to recognize empty array and is returning array with
one empty element. This empty element is inserted into argument list before
user arguments during arguments rewriting. Becouse of that user arguments are
getting ignored.
Here is simple patch:
--- registry-old.c Fri May 17 11:11:40 2002
+++ registry.c Sat May 25 05:21:54 2002
@@ -266,26 +266,21 @@
pValue,/* for value */
nSize); /* for size of value */
-nSize = 1;/* Element Count */
-tmp = pValue;
-while (tmp[0] || tmp[1])
-{
-if (!tmp[0])
-++nSize;
-++tmp;
+nSize = 0;/* Element Count */
+for (tmp = pValue; *tmp; ++tmp) {
+++nSize;
+while (*tmp) {
+++tmp;
+}
}
-
+
*parray = apr_array_make(p, nSize, sizeof(char *));
-tmp = pValue;
-newelem = (char **) apr_array_push(*parray);
-*newelem = tmp;
-while (tmp[0] || tmp[1])
-{
-if (!tmp[0]) {
-newelem = (char **) apr_array_push(*parray);
-*newelem = tmp + 1;
+for (tmp = pValue; *tmp; ++tmp) {
+newelem = (char **) apr_array_push(*parray);
+*newelem = tmp;
+while (*tmp) {
+++tmp;
}
-++tmp;
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 9410] - Broken registry.c
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9410. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9410 Broken registry.c --- Additional Comments From [EMAIL PROTECTED] 2002-05-25 05:49 --- Created an attachment (id=1939) Bug fix - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 9038] - suexec is NOT being called by Apache 2.0.36
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9038.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9038
suexec is NOT being called by Apache 2.0.36
--- Additional Comments From [EMAIL PROTECTED] 2002-05-25 07:55 ---
Yes. If we could use SuexecUserGroup directives in Directory directives,
SuexecUserGroup should have priority over userdir. But now, SuexecUserGroup
is not allowed in Directory. Can this limitation be modified as below?
--- httpd-2.0.36/modules/mappers/mod_userdir.c.org Mon Apr 29 16:45:43 2002
+++ httpd-2.0.36/modules/mappers/mod_userdir.c Sat May 25 13:30:00 2002
@@ -393,10 +393,13 @@
static void register_hooks(apr_pool_t *p)
{
static const char * const aszSucc[]={ mod_alias.c,NULL };
+#ifdef HAVE_UNIX_SUEXEC
+static const char * const suexPre[]={ mod_suexec.c,NULL };
+#endif
ap_hook_translate_name(translate_userdir,NULL,aszSucc,APR_HOOK_MIDDLE);
#ifdef HAVE_UNIX_SUEXEC
-ap_hook_get_suexec_identity(get_suexec_id_doer,NULL,NULL,APR_HOOK_MIDDLE);
+
ap_hook_get_suexec_identity(get_suexec_id_doer,suexPre,NULL,APR_HOOK_MIDDLE);
#endif
}
--- httpd-2.0.36/modules/generators/mod_suexec.c.orgThu Apr 25 16:18:39 2002
+++ httpd-2.0.36/modules/generators/mod_suexec.cSat May 25 13:56:59 2002
@@ -102,7 +102,7 @@
const char *uid, const char *gid)
{
suexec_config_t *cfg = (suexec_config_t *) mconfig;
-const char *err = ap_check_cmd_context(cmd,
NOT_IN_DIR_LOC_FILE|NOT_IN_LIMIT);
+const char *err = ap_check_cmd_context(cmd,
NOT_IN_LOCATION|NOT_IN_FILES|NOT_IN_LIMIT);
if (err != NULL) {
return err;
@@ -157,14 +157,16 @@
{
/* XXX - Another important reason not to allow this in .htaccess is that
* the ap_[ug]name2id() is not thread-safe */
-AP_INIT_TAKE2(SuexecUserGroup, set_suexec_ugid, NULL, RSRC_CONF,
+AP_INIT_TAKE2(SuexecUserGroup, set_suexec_ugid, NULL, ACCESS_CONF,
User and group for spawned processes),
{ NULL }
};
static void suexec_hooks(apr_pool_t *p)
{
-ap_hook_get_suexec_identity(get_suexec_id_doer,NULL,NULL,APR_HOOK_MIDDLE);
+static const char * const suexSucc[]={ mod_userdir.c,NULL };
+
+
ap_hook_get_suexec_identity(get_suexec_id_doer,NULL,suexSucc,APR_HOOK_MIDDLE);
ap_hook_post_config(suexec_post_config,NULL,NULL,APR_HOOK_MIDDLE);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 9412] - C CGI not working
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9412. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9412 C CGI not working [EMAIL PROTECTED] changed: What|Removed |Added Summary|C CGI not working |C CGI not working --- Additional Comments From [EMAIL PROTECTED] 2002-05-25 08:10 --- I am using a ScriptAlias directive in httpd.conf file ScriptAlias /scripts/ c:/Inetpub/Scripts/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 9413] New: - apr_pool_userdata_set() should be used in mod_auth_digest.c, mod_suexec.c, ssl_scache.c.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9413.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9413
apr_pool_userdata_set() should be used in mod_auth_digest.c, mod_suexec.c,
ssl_scache.c.
Summary: apr_pool_userdata_set() should be used in
mod_auth_digest.c, mod_suexec.c, ssl_scache.c.
Product: Apache httpd-2.0
Version: 2.0.36
Platform: PC
OS/Version: Solaris
Status: NEW
Severity: Major
Priority: Other
Component: All
AssignedTo: bugs@httpd.apache.org
ReportedBy: [EMAIL PROTECTED]
To use apr_pool_userdata_setn() in post_config functions of DSO modules
is not good. I experienced SEGV at httpd startup.
--- httpd-2.0.36/modules/aaa/mod_auth_digest.c.org Sun Apr 28 18:02:19 2002
+++ httpd-2.0.36/modules/aaa/mod_auth_digest.c Fri May 24 21:39:42 2002
@@ -384,7 +384,7 @@
* set up our static data on the second call. */
apr_pool_userdata_get(data, userdata_key, s-process-pool);
if (!data) {
-apr_pool_userdata_setn((const void *)1, userdata_key,
+apr_pool_userdata_set((const void *)1, userdata_key,
apr_pool_cleanup_null, s-process-pool);
return OK;
}
--- httpd-2.0.36/modules/generators/mod_suexec.c.orgThu Apr 25 16:18:39 2002
+++ httpd-2.0.36/modules/generators/mod_suexec.cSat May 25 13:56:59 2002
@@ -141,7 +141,7 @@
ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_NOTICE, 0, s,
suEXEC mechanism enabled (wrapper: %s), SUEXEC_BIN);
-apr_pool_userdata_setn((void *)1, SUEXEC_POST_CONFIG_USERDATA,
+apr_pool_userdata_set((void *)1, SUEXEC_POST_CONFIG_USERDATA,
apr_pool_cleanup_null, s-process-pool);
}
--- httpd-2.0.36/modules/ssl/ssl_scache.c.org Thu Mar 28 08:25:58 2002
+++ httpd-2.0.36/modules/ssl/ssl_scache.c Fri May 24 22:15:04 2002
@@ -94,7 +94,7 @@
apr_pool_userdata_get(data, userdata_key, s-process-pool);
if (!data) {
-apr_pool_userdata_setn((const void *)1, userdata_key,
+apr_pool_userdata_set((const void *)1, userdata_key,
apr_pool_cleanup_null, s-process-pool);
return;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 9413] - apr_pool_userdata_set() should be used in mod_auth_digest.c, mod_suexec.c, ssl_scache.c.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9413. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9413 apr_pool_userdata_set() should be used in mod_auth_digest.c, mod_suexec.c, ssl_scache.c. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-05-25 14:39 --- Right you are... Brad Nicholes had already caught one of these after 2.0.36 was released. Justin Erenkrantz caught a similar one in PHP4 not long ago as well. I've committed your patch for the two remaining modules that were doing this. Thanks for using Apache! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 8540] - apr_thread_mutex_pool_get segfaults at startup
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8540. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8540 apr_thread_mutex_pool_get segfaults at startup [EMAIL PROTECTED] changed: What|Removed |Added Summary|httpd could not be started |apr_thread_mutex_pool_get ||segfaults at startup --- Additional Comments From [EMAIL PROTECTED] 2002-05-25 21:46 --- Can you please verify that this is still happening with a later version? The backtrace you gave was unfortunately not very helpful because of (apparently) some bug in the debugger (which caused all those internal error messages). If you can still reproduce the problem, can you do it with the --enable- maintainer-mode configure flag as well? Also please specify which configure flags you used and the output of ./httpd -l and ./httpd -V . Thanks! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
