[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #14 from Sarva --- Still seeing the same errors in Apache/2.4.53, any idea when this patch will be merged? Thanks. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 Paulo M changed: What|Removed |Added CC||mentalstring+apache@gmail.c ||om -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 Paulo M changed: What|Removed |Added CC||cheng0...@gmail.com --- Comment #13 from Paulo M --- *** Bug 62866 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #12 from Paulo M --- I'm having the same problem caused by AWS's NLB use of LOCAL. I have tried the two patches and it successfully stopped the "RemoteIPProxyProtocol: unsupported command 20" and the log of 400 errors which makes the NLB health check pass. However, I'm still seeing a bunch of these happening which are generated by the same health check requests: [remoteip:error] [pid 9861:tid 140156862461504] (70014)End of file found: [client 10.0.0.x:22257] AH10184: failed reading input -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #11 from Yann Ylavic --- (In reply to Avinash S from comment #10) > would like to contribute in bug fixes/new features. > Could you please help me in providing details on process for the same. Thanks for proposing! The best way to contribute is to propose the patch(es) and rationale on the d...@httpd.apache.org mailing list, or for existing bugzilla tickets simply attach the proposed fix there. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #10 from Avinash S --- Hi Joe, This patch is working fine. Hi Joe, would like to contribute in bug fixes/new features. Could you please help me in providing details on process for the same. Thanks, Avinash -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #9 from Joe Orton --- Created attachment 37712 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37712=edit don't log 400 for LOCAL PROXY connections Can you try this patch? We really need a test suite for this stuff. :( -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #8 from Avinash S --- Btw, I was developing proxy protocol for my company and found across this issue still. is the above mentioned fix is fine ? what's your opinion ? Thanks, Avinash -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 Avinash S changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893
--- Comment #7 from Avinash S ---
This looks to be not working still.
Since, we are checking for
if (!conn_config->client_addr) {
ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, APLOGNO(03496)
"RemoteIPProxyProtocol data is missing, but required!
Aborting request.");
return HTTP_BAD_REQUEST;
}
We still return 400 Bad requests.
We may need to do something like below under switch statement
case 0x00: /* LOCAL command */
case 0x01: /* PROXY command */
switch (hdr->v2.fam) {
case 0x11: /* TCPv4 */
ret = apr_sockaddr_info_get(_conf->client_addr, NULL,
APR_INET,
ntohs(hdr->v2.addr.ip4.src_port),
0, c->pool
And go ahead parsing client info even for LOCAL and so that
conn_config->client_addr is populated.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 Giovanni Bechis changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED Keywords||FixedInTrunk --- Comment #6 from Giovanni Bechis --- Committed to trunk in r1874344. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 Giovanni Bechis changed: What|Removed |Added Attachment #36992|0 |1 is obsolete|| --- Comment #5 from Giovanni Bechis --- Created attachment 36993 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36993=edit prevent logging local proxy connections Looks fine as well, diff updated. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #4 from Joe Orton --- Doing "return HDR_DONE" in the LOCAL case looks simpler -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 Giovanni Bechis changed: What|Removed |Added Attachment #36986|0 |1 is obsolete|| --- Comment #3 from Giovanni Bechis --- Created attachment 36992 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36992=edit prevent logging local proxy connections >From protocol specs (https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt): "...When used with a LOCAL command, the receiver must accept the connection and ignore any address information" The updated patch doesn't compute the client ip in the local connection case. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 Eric Covener changed: What|Removed |Added Status|NEW |NEEDINFO Keywords||PatchAvailable --- Comment #2 from Eric Covener --- (In reply to Giovanni Bechis from comment #1) > Created attachment 36986 [details] > Patch to prevent from logging local proxy connections desk-checking patch and not too familiar with this module/protocol, should we be returning over the apr_sockaddr_ip_get() below the switch? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 --- Comment #1 from Giovanni Bechis --- Created attachment 36986 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36986=edit Patch to prevent from logging local proxy connections -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893 chip.edwa...@galaxypost.net changed: What|Removed |Added CC||chip.edwa...@galaxypost.net -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
