Installer keeps saying 'No OpenBSD partition in GPT' when manually editing partitions

2016-01-07 Thread valr
Hi,

I've just performed installation of OpenBSD 5.9 beta (snapshot of
05/01/2016) on an amd64 using EFI & GPT.

It's a multi-boot installation on a single disk, meaning I've edited
the partitions by hand instead of using the entire disk for OpenBSD.

When manually editing the partitions, I first receive a message
mentioning what's expected:

"You will now create two GPT partitions. The first must have an id
of 'EF' and be large enough to contain the OpenBSD boot programs,
at least 960 blocks. The second must have an id of 'A6' and will
contain your OpenBSD data. Neither may overlap other partitions.
Inside the fdisk command, the 'manual' command describes the fdisk
commands in detail."

(copied from 'md_prep_fdisk' function
in /distrib/amd64/common/install.md

I've created the 2 partitions, however when exiting fdisk, the
installer was continously giving this error message: 

"No OpenBSD partition in GPT".

When looking at the code of the disk_has function
in /distrib/miniroot/install.sub, I see that it checks both the type of
the partition, and also the _name_ of the partition:

local _p_gpt_openbsd='^[ ]+OpenBSD[ ]+OpenBSD Area'
local _p_gpt_efisys='^[ ]+EFI Sys[ ]+EFI System Area'

Knowing that, I just had to use fdisk to rename the partitions as
expected.

Should the message provided when manually editing the partition not
mention this info? Something like this:

"You will now create two GPT partitions. The first must have an id
of 'EF', name of 'EFI System Area' and be large enough to contain the
OpenBSD boot programs, at least 960 blocks. The second must have an id
of 'A6', name of 'OpenBSD Area' and will contain your OpenBSD data.
Neither may overlap other partitions. Inside the fdisk command, the
'manual' command describes the fdisk commands in detail."

Apart from that, the installation went fine.
I didn't encounter any problem, neither with EFI nor with the GPT
partitioning itself.

Thanks for this excellent job!

Cheers,
Valere



Minor text reference error in isakmpd.policy(5)

2016-01-07 Thread Julian Hsiao
In isakmpd.policy.5, the snippet on line 309 ~ 310

"[...] see the pfs attribute above [...]"
 ^
should be

"[...] see the pfs attribute below [...]"
 ^

since the description for pfs attribute starts at line 415.



Re: Minor text reference error in isakmpd.policy(5)

2016-01-07 Thread Jason McIntyre
On Thu, Jan 07, 2016 at 08:53:44PM -0800, Julian Hsiao wrote:
> In isakmpd.policy.5, the snippet on line 309 ~ 310
> 
> "[...] see the pfs attribute above [...]"
>  ^
> should be
> 
> "[...] see the pfs attribute below [...]"
>  ^
> 
> since the description for pfs attribute starts at line 415.
> 

fixed, thanks.
jmc