Re: VMM owner needs to be part of wheel

2018-06-17 Thread Mike Larkin
On Mon, Jun 18, 2018 at 12:05:43AM +0200, Reyk Floeter wrote:
> Hi,
> 
> changing the umask in control.c could fix it. There’s no need to restrict it 
> to wheel since vmd checks the permissions based on configuration internally. 
> Having the vmd socket world-writable should be OK.
> 
> But we could eventually use a group _vmd to shield off users who shouldn’t 
> even be able to do anything. But this doesn’t make much sense - it would be a 
> bit like restricting users from running ps a.
> 
> I can make a diff tomorrow.
> 
> Reyk
> 

Thanks Reyk! I'm sure you will come up with the right solution.

-ml

> Am 17.06.2018 um 22:35 schrieb obs...@high5.nl:
> 
> >> Synopsis:VMM owner needs to be part of group wheel in order to run 
> >> vmctl console|start|stop
> >> Category:system
> >> Environment:
> >System  : OpenBSD 6.3
> >Details : OpenBSD 6.3 (GENERIC.MP) #3: Fri May 18 00:06:26 CEST 2018
> > 
> > r...@syspatch-63-amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> > 
> >Architecture: OpenBSD.amd64
> >Machine : amd64
> >> Description:
> >When some level of vmctl is needed for users they are currently required 
> > to be part of group wheel. It would be great from a hosting perspective to 
> > allow users to control their own VM and attach to tJhe console. I started a 
> > small project to host OpenBSD VMs for the community out of Amsterdam and I 
> > would love to provide users access to their own VM.
> >> How-To-Repeat:
> >Set the owner who is not in wheel will result in a message like:
> >vmctl: command failed: Operation not permitted
> >> Fix:
> >The current work around is to add the user to group wheel, which is 
> > might be ok for trusted users.
> > 
> > 
> > dmesg:
> > OpenBSD 6.3 (GENERIC.MP) #3: Fri May 18 00:06:26 CEST 2018
> >
> > r...@syspatch-63-amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> > real mem = 8544342016 (8148MB)
> > avail mem = 8278310912 (7894MB)
> > mpath0 at root
> > scsibus0 at mpath0: 256 targets
> > mainbus0 at root
> > bios0 at mainbus0: SMBIOS rev. 2.7 @ 0xe9750 (56 entries)
> > bios0: vendor American Megatrends Inc. version "2.0b" date 09/17/2012
> > bios0: Supermicro X9SCL/X9SCM
> > acpi0 at bios0: rev 2
> > acpi0: sleep states S0 S1 S4 S5
> > acpi0: tables DSDT FACP APIC FPDT MCFG HPET SSDT SPMI SSDT SSDT EINJ ERST 
> > HEST BERT BGRT
> > acpi0: wakeup devices PS2K(S4) PS2M(S4) UAR1(S4) UAR2(S4) P0P1(S4) USB1(S4) 
> > USB2(S4) USB3(S4) USB4(S4) USB5(S4) USB6(S4) USB7(S4) PXSX(S4) RP01(S4) 
> > PXSX(S4) RP02(S4) [...]
> > acpitimer0 at acpi0: 3579545 Hz, 24 bits
> > acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
> > cpu0 at mainbus0: apid 0 (boot processor)
> > cpu0: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.45 MHz
> > cpu0: 
> > FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN
> > cpu0: 256KB 64b/line 8-way L2 cache
> > acpitimer0: recalibrated TSC frequency 3100015637 Hz
> > cpu0: smt 0, core 0, package 0
> > mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges
> > cpu0: apic clock running at 100MHz
> > cpu0: mwait min=64, max=64, C-substates=0.2.1.1, IBE
> > cpu1 at mainbus0: apid 2 (application processor)
> > cpu1: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.03 MHz
> > cpu1: 
> > FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN
> > cpu1: 256KB 64b/line 8-way L2 cache
> > cpu1: smt 0, core 1, package 0
> > cpu2 at mainbus0: apid 4 (application processor)
> > cpu2: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.03 MHz
> > cpu2: 
> > FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN
> > cpu2: 256KB 64b/line 8-way L2 cache
> > cpu2: smt 0, core 2, package 0
> > cpu3 at mainbus0: apid 6 (application processor)
> > cpu3: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.03 MHz
> > cpu3: 
> > 

Re: More potential memory leaks based on not freeing getaddrinfo

2018-06-17 Thread Jeremie Courreges-Anglas
On Fri, Jun 15 2018, Thomas Barabosch  
wrote:
> Hi there,
>
> yesterday I stumbled upon a memory leak in route6d, which got fixed. I
> was curious if I could find similar leaks. Please correct me if I am
> wrong but I suppose static analysis tools like coverity or clang
> analyzer do not detect this kind of bug since they do not know anything
> about the semantics of getaddrinfo/freeaddrinfo.
>
> So I wrote a small script to check all .c-files that call getaddrinfo
> but do not call freeaddrinfo. Note that some of them may be false
> positives, i.e. the addrinfo struct is actually free'd in another source
> file. I had a look at some of the cases (but not all!). I've appended
> the output to the end of this email.
>
> usr.bin/ssh/servconf.c
>
> I think that a leak in usr.bin/ssh/servconf.c should be plugged. In
> function add_one_listen_addr, there is a call to getaddrinfo. This
> function is called in a loop in function add_listen_addr. So in this
> case that should leak memory depending on the number of loop iterations,
> right?

Doesn't look like a leak, the resulting list is pushed on top of
the previously stored ones.

> 
>
> libexec/mail.local/mail.local.c
>
> In the case of mail.local, you may argument that this program terminates
> rather quickly and the memory is free'd by the kernel anyways. But it
> would be easy to fix.

Variable "res0" is static, the code wants to cache the getaddrinfo
result.  I see no reason to add complexity to free this result at exit
time.

> 
>
> openbsd/usr.sbin/ndp/ndp.c
>
> Same as mail.local, easy to fix.

Already fixed by your diff.

> 
>
> usr.sbin/npppd/common/net_utils.c
>
> Seems to be a false positive.

and the function looks unused.

> 
>
> usr.sbin/smtpd/smtpc.c
>
> Static variable, should be free'd once the program terminates.

Yep.

> 
>
> usr.sbin/ikectl/parser.c
>
> getaddrinfo is called in function parse_addr (line 267). This function
> is called by function match_token (line 284), which happens in a
> for-loop. In this for loop, there is a case-matching. If the token
> matches ADDRESS or FQDN, parse_addr is called twice each time. So it
> leaks depending on the number of ADDRESS + FQDN tokens multiplied by two
> times. 

Fixed proposed by benno@

> 
>
> usr.sbin/radiusd/util.c
>
> False positive. getaddrinfo is called in util function addrport_parse
> and the addrinfo struct is returned by this function. However, it seems
> to be properly free'd in radiusd_radius.c.

Yep.

> 
>
> Could you please have a look at these cases? May be I am missing
> something here! Please note that the above method is very raw. It just
> greps for strings, there is no (sophisticated) static analysis involved
> similar to modules for malloc/free issue detection. Nevertheless, I
> thought that this may be of interest to you.

raw but it's already a good start. :)

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE



Re: VMM owner needs to be part of wheel

2018-06-17 Thread Reyk Floeter
Hi,

changing the umask in control.c could fix it. There’s no need to restrict it to 
wheel since vmd checks the permissions based on configuration internally. 
Having the vmd socket world-writable should be OK.

But we could eventually use a group _vmd to shield off users who shouldn’t even 
be able to do anything. But this doesn’t make much sense - it would be a bit 
like restricting users from running ps a.

I can make a diff tomorrow.

Reyk

Am 17.06.2018 um 22:35 schrieb obs...@high5.nl:

>> Synopsis:VMM owner needs to be part of group wheel in order to run vmctl 
>> console|start|stop
>> Category:system
>> Environment:
>System  : OpenBSD 6.3
>Details : OpenBSD 6.3 (GENERIC.MP) #3: Fri May 18 00:06:26 CEST 2018
> 
> r...@syspatch-63-amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> 
>Architecture: OpenBSD.amd64
>Machine : amd64
>> Description:
>When some level of vmctl is needed for users they are currently required 
> to be part of group wheel. It would be great from a hosting perspective to 
> allow users to control their own VM and attach to tJhe console. I started a 
> small project to host OpenBSD VMs for the community out of Amsterdam and I 
> would love to provide users access to their own VM.
>> How-To-Repeat:
>Set the owner who is not in wheel will result in a message like:
>vmctl: command failed: Operation not permitted
>> Fix:
>The current work around is to add the user to group wheel, which is might 
> be ok for trusted users.
> 
> 
> dmesg:
> OpenBSD 6.3 (GENERIC.MP) #3: Fri May 18 00:06:26 CEST 2018
>
> r...@syspatch-63-amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> real mem = 8544342016 (8148MB)
> avail mem = 8278310912 (7894MB)
> mpath0 at root
> scsibus0 at mpath0: 256 targets
> mainbus0 at root
> bios0 at mainbus0: SMBIOS rev. 2.7 @ 0xe9750 (56 entries)
> bios0: vendor American Megatrends Inc. version "2.0b" date 09/17/2012
> bios0: Supermicro X9SCL/X9SCM
> acpi0 at bios0: rev 2
> acpi0: sleep states S0 S1 S4 S5
> acpi0: tables DSDT FACP APIC FPDT MCFG HPET SSDT SPMI SSDT SSDT EINJ ERST 
> HEST BERT BGRT
> acpi0: wakeup devices PS2K(S4) PS2M(S4) UAR1(S4) UAR2(S4) P0P1(S4) USB1(S4) 
> USB2(S4) USB3(S4) USB4(S4) USB5(S4) USB6(S4) USB7(S4) PXSX(S4) RP01(S4) 
> PXSX(S4) RP02(S4) [...]
> acpitimer0 at acpi0: 3579545 Hz, 24 bits
> acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
> cpu0 at mainbus0: apid 0 (boot processor)
> cpu0: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.45 MHz
> cpu0: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN
> cpu0: 256KB 64b/line 8-way L2 cache
> acpitimer0: recalibrated TSC frequency 3100015637 Hz
> cpu0: smt 0, core 0, package 0
> mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges
> cpu0: apic clock running at 100MHz
> cpu0: mwait min=64, max=64, C-substates=0.2.1.1, IBE
> cpu1 at mainbus0: apid 2 (application processor)
> cpu1: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.03 MHz
> cpu1: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN
> cpu1: 256KB 64b/line 8-way L2 cache
> cpu1: smt 0, core 1, package 0
> cpu2 at mainbus0: apid 4 (application processor)
> cpu2: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.03 MHz
> cpu2: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN
> cpu2: 256KB 64b/line 8-way L2 cache
> cpu2: smt 0, core 2, package 0
> cpu3 at mainbus0: apid 6 (application processor)
> cpu3: Intel(R) Xeon(R) CPU E3-1220 V2 @ 3.10GHz, 3100.03 MHz
> cpu3: 
> FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,IBRS,IBPB,STIBP,SENSOR,ARAT,MELTDOWN
> cpu3: 256KB 64b/line 8-way L2 cache
> cpu3: smt 0, core 3, package 0
> ioapic0 at mainbus0: apid 2 pa 0xfec0, version 20, 24 pins
> acpimcfg0 at acpi0 addr 0xe000, bus 0-255
> acpihpet0 at acpi0: 14318179 Hz
> acpihpet0: recalibrated TSC frequency 3100013079 

Re: afterboot.8 nitpick

2018-06-17 Thread Jason McIntyre
On Sat, Jun 16, 2018 at 11:56:44AM +0100, Jason McIntyre wrote:
> On Fri, Jun 15, 2018 at 11:38:27AM +0100, Pedro Caetano wrote:
> > Hi bugs@
> > 
> > I spent some time reading afterboot.8 and noticed a few discrepancies with
> > reality.
> > Output from netstat(1) and from ifconfig(8) itself has changed lately.
> > 
> > I wasn't able to validate the correct output from the ppp(4), but based my
> > patch on gre(4) which i guess is similar enough.
> > 
> > Thank you for your time working on your project!
> > 
> > Best regards,
> > Pedro Caetano
> > 
> 
> morning.
> 
> the trouble with making changes like this is that we're playing catchup.
> i don;t think the actual output being in sync is going to make much
> difference to the afterboot(8) reader. in fact i am tempted to say it
> would make more sense to squash all the example output in that section -
> it doesn;t tell you anything anyway.
> 
> if anyone can think of reasons why it is helpful, we could update it i
> suppose. but, does anyone? if not i will squash it.
> 
> jmc
> 

no feedback, so below is my proposed diff.
jmc

Index: afterboot.8
===
RCS file: /cvs/src/share/man/man8/afterboot.8,v
retrieving revision 1.160
diff -u -r1.160 afterboot.8
--- afterboot.8 7 Sep 2017 13:08:39 -   1.160
+++ afterboot.8 17 Jun 2018 19:55:31 -
@@ -152,7 +152,7 @@
 You will also need to edit the
 .Pa /etc/myname
 file to have it stick around for the next reboot.
-.Ss Verify network interface configuration
+.Ss Verify network interface configuration and routing tables
 The first thing to do is an
 .Ic ifconfig -a
 to see if the network interfaces are properly configured.
@@ -171,65 +171,17 @@
 man page for more information on the format of
 .Pa /etc/hostname. Ns Ar interface
 files.
-The loopback interface will look something like:
-.Bd -literal -offset indent
-lo0: flags=8009 mtu 32972
-   inet6 fe80::1%lo0 prefixlen 64 scopeid 0x3
-   inet6 ::1 prefixlen 128
-   inet 127.0.0.1 netmask 0xff00
-.Ed
-.Pp
-an Ethernet interface something like:
-.Bd -literal -offset indent
-em0: flags=9863
-   inet 192.168.4.52 netmask 0xff00 broadcast 192.168.4.255
-   inet6 fe80::5ef0:f0f0%em0 prefixlen 64 scopeid 0x1
-.Ed
-.Pp
-and a PPP interface something like:
-.Bd -literal -offset indent
-ppp0: flags=8051
-inet 203.3.131.108 --> 198.181.0.253 netmask 0x
-.Ed
 .Pp
 See
 .Xr netstart 8
 for instructions on configuring multicast routing.
-.Pp
 See
 .Xr hostname.if 5
 for instructions on configuring interfaces with DHCP.
-.Ss Check routing tables
-Issue a
+.Pp
+Routing tables can be viewed by issuing a
 .Ic netstat -rn
 command.
-The output will look something like:
-.Bd -literal -offset indent
-Routing tables
-
-Internet:
-DestinationGateway   Flags  Refs Use  Mtu  Interface
-default192.168.4.254 UGS  0 11098028-  em0
-127127.0.0.1 UGRS 00-  lo0
-127.0.0.1  127.0.0.1 UH   3   24-  lo0
-192.168.4  link#1UC   00-  em0
-192.168.4.52   8:0:20:73:b8:4a   UHL  1 6707-  em0
-192.168.4.254  0:60:3e:99:67:ea  UHL  10-  em0
-
-Internet6:
-DestinationGateway   Flags  Refs  Use Mtu  Interface
-::/96  ::1   UGRS 0 0   32972  lo0 =>
-::1::1   UH   4 0   32972  lo0
-:::0.0.0.0/96  ::1   UGRS 0 0   32972  lo0
-fc80::/10  ::1   UGRS 0 0   32972  lo0
-fe80::/10  ::1   UGRS 0 0   32972  lo0
-fe80::%em0/64  link#1UC   0 01500  em0
-fe80::%lo0/64  fe80::1%lo0   U0 0   32972  lo0
-ff01::/32  ::1   U0 0   32972  lo0
-ff02::%em0/32  link#1UC   0 01500  em0
-ff02::%lo0/32  fe80::1%lo0   UC   0 0   32972  lo0
-.Ed
-.Pp
 The default gateway address is stored in the
 .Pa /etc/mygate
 file.



Re: More potential memory leaks based on not freeing getaddrinfo

2018-06-17 Thread Jeremie Courreges-Anglas
On Sat, Jun 16 2018, Sebastian Benoit  wrote:
> fix for usr.sbin/ikectl/parser.c
>
> ok?

ok jca@

> diff --git usr.sbin/ikectl/parser.c usr.sbin/ikectl/parser.c
> index 52488845fd3..32099bb3b3d 100644
> --- usr.sbin/ikectl/parser.c
> +++ usr.sbin/ikectl/parser.c
> @@ -273,6 +273,7 @@ parse_addr(const char *word)
>   hints.ai_family = PF_UNSPEC;
>   hints.ai_flags = AI_NUMERICHOST;
>   if (getaddrinfo(word, "0", , ) == 0) {
> + freeaddrinfo(r);
>   return (0);
>   }
>  
> @@ -327,7 +328,6 @@ match_token(char *word, const struct token table[])
>   case ADDRESS:
>   case FQDN:
>   if (!match && word != NULL && strlen(word) > 0) {
> - parse_addr(word);
>   res.host = strdup(word);
>   if (parse_addr(word) == 0)
>   res.htype = HOST_IPADDR;

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE



Re: finger does not expand '&' to username

2018-06-17 Thread Sebastian Benoit
Andreas Kusalananda K?h?ri(andreas.kah...@icm.uu.se) on 2018.06.17 12:41:13 
+0200:
> >Synopsis:  finger does not expand '&' to username
> >Category:  documentation
> >Environment:
> System  : OpenBSD 6.3
> Details : OpenBSD 6.3-current (GENERIC.MP) #63: Thu Jun 14 
> 15:08:23 CEST 2018
>  
> kk@box.local:/extra/src/sys/arch/amd64/compile/GENERIC.MP
> 
> Architecture: OpenBSD.amd64
> Machine : amd64
> >Description:
> 
> The passwd(5) documentation says:
> 
>  The full name may contain an ampersand (???&???), which will be replaced 
> by
>  the capitalized login name when the gecos field is displayed or used by
>  various programs such as finger(1), sendmail(8), etc.
> 
> But finger(1) does not do this.
> 
> >How-To-Repeat:
> 
> $ getent passwd operator
> operator:*:2:5:System &:/operator:/sbin/nologin
> 
> $ finger operator
> Login: operator Name: System &
> Directory: /operatorShell: /sbin/nologin
> Never logged in.
> No Mail.
> No Plan.
> 
> >Fix:
> 
> Update the documentation in passwd(5) (or fix finger(1) behaviour).

i think rev 1.29 on 2014/11/19 broke this.

Here is a fix:

diff --git usr.bin/finger/util.c usr.bin/finger/util.c
index 380c06682aa..32d7b7c04bb 100644
--- usr.bin/finger/util.c
+++ usr.bin/finger/util.c
@@ -104,7 +104,7 @@ userinfo(PERSON *pn, struct passwd *pw)
if (!(p = strsep(, ",")))
return;
expandusername(p, pw->pw_name, name, sizeof(name));
-   if (stravis(>realname, p, VIS_SAFE|VIS_NOSLASH) == -1)
+   if (stravis(>realname, name, VIS_SAFE|VIS_NOSLASH) == -1)
err(1, "stravis");
if ((p = strsep(, ",")) && *p) {
if (stravis(>office, p, VIS_SAFE|VIS_NOSLASH) == -1)



generic.mp#25 amd64 and systq panics

2018-06-17 Thread Andrew

GENERIC.MP #25 amd64

panic: attempt to execute user address 0x0 in supervisor mode
Stopped at db_enter+0x12; popq %r11
TID PID UID PRFLAGS PFLAGS  CPU COMMAND
25928   84725   74  0x1000120x480   1   pflogd
*398570 52393   0   0x14000 0x200   0K  systq
db_enter() at db_enter+0x12
panic() at panic+0x138
pageflttrap() at pageflttrap+0x2c8
trap(7bfcf2c1ecf7f48f) at trap+0x319
alltraps_kern(6,80002287bf70,7236c4f0141a92c3,81c9ad98,206,1)
at alltraps_kern+0x7e
0(0,0817aeda0,0,0) at 0
end trace frame: 0x0, count: 9

---

I rebooted to get the latest dmesg and the box crashed again after about
a minute. (this time without the ethernet attached to the nic) with
this message:

panic: attempt to excute user address 0x0 in supervisor mode
stopped at db_enter+0x12; popq %r11
TID	PID	UID	PRFLAGS	PFLAGS	CPU	COMMAND 
*355152	73053	o	0x1400	0x200	oK	systq

db_enter() at db_enter+0x12
panic() at panic+0x138
pageflttrap at pageflttrap+0x2c8
trap(6609498b08ff615ab) at trap+0x319
alltraps_kern(6,80002287cd90,3dbbbffb823ee66d,81c93c20,202,1)
at alltraps_kern+0x7e
0(0,0,817dc770,0,0,0) at 0
end trace frame: 0x0 count:9


Thanks to all -- hope this helps !!!

---

OpenBSD 6.3-current (GENERIC.MP) #25: Sun Jun 17 08:13:18 MDT 2018
   dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 3672432640 (3502MB)
avail mem = 3518271488 (3355MB)
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.7 @ 0xec040 (47 entries)
bios0: vendor American Megatrends Inc. version "0602" date 04/28/2014
bios0: ASUS All Series
acpi0 at bios0: rev 2
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP APIC FPDT MCFG HPET BGRT SSDT SSDT CRAT SSDT
acpi0: wakeup devices RLAN(S4) UASM(S4) SBAZ(S4) PS2K(S4) UAR1(S4) OHC1(S4) 
EHC1(S4) OHC2(S4) EHC2(S4) OHC3(S4) EHC3(S4) XHC0(S4) PX16(S4) GPP0(S4) GPP1(S4)
acpitimer0 at acpi0: 3579545 Hz, 32 bits
acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: AMD Sempron(tm) 2650 APU with Radeon(tm) R3, 1447.48 MHz
cpu0: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TOPEXT,DBKP,PCTRL3,ITSC,BMI1,XSAVEOPT
cpu0: 32KB 64b/line 2-way I-cache, 32KB 64b/line 8-way D-cache, 1MB 64b/line 
16-way L2 cache
cpu0: ITLB 32 4KB entries fully associative, 8 4MB entries fully associative
cpu0: DTLB 40 4KB entries fully associative, 8 4MB entries fully associative
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
cpu0: apic clock running at 99MHz
cpu0: mwait min=64, max=64, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: AMD Sempron(tm) 2650 APU with Radeon(tm) R3, 1447.29 MHz
cpu1: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,MMX,FXSR,SSE,SSE2,HTT,SSE3,PCLMUL,MWAIT,SSSE3,CX16,SSE4.1,SSE4.2,MOVBE,POPCNT,AES,XSAVE,AVX,F16C,NXE,MMXX,FFXSR,PAGE1GB,RDTSCP,LONG,LAHF,CMPLEG,SVM,EAPICSP,AMCR8,ABM,SSE4A,MASSE,3DNOWP,OSVW,IBS,SKINIT,TOPEXT,DBKP,PCTRL3,ITSC,BMI1,XSAVEOPT
cpu1: 32KB 64b/line 2-way I-cache, 32KB 64b/line 8-way D-cache, 1MB 64b/line 
16-way L2 cache
cpu1: ITLB 32 4KB entries fully associative, 8 4MB entries fully associative
cpu1: DTLB 40 4KB entries fully associative, 8 4MB entries fully associative
cpu1: smt 0, core 1, package 0
ioapic0 at mainbus0: apid 3 pa 0xfec0, version 21, 24 pins
ioapic1 at mainbus0: apid 4 pa 0xfec01000, version 21, 32 pins
acpimcfg0 at acpi0 addr 0xe000, bus 0-255
acpihpet0 at acpi0: 14318180 Hz
acpiprt0 at acpi0: bus 0 (PCI0)
acpiprt1 at acpi0: bus 3 (GPP2)
acpiprt2 at acpi0: bus 4 (GPP3)
acpiprt3 at acpi0: bus -1 (PX16)
acpiprt4 at acpi0: bus 1 (GPP0)
acpiprt5 at acpi0: bus 2 (GPP1)
acpicpu0 at acpi0: C2(0@400 io@0x414), C1(@1 halt!), PSS
acpicpu1 at acpi0: C2(0@400 io@0x414), C1(@1 halt!), PSS
acpicmos0 at acpi0
"MSFT0001" at acpi0 not configured
acpibtn0 at acpi0: PWRB
"PNP0C14" at acpi0 not configured
cpu0: 1447 MHz: speeds: 1450 1250 1050 900 800 MHz
pci0 at mainbus0 bus 0
pchb0 at pci0 dev 0 function 0 "AMD AMD64 16h Host" rev 0x00
radeondrm0 at pci0 dev 1 function 0 vendor "ATI", unknown product 0x9838 rev 
0x00
drm0 at radeondrm0
radeondrm0: msi
azalia0 at pci0 dev 1 function 1 "ATI Radeon HD Audio" rev 0x00: msi
azalia0: no supported codecs
pchb1 at pci0 dev 2 function 0 vendor "AMD", unknown product 0x1538 rev 0x00
ppb0 at pci0 dev 2 function 2 "AMD AMD64 16h PCIE" rev 0x00: msi
pci1 at ppb0 bus 1
re0 at pci1 dev 0 function 0 "Realtek 8168" rev 0x06: RTL8168E/8111E (0x2c00), 
msi, address 00:e0:53:15:af:6e
rgephy0 at re0 phy 7: RTL8169S/8110S/8211 PHY, rev. 4
ppb1 at pci0 dev 2 function 3 "AMD AMD64 16h PCIE" rev 0x00: msi
pci2 at ppb1 bus 2
re1 at pci2 dev 

finger does not expand '&' to username

2018-06-17 Thread Andreas Kusalananda Kähäri
>Synopsis:  finger does not expand '&' to username
>Category:  documentation
>Environment:
System  : OpenBSD 6.3
Details : OpenBSD 6.3-current (GENERIC.MP) #63: Thu Jun 14 15:08:23 
CEST 2018
 
kk@box.local:/extra/src/sys/arch/amd64/compile/GENERIC.MP

Architecture: OpenBSD.amd64
Machine : amd64
>Description:

The passwd(5) documentation says:

 The full name may contain an ampersand (‘&’), which will be replaced by
 the capitalized login name when the gecos field is displayed or used by
 various programs such as finger(1), sendmail(8), etc.

But finger(1) does not do this.

>How-To-Repeat:

$ getent passwd operator
operator:*:2:5:System &:/operator:/sbin/nologin

$ finger operator
Login: operator Name: System &
Directory: /operatorShell: /sbin/nologin
Never logged in.
No Mail.
No Plan.

>Fix:

Update the documentation in passwd(5) (or fix finger(1) behaviour).

dmesg:
OpenBSD 6.3-current (GENERIC.MP) #63: Thu Jun 14 15:08:23 CEST 2018
kk@box.local:/extra/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 17000153088 (16212MB)
avail mem = 16345731072 (15588MB)
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.7 @ 0xdae9d000 (71 entries)
bios0: vendor LENOVO version "G2ET33WW (1.13 )" date 07/24/2012
bios0: LENOVO 23252FG
acpi0 at bios0: rev 2
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP SLIC TCPA SSDT SSDT SSDT HPET APIC MCFG ECDT FPDT ASF! 
UEFI UEFI POAT SSDT SSDT DMAR UEFI
acpi0: wakeup devices LID_(S4) SLPB(S3) IGBE(S4) EXP3(S4) XHCI(S3) EHC1(S3) 
EHC2(S3) HDEF(S4)
acpitimer0 at acpi0: 3579545 Hz, 24 bits
acpihpet0 at acpi0: 14318179 Hz
acpimadt0 at acpi0 addr 0xfee0: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz, 2494.75 MHz
cpu0: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu0: 256KB 64b/line 8-way L2 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges
cpu0: apic clock running at 99MHz
cpu0: mwait min=64, max=64, C-substates=0.2.1.1.2, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz, 2494.34 MHz
cpu1: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu1: 256KB 64b/line 8-way L2 cache
cpu1: smt 1, core 0, package 0
cpu2 at mainbus0: apid 2 (application processor)
cpu2: Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz, 2494.34 MHz
cpu2: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu2: 256KB 64b/line 8-way L2 cache
cpu2: smt 0, core 1, package 0
cpu3 at mainbus0: apid 3 (application processor)
cpu3: Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz, 2494.34 MHz
cpu3: 
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,RDTSCP,LONG,LAHF,PERF,ITSC,FSGSBASE,SMEP,ERMS,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu3: 256KB 64b/line 8-way L2 cache
cpu3: smt 1, core 1, package 0
ioapic0 at mainbus0: apid 2 pa 0xfec0, version 20, 24 pins
acpimcfg0 at acpi0 addr 0xf800, bus 0-63
acpiec0 at acpi0
acpiprt0 at acpi0: bus 0 (PCI0)
acpiprt1 at acpi0: bus -1 (PEG_)
acpiprt2 at acpi0: bus 2 (EXP1)
acpiprt3 at acpi0: bus 3 (EXP2)
acpiprt4 at acpi0: bus 4 (EXP3)
acpicpu0 at acpi0: C2(350@80 mwait.1@0x20), C1(1000@1 mwait.1), PSS
acpicpu1 at acpi0: C2(350@80 mwait.1@0x20), C1(1000@1 mwait.1), PSS
acpicpu2 at acpi0: C2(350@80 mwait.1@0x20), C1(1000@1 mwait.1), PSS
acpicpu3 at acpi0: C2(350@80 mwait.1@0x20), C1(1000@1 mwait.1), PSS
acpipwrres0 at acpi0: PUBS, resource for XHCI, EHC1, EHC2
acpitz0 at acpi0: critical temperature is 103 degC
acpibtn0 at acpi0: LID_
acpibtn1 at acpi0: SLPB
acpicmos0 at acpi0
"LEN0020" at acpi0 not configured
"SMO1200" at acpi0 not configured
acpibat0 at acpi0: BAT0 model "45N1023" serial 23293 type LION oem "SANYO"
acpiac0 at acpi0: AC unit online
acpithinkpad0 at acpi0
"PNP0C14" at acpi0 not configured
"PNP0C14" at acpi0