Re: kernel panic: ip_output no HDR

2024-01-16 Thread K R 
On Tue, Jan 16, 2024 at 4:39 AM Vitaliy Makkoveev  wrote:
>
> On Mon, Jan 15, 2024 at 03:50:40PM -0300, K R wrote:
> > On Mon, Jan 15, 2024 at 2:07 PM Alexander Bluhm  
> > wrote:
> > >
> > > On Mon, Jan 15, 2024 at 01:42:55PM -0300, K R wrote:
> > > > >Synopsis:  kernel panic: ip_output no HDR
> > > > >Category:  kernel amd64
> > > > >Environment:
> > > > System  : OpenBSD 7.4
> > > > Details : OpenBSD 7.4-stable (GENERIC.MP) #0: Mon Dec 11
> > > > 19:17:55 UTC 2023
> > > >
> > > > root@server.mydomain:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> > > >
> > > > Architecture: OpenBSD.amd64
> > > > Machine : amd64
> > > > >Description:
> > > >
> > > > ...
> > > > pppoe0: received unexpected PADO
> > > > panic: ip_output no HDR
> > > > Starting stack trace...
> > > > panic() at panic+0x130
> > > > ip_output() at ip_output+0x126
> > > > udp_output() at 0x3be
> > > > sosend() at sosend+0x37f
> > > > pflow_output_process() at pflow_output_process+0x67
> > > > taskq_thread() at taskq_thread+0x100
> > > > end trace frame: 0x0, count: 251
> > > > End of stack frame.
> > > >
> > > > Trace lines attached below.
> > > >
> > > > >How-To-Repeat:
> > > >
> > > > The machine export pflows to localhost: those are read by nfcapd, part
> > > > of nfdump, from packages.  This was a very stable setup -- the kernel
> > > > panic started after upgrading to 7.4.
> > > >
> > > > This machine runs 7.4-stable.  Same panic was also observed on another
> > > > machine, running 7.4-release + all syspatches, also using pflow.
> > >
> > > There were some commits to if_pflow.c in current.  mvs@ has fixed
> > > a bunch of races.  Would it be possible for you to install a -current
> > > snapshot on the machine and test if the problem persists?
> >
> > Hey Alexander,
> >
> > Thank you for the quick reply.  This machine is in production so I may
> > not be able to install -current.  In the meantime, I'm trying to
> > recreate the kernel panic in a VM under vmd.  I'll keep you posted.
> >
> > Thanks!
> >
>
> Hi,
>
> The diff [1] should be applicable to 7.4-stable. Please note, it doesn't
> fix all pflow(4) problems, but "ip_output no HDR" should gone.

Thanks, the diff applied cleanly against 7.4-stable.  I rebooted the
machine with this new kernel and everything looks fine, so far.

Thanks again,
--Kor

>
> 1. https://marc.info/?l=openbsd-bugs=170203738520363=2
>

Re: Supported iwn device is not configured on ARM64

2024-01-16 Thread Stefan Sperling 
On Tue, Jan 16, 2024 at 02:38:58PM +0800, Kevin Lo wrote:
> The below diff fixes clang warning about possible unaligned access.
> With that fixed, iwm(4) works as expected on my Rock 3A.
> 
> iwm0 at pci1 dev 0 function 0 "Intel Dual Band Wireless-AC 9260" rev 0x29, 
> msix
> iwm0: hw rev 0x320, fw ver 46.ff18e32a.0, address fc:77:74:xx:xx:xx

Thank you! ok stsp@

> Index: sys/dev/pci/if_iwmreg.h
> ===
> RCS file: /cvs/src/sys/dev/pci/if_iwmreg.h,v
> retrieving revision 1.68
> diff -u -p -u -p -r1.68 if_iwmreg.h
> --- sys/dev/pci/if_iwmreg.h   19 Mar 2022 10:26:52 -  1.68
> +++ sys/dev/pci/if_iwmreg.h   16 Jan 2024 06:06:00 -
> @@ -3361,7 +3361,7 @@ struct iwm_rx_mpdu_desc_v1 {
>   uint32_t phy_data0;
>   uint32_t phy_data1;
>   };
> - };
> + } __packed;
>  } __packed;
>  
>  #define IWM_RX_REORDER_DATA_INVALID_BAID 0x7f
>