Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
Thanks for looking at this! On 2012-02-08 02:47, David Holmes wrote: It doesn't make sense to me to include SPEC in make/Makefile and make/Defs.make because Makefile includes Defs.make. You only need the -include in Defs.make (unless SPEC is going to define GAMMADIR or ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) I checked this again and you are right, we don't set anything that warrants including SPEC in make/Makefile. I will move it to defs only. So this seems really ugly to me. If these were all set as Make variables on a top-level make invocation then you wouldn't need to do any of these tests. If the SPEC file is always going to set these variables then why not either include SPEC or else do these definitions eg: ifeq ($(SPEC),) CC = ... CXX = .. ... endif # else SPEC already defined these this might need some refactoring to group the necessary settings together. This was how I initially did it, but I wasn't sure on the best solution. I also forgot about command line overriding normal assignments. With an explicit check for SPEC it's very obvious what we are trying to achieve. I will look into this and try to group things more neatly together for it. Hope to publish a new webrev later today. /Erik
Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
Thanks for taking a look. While I haven't tried building in the way describe (yet), these changes shouldn't affect it. The idea is to leave everything in the hotspot build just like it is now, but let configure override things when configure is used, which is only when building the full forest. /Erik On 2012-02-08 02:54, Paul Hohensee wrote: Thanks for the explanation. As long as I can still do builds from make/os_family, I'm happy. Paul On 2/7/12 7:42 PM, David Holmes wrote: On 8/02/2012 2:55 AM, Paul Hohensee wrote: Can you make this work when building from the make/os_family directories? E.g., you could add the $(SPEC) include to make/solaris/Makefile, etc. I'm not sure that makes sense. The SPEC file only exists for the new build and in the new build you run configure for each platform, so if you configured for solaris then that is the only build you can do there. You can't decide to do a linux build instead - you need to re-run configure. I'll take a look at this ASAP but am somewhat swamped right now. David Thanks, Paul On 2/7/12 11:30 AM, Erik Joelsson wrote: http://cr.openjdk.java.net/~erikj/7141244/webrev.00/ http://cr.openjdk.java.net/%7Eerikj/7141244/webrev.00/ 178 lines changed: 115 ins; 7 del; 56 mod; 4625 unchg 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable The build-infra project is starting to move into jdk8. For the hotspot build to stay compatible with the changes, key hotspot makefiles need to add an optional include statement: -include $(SPEC) In the new build system, the spec file is generated by configure and contains the configuration for the build. Only a handfull of files need to add this line. In addition to including the spec file, some variables need to be changed to only be set conditionally so that a value from the spec file takes precedence. These are: CC, CXX, CPP, AS, MCS, STRIP, NM, NAWK (and for windows RC and MT). The hotspot makefiles should check each variable if it's already set or if it has a gnumake default value. These changes have been verified to work for hotspot-rt. Jdk7u will be verified as well before pushing. /Erik
Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
- david.hol...@oracle.com skrev: This reminded me that one of the things on my wishlist for the new build was that I can still override something in SPEC by setting it on the command-line invocation of make. That should work, since a variable specified on the make command line, forcibly overrides any attempt to set it inside the makefiles. (Well, you can forcibly-forcibly override it again in the makefile, but we have no intention to do that.) We only need to make sure that the variables specified to the root makefile gets propagated to the sub-make command lines. Should be easy to fix. But it will not be part of this webrev. //Fredrik
Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
New webrev up with the changes I detailed below: http://cr.openjdk.java.net/~erikj/7141244/webrev.01/ 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg /Erik On 2012-02-08 09:14, Erik Joelsson wrote: Thanks for looking at this! On 2012-02-08 02:47, David Holmes wrote: It doesn't make sense to me to include SPEC in make/Makefile and make/Defs.make because Makefile includes Defs.make. You only need the -include in Defs.make (unless SPEC is going to define GAMMADIR or ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) I checked this again and you are right, we don't set anything that warrants including SPEC in make/Makefile. I will move it to defs only. So this seems really ugly to me. If these were all set as Make variables on a top-level make invocation then you wouldn't need to do any of these tests. If the SPEC file is always going to set these variables then why not either include SPEC or else do these definitions eg: ifeq ($(SPEC),) CC = ... CXX = .. ... endif # else SPEC already defined these this might need some refactoring to group the necessary settings together. This was how I initially did it, but I wasn't sure on the best solution. I also forgot about command line overriding normal assignments. With an explicit check for SPEC it's very obvious what we are trying to achieve. I will look into this and try to group things more neatly together for it. Hope to publish a new webrev later today. /Erik
Re: RFR 7142950: jdk7u cannot bootstrap Mac OS build [macosx]
On Feb 6, 2012, at 2:31 PM, Michael McMahon wrote: There are a few problems with the Mac build at the moment. 1. If SKIP_BOOT_CYCLE=false then the build fails, due to two problems:- 1) top level Makefile doesn't know about Mac OS image directory structure 2) it also fails due to problem 2. below 2. General bootstrapping problem. The build currently cannot use itself as the bootstrap JDK due to an assumption in the framework classes that os.arch is x86_64, whereas we currently set it to amd64. The change is to fix that code to expect amd64. There is a related question then about what the correct value for os.arch should be. I'd like to raise this in a separate discussion and hopefully fix these build problems independently of that. I was going to propose that we fix the image directory issues by building into the image directories the same way on all platforms and have the mac build copy the image directories into j2sdk-bundle. (7133768) I'm pretty sure that even with this change you can't build rt.jar because the jar tool gets moved out from underneath the running build when the bundle is constructed. I don't think your changes would interfere with my proposed fix for 7133768, though. And, the other changes for generating the folder name dynamically are very much welcome. -- Scott K. Scott Kovatch scott.kova...@oracle.com Santa Clara/Pleasanton, CA
RFR 7142950: jdk7u cannot bootstrap Mac OS build [macosx]
There are a few problems with the Mac build at the moment. 1. If SKIP_BOOT_CYCLE=false then the build fails, due to two problems:- 1) top level Makefile doesn't know about Mac OS image directory structure 2) it also fails due to problem 2. below 2. General bootstrapping problem. The build currently cannot use itself as the bootstrap JDK due to an assumption in the framework classes that os.arch is x86_64, whereas we currently set it to amd64. The change is to fix that code to expect amd64. There is a related question then about what the correct value for os.arch should be. I'd like to raise this in a separate discussion and hopefully fix these build problems independently of that. 3. jvm.cfg is currently being taken from the solaris src tree even though a macos version of the file is there. Fix that problem too. The macos source jvm.cfg is changed to be the same as the solaris/amd64 version (ie. the one that was being used, and which makes -client UNKNOWN) The following webrevs address these issues. Top level repo -- http://cr.openjdk.java.net/~michaelm/7142950/top/webrev.1/ JDK repo http://cr.openjdk.java.net/~michaelm/7142950/jdk/webrev.1/
Re: Review for 7141244: build-infra merge: Include $(SPEC) in makefiles and make variables overridable
On 9/02/2012 1:36 AM, Erik Joelsson wrote: New webrev up with the changes I detailed below: http://cr.openjdk.java.net/~erikj/7141244/webrev.01/ 177 lines changed: 89 ins; 29 del; 59 mod; 3970 unchg make/defs.make: + ifneq (,$(SPEC)) + include $(SPEC) + endif Having the blank first looks odd. I assume you aren't using -inlcude because you want to see errors if SPEC is set but not found. make/windows/makefiles/compile.make: The definitions of MT=mt.exe in each block for the different VS versions seems redundant. If we factor this out is there any reason not to group: CXX=cl.exe MT=mt.exe RC=rc.exe LD=link.exe together and use the same if (,$(SPEC)) approach? David - /Erik On 2012-02-08 09:14, Erik Joelsson wrote: Thanks for looking at this! On 2012-02-08 02:47, David Holmes wrote: It doesn't make sense to me to include SPEC in make/Makefile and make/Defs.make because Makefile includes Defs.make. You only need the -include in Defs.make (unless SPEC is going to define GAMMADIR or ALT_OUTPUTDIR - in which case include it in the Makefile not Defs.make) I checked this again and you are right, we don't set anything that warrants including SPEC in make/Makefile. I will move it to defs only. So this seems really ugly to me. If these were all set as Make variables on a top-level make invocation then you wouldn't need to do any of these tests. If the SPEC file is always going to set these variables then why not either include SPEC or else do these definitions eg: ifeq ($(SPEC),) CC = ... CXX = .. ... endif # else SPEC already defined these this might need some refactoring to group the necessary settings together. This was how I initially did it, but I wasn't sure on the best solution. I also forgot about command line overriding normal assignments. With an explicit check for SPEC it's very obvious what we are trying to achieve. I will look into this and try to group things more neatly together for it. Hope to publish a new webrev later today. /Erik
hg: jdk8/build/corba: Added tag jdk8-b24 for changeset b98f0e6dddf9
Changeset: e45d6b406d5f Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/e45d6b406d5f Added tag jdk8-b24 for changeset b98f0e6dddf9 ! .hgtags
hg: jdk8/build: 4 new changesets
Changeset: 5350cd6e0cc0 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/5350cd6e0cc0 Added tag jdk8-b24 for changeset 1a5f1d6b98d6 ! .hgtags Changeset: 0f653ee93477 Author:alanb Date: 2012-01-24 09:08 + URL: http://hg.openjdk.java.net/jdk8/build/rev/0f653ee93477 7132204: Default testset in JPRT should not run all tests Reviewed-by: ohair ! make/jprt.properties Changeset: bd3fcc98c5d2 Author:lana Date: 2012-01-28 20:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/bd3fcc98c5d2 Merge Changeset: 221a378e06a3 Author:lana Date: 2012-02-07 10:36 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/221a378e06a3 Merge
hg: jdk8/build/hotspot: 29 new changesets
Changeset: 905945c5913e Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/905945c5913e Added tag jdk8-b24 for changeset a80fd4f45d7a ! .hgtags Changeset: 9f1c2b7cdfb6 Author:amurillo Date: 2012-01-27 14:49 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/9f1c2b7cdfb6 7135385: new hotspot build - hs23-b13 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 34e2e90e7182 Author:rbackman Date: 2012-01-24 14:48 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/34e2e90e7182 7130476: Remove use of #ifdef TRACE_DEFINE_KLASS_TRACE_ID from klass.hpp Reviewed-by: kamg, phh, dsamersoff Contributed-by: Rickard Backman rickard.back...@oracle.com ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/trace/traceMacros.hpp Changeset: 26a08cbbf042 Author:stefank Date: 2012-01-27 13:46 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/26a08cbbf042 7022100: Method annotations are incorrectly set when redefining classes Summary: Changed to the correct annotation arrays Reviewed-by: kamg, dholmes, sla ! src/share/vm/oops/instanceKlass.hpp Changeset: f457154eee8b Author:brutisso Date: 2012-01-30 12:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f457154eee8b 7140882: Don't return booleans from methods returning pointers Summary: Changed return false to return NULL Reviewed-by: dholmes, rottenha Contributed-by: dbh...@redhat.com ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/opto/loopnode.cpp Changeset: d96c130c9399 Author:brutisso Date: 2012-01-30 05:08 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/d96c130c9399 Merge Changeset: b2cd0ee8f778 Author:acorn Date: 2012-01-30 23:27 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/b2cd0ee8f778 7114376: Make system dictionary hashtable bucket array size configurable Summary: 7u4 new experimental flag -XX:PredictedClassLoadedCount=# Reviewed-by: dholmes, phh, dcubed ! agent/src/share/classes/sun/jvm/hotspot/memory/LoaderConstraintTable.java ! agent/src/share/classes/sun/jvm/hotspot/memory/SystemDictionary.java ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/hashtable.hpp Changeset: 481a9443f721 Author:phh Date: 2012-02-01 15:01 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/481a9443f721 7123386: RFE: Preserve universal builds of HotSpot on Mac OS X Summary: Add support for packaging HotSpot JVM builds in universal binaries Reviewed-by: dholmes, kamg, dcubed, phh Contributed-by: james.mel...@oracle.com ! make/Makefile ! make/bsd/makefiles/defs.make + make/bsd/makefiles/universal.gmk ! make/defs.make Changeset: 527cf36f4a20 Author:fparain Date: 2012-02-03 14:04 -0500 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/527cf36f4a20 Merge ! src/share/vm/runtime/globals.hpp Changeset: 1a2723f7ad8e Author:never Date: 2012-01-29 16:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1a2723f7ad8e 7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale Reviewed-by: kvn, iveresov, dholmes ! src/share/vm/memory/gcLocker.cpp ! src/share/vm/memory/gcLocker.hpp ! src/share/vm/memory/gcLocker.inline.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp ! src/share/vm/runtime/thread.hpp Changeset: 5f17b16b3219 Author:iveresov Date: 2012-01-30 19:37 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5f17b16b3219 7141059: 7116795 broke pure c2 builds Summary: Fix pure c2 builds Reviewed-by: kvn, brutisso, never ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/x86/vm/frame_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 5ed8f599a788 Author:kvn Date: 2012-01-31 07:18 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/5ed8f599a788 7140924: SIGSEGV in compiled code for sun.awt.X11.XDecoratedPeer.updateMinSizeHints Summary: Use unknown_obj instead of empty_map for NULL or Constant Pool object constants in bytecode Escape Analyzer. Reviewed-by: iveresov, never ! src/share/vm/ci/bcEscapeAnalyzer.cpp Changeset: 2f5980b127e3 Author:twisti Date: 2012-01-31 09:53 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/2f5980b127e3 7132180: JSR 292: C1 JVM crash with ClassValue/MethodHandle Reviewed-by: never ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: f067b4e0e04b Author:roland Date: 2012-02-01 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/f067b4e0e04b 7090976: Eclipse/CDT causes a JVM crash while indexing C++ code Summary: too optimistic inlining
hg: jdk8/build/jaxws: Added tag jdk8-b24 for changeset e0d90803439b
Changeset: b376d901e006 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/b376d901e006 Added tag jdk8-b24 for changeset e0d90803439b ! .hgtags
hg: jdk8/build/jaxp: Added tag jdk8-b24 for changeset 7836655e2495
Changeset: bb694c151fc7 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/bb694c151fc7 Added tag jdk8-b24 for changeset 7836655e2495 ! .hgtags
hg: jdk8/build/jdk: 44 new changesets
Changeset: ad9f1c8970da Author:prr Date: 2012-01-19 12:41 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ad9f1c8970da 7131153: GetDC called way too many times - causes bad performance. Reviewed-by: igor, jgodinez ! src/windows/native/sun/font/fontpath.c Changeset: f7dda4bbf1f9 Author:lana Date: 2012-01-28 22:47 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f7dda4bbf1f9 Merge - test/java/io/File/BlockIsDirectory.java Changeset: 84b153cd9bd4 Author:denis Date: 2012-01-19 14:59 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/84b153cd9bd4 7121761: creation of java.awt.DataFlavour fails for turkish locale Reviewed-by: anthony ! src/share/classes/java/awt/datatransfer/MimeType.java Changeset: e32db6535c05 Author:alexsch Date: 2012-01-23 13:05 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/e32db6535c05 7112854: [macosx] closed/javax/swing/JPopupMenu/Test6827786.java unstable on MacOS Reviewed-by: rupashka + test/javax/swing/JPopupMenu/6827786/bug6827786.java Changeset: cc88a9c0474f Author:alexsch Date: 2012-01-23 13:53 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cc88a9c0474f 7116634: [macosx] closed/javax/swing/JTree/6263446/bug6263446Tree.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JTree/6263446/bug6263446.java Changeset: 19431d07bc19 Author:denis Date: 2012-01-23 17:26 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/19431d07bc19 7130140: using horizontal scroll button on mouse causes a message to be printed on stdout Reviewed-by: art ! src/share/classes/java/awt/event/MouseEvent.java Changeset: 5255fd5b0418 Author:denis Date: 2012-01-24 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5255fd5b0418 7078460: JDialog is shown as separate icon on the taskbar Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: b4589ff4457c Author:malenkov Date: 2012-01-24 19:40 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/b4589ff4457c 7121905: grammatically incorrect apostrophe in BeanInfo javadoc Reviewed-by: rupashka ! src/share/classes/java/beans/BeanInfo.java Changeset: 4f2a2bf0ce84 Author:rupashka Date: 2012-01-26 17:38 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/4f2a2bf0ce84 7010561: Tab text position with Synth based LaF is different to Java 5/6 Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/javax/swing/JTabbedPane/7010561/bug7010561.java Changeset: cc9ff174a1c3 Author:alexsch Date: 2012-01-27 16:32 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/cc9ff174a1c3 7122173: [macosx] Several Regression tests fail on MacOS Reviewed-by: rupashka + test/javax/swing/SwingUtilities/4917669/bug4917669.java + test/javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java + test/javax/swing/text/html/CSS/4530474/bug4530474.java + test/javax/swing/text/html/CSS/4530474/test.css + test/javax/swing/text/html/CSS/4530474/test.html Changeset: 96b5999af66b Author:alexsch Date: 2012-01-27 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/96b5999af66b 7109962: [macosx] closed/javax/swing/JList/6462008/bug6462008.java fails on MacOS Reviewed-by: rupashka + test/javax/swing/JList/6462008/bug6462008.java Changeset: 6a7109f52966 Author:alexsch Date: 2012-01-27 17:36 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/6a7109f52966 7105040: [macosx] closed/javax/swing/JPopupMenu/4966112/bug4966112.java deadlocks on MacOS Reviewed-by: rupashka + test/javax/swing/JPopupMenu/4966112/bug4966112.java Changeset: bc1c20ac8676 Author:chegar Date: 2012-01-27 13:48 + URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/bc1c20ac8676 7110002: Rename xawt/libmawt.so and headless/libmawt.so so they can be colocated with libawt Reviewed-by: art, prr, dholmes, alanb ! make/common/Release-embedded.gmk ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/jawt/Makefile ! make/sun/xawt/Makefile ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/sun/awt/awt_LoadLibrary.c Changeset: 5dab2d55bc5b Author:lana Date: 2012-01-28 22:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/5dab2d55bc5b Merge - test/java/io/File/BlockIsDirectory.java Changeset: 39b661c5867a Author:alexsch Date: 2012-01-30 12:52 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/39b661c5867a 7122149: [macosx] closed/javax/swing/UITest/UITest.java fails on MacOS Reviewed-by: rupashka ! src/share/classes/sun/awt/OSInfo.java + test/javax/swing/UITest/UITest.java Changeset: 7d6c7dd72e25 Author:malenkov Date: 2012-01-31 14:20 +0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/7d6c7dd72e25 7122138: IAE thrown because Introspector
hg: jdk8/build/langtools: 7 new changesets
Changeset: 5a784dab75f1 Author:katleman Date: 2012-02-02 09:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/5a784dab75f1 Added tag jdk8-b24 for changeset 6c9d21ca92c4 ! .hgtags Changeset: 51fb17abfc32 Author:mcimadamore Date: 2012-01-24 17:52 + URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/51fb17abfc32 7129801: Merge the two method applicability routines Summary: Resolve.java and Infer.java should reuse the same method applicability check routine Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java Changeset: ac36176b7de0 Author:jjh Date: 2012-01-24 15:51 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/ac36176b7de0 7126832: com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager cannot be cast Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/main/Main.java + test/tools/javah/T7126832/T7126832.java + test/tools/javah/T7126832/java.java Changeset: d16b464e742c Author:jjh Date: 2012-01-24 16:31 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/d16b464e742c 7129225: javac fails to run annotation processors when star import of package of gensrc Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/7129225/Anno.java + test/tools/javac/7129225/AnnoProcessor.java + test/tools/javac/7129225/NegTest.ref + test/tools/javac/7129225/TestImportStar.java + test/tools/javac/7129225/TestImportStar.ref Changeset: 332dfa0f91df Author:jjh Date: 2012-01-25 12:20 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/332dfa0f91df 7133314: The regression test for 7129225 fails when run with jtreg -samevm or jtreg -agentvm Reviewed-by: jjg ! test/tools/javac/7129225/AnnoProcessor.java ! test/tools/javac/7129225/NegTest.ref ! test/tools/javac/7129225/TestImportStar.java ! test/tools/javac/7129225/TestImportStar.ref Changeset: 7d412606d641 Author:lana Date: 2012-01-28 20:42 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/7d412606d641 Merge Changeset: 520c30f85bb5 Author:lana Date: 2012-02-07 10:39 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/520c30f85bb5 Merge
