Re: RFR(L) : 8199375 : [TESTBUG] Open source vm testbase monitoring tests
Vladimir, Tests are listed only in _quick test group b/c it doesn’t include all tests from the directory. We use this group in some of our test configurations, and :vmTestbase_nsk_monitoring in others. vmTestbase_nsk_monitoring is defined by the directory as other groups. Thanks, — Igor > On May 1, 2018, at 7:54 PM, Vladimir Kozlov > wrote: > > Igor, > > Why you need to list each test in TEST.groups and not just directory as we do > in other cases? > > Thanks, > Vladimir > >> On 5/1/18 7:10 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html >>> 41276 lines changed: 41274 ins; 1 del; 1 mod; >> Hi all, >> could you please review the patch which open sources monitoring tests from >> vm testbase? >> The tests were developed to test hotspot related JMX functionality. as w/ >> common VM testbase code, these tests are old, they have been run from >> hotspot testing for a long period of time. originally, these tests were run >> by a test harness different from jtreg and had different build and execution >> schemes, some parts couldn't be easily translated to jtreg, so tests might >> have actions or pieces of code which look weird. in a long term, we are >> planning to rework them. >> JBS: https://bugs.openjdk.java.net/browse/JDK-8199375 >> webrev: http://cr.openjdk.java.net/~iignatyev/8199375/webrev.00/index.html >> testing: vmTestbase_nsk_monitoring test group >> Thanks, >> -- Igor
Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated
On 26 April 2018 at 23:55, Kim Barrett wrote: snip... > > I disagree, and still think the perfMemory_linux.cpp change should be > removed. > > (1) The change to perfMemory_linux.cpp is entirely unnecessary to > address the problem this bug is about. > > (2) It violates the (implied) protocol for os::readdir. If > Linux-specific code wants to invoke Linux-specific behavior, it should > do so by calling a Linux-specific API, not abuse an intended to be > portable API. > > (3) It minorly interferes with some desirable future work. If there > were some significant benefit to doing so, I wouldn't give this much > weight, but I don't see a significant benefit. > > (4) The only benefit is saving some rare short-term memory > allocations. I don't think that's worth the above costs. > > Note that the Windows version of os::readdir also ignores the second > argument, but all callers provide it anyway. > > I've opened a new CR for general os::readdir cleanup. > https://bugs.openjdk.java.net/browse/JDK-8202353 > Ok, I see your points and don't feel particularly strongly either way. The original version of this patch I wrote didn't include those changes either. -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Web Site: http://fuseyism.com Twitter: https://twitter.com/gnu_andrew_java PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
Re: RFR(L) : 8199375 : [TESTBUG] Open source vm testbase monitoring tests
Igor, Why you need to list each test in TEST.groups and not just directory as we do in other cases? Thanks, Vladimir On 5/1/18 7:10 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html 41276 lines changed: 41274 ins; 1 del; 1 mod; Hi all, could you please review the patch which open sources monitoring tests from vm testbase? The tests were developed to test hotspot related JMX functionality. as w/ common VM testbase code, these tests are old, they have been run from hotspot testing for a long period of time. originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. in a long term, we are planning to rework them. JBS: https://bugs.openjdk.java.net/browse/JDK-8199375 webrev: http://cr.openjdk.java.net/~iignatyev/8199375/webrev.00/index.html testing: vmTestbase_nsk_monitoring test group Thanks, -- Igor
RFR(L) : 8199375 : [TESTBUG] Open source vm testbase monitoring tests
http://cr.openjdk.java.net/~iignatyev//8199375/webrev.00/index.html > 41276 lines changed: 41274 ins; 1 del; 1 mod; Hi all, could you please review the patch which open sources monitoring tests from vm testbase? The tests were developed to test hotspot related JMX functionality. as w/ common VM testbase code, these tests are old, they have been run from hotspot testing for a long period of time. originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. in a long term, we are planning to rework them. JBS: https://bugs.openjdk.java.net/browse/JDK-8199375 webrev: http://cr.openjdk.java.net/~iignatyev/8199375/webrev.00/index.html testing: vmTestbase_nsk_monitoring test group Thanks, -- Igor
Re: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6
> On Apr 30, 2018, at 8:42 PM, Kim Barrett wrote: > And it looks like there is further cleanup needed in these areas. I’ve created these followups: https://bugs.openjdk.java.net/browse/JDK-8202508 https://bugs.openjdk.java.net/browse/JDK-8202509
Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated
> On Apr 27, 2018, at 4:26 PM, Michal Vala wrote:
>>> For now, proposed patch looks like this:
>>>
>>> --- old/src/hotspot/os/linux/os_linux.inline.hpp2018-04-20
>>> 09:16:34.498343185 +0200
>>> +++ new/src/hotspot/os/linux/os_linux.inline.hpp2018-04-20
>>> 09:16:34.214342670 +0200
>>> @@ -98,26 +98,8 @@
>>>
>>> inline struct dirent* os::readdir(DIR* dirp, dirent *dbuf)
>>> {
>>> -// readdir_r has been deprecated since glibc 2.24.
>>> -// See https://sourceware.org/bugzilla/show_bug.cgi?id=19056 for more
>>> details.
>>> -#pragma GCC diagnostic push
>>> -#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>>> -
>>> - dirent* p;
>>> - int status;
>>> assert(dirp != NULL, "just checking");
>>> -
>>> - // NOTE: Linux readdir_r (on RH 6.2 and 7.2 at least) is NOT like the
>>> POSIX
>>> - // version. Here is the doc for this function:
>>> - // http://www.gnu.org/manual/glibc-2.2.3/html_node/libc_262.html
>>> -
>>> - if((status = ::readdir_r(dirp, dbuf, &p)) != 0) {
>>> -errno = status;
>>> -return NULL;
>>> - } else
>>> -return p;
>>> -
>>> -#pragma GCC diagnostic pop
>>> + return ::readdir(dirp);
>>> }
>>>
>>> inline int os::closedir(DIR *dirp) {
>> This looks good.
>
> Thanks!
> Someone to sponsor this please?
Do you have a sponsor yet? If not, I’ll do it.
