Re: [RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

[Martin Buchholz]

It would be awesome to use the sanitizers to find native code bugs in
openjdk, but it seems like a serious project.  Here at Google we are doing
our small part by improving support for clang on Linux.

On Wed, Sep 5, 2018 at 6:17 PM, Leslie Zhai  wrote:

> It might be UBSan false positive :) What about ASan?
> https://bugs.openjdk.java.net/browse/JDK-8189800
>
>
> 在 2018年09月06日 09:12, Martin Buchholz 写道:
>
>> it's difficult to use llvm tools like sanitizers on openjdk sources,
>> because of the "cheating" - relying on undefined behavior, and the JIT.
>>
>> On Wed, Sep 5, 2018 at 6:09 PM, Leslie Zhai > > wrote:
>>
>> Hi Martin,
>>
>> Thanks for your response!
>>
>> I haven't tested compiling OpenJDK 12-dev with LLVM toolchain,
>> perhaps the issue had been fixed already, because clang treat
>> invalid argument '-std=gnu++98' not allowed with 'C' as error.  It
>> is better only apply EXTRA_CFLAGS to C without EXTRA_CXXFLAGS.
>>
>> Furthermore, I just have interest, did you use clang analyzer,
>> sanitizer and libfuzzer towards hotspot and jdk native library?
>> Thanks!
>>
>>
>> 在 2018年09月06日 02:10, Martin Buchholz 写道:
>>
>> We seem to have some confusion about flags for C vs. flags for
>> C++.  Most flags for most toolchains apply to both C and C++,
>> so it's understandable that we want to unify them.  But some
>> flags, notably -std, are language-specific.  We have both
>> EXTRA_CFLAGS and EXTRA_CXXFLAGS, so we should expect
>> EXTRA_CFLAGS to only apply to C.
>>
>>
>> -- Regards,
>> Leslie Zhai
>>
>>
>>
>>
> --
> Regards,
> Leslie Zhai
>
>
>

Re: RFR: 8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

[Andrew Haley]

On 09/06/2018 03:32 PM, Severin Gehwolf wrote:
> Right. I should note that ppc64, s390x and aarch64 ports don't have
> this optimization turned off as those overrides are in a x86 specific
> block. It appears it hasn't caused issues for these ports so far.

That's just dumb luck. We really should turn off the merging of FP
operations on all platforms.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. 
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671