RFR(S) [13] : 8226910 : make it possible to use jtreg's -match via run-test framework
http://cr.openjdk.java.net/~iignatyev//8226910/webrev.00/index.html > 25 lines changed: 18 ins; 3 del; 4 mod; Hi all, could you please review this small patch which adds JTREG_RUN_PROBLEM_LISTS options to run-test framework? when JTREG_RUN_PROBLEM_LISTS is set to true, jtreg will use problem lists as values of -match: instead of -exclude, which effectively means it will run only problem listed tests. doc/building.html got changed when I ran update-build-docs, I can exclude it from the patch, but it seems it will keep changing every time we run update-build-docs, so I decided to at least bring it up. JBS: https://bugs.openjdk.java.net/browse/JDK-8226910 webrev: http://cr.openjdk.java.net/~iignatyev//8226910/webrev.00/index.html Thanks, -- Igor
Re: [8u] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u
On 22/05/2019 17:34, Severin Gehwolf wrote: > Hi, > > Could I please get reviews for this minimal implementation of a tier1- > like test set for JDK 8u? The implementation is rather barebones as I > don't think it's worth rewriting the build system just for a command > that runs a certain set of tests across a select set of repositories. > I've re-used existing work in Makefiles as much as possible. After this > patch one can do: > > $ make test TEST="tier1" > > Inspiration came from JDK 11u's tier1. As for prior art to this, I've > only found "make test" to be working for JDK 8u from the top level. > Yet, it doesn't run any hotspot tests, exits with a zero code on test > failures and doesn't present a summary at the end. Overall not a nice > developer experience. > > This patch makes it easier for a developers tests. It presents a > summary at the end, returns non-zero on test failures so this can get > used in CI and runs hotspot tests. > > As a follow-on we can work on fixing/excluding tests so that we always > have a passing set of tests for developers to run before a checkin. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8222737 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/ > (includes changes to top/hotspot/jdk/langtools repos) > > Example excerpt from a run: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/example_output.txt > > Thoughts? > > Thanks, > Severin > Is there a reason for creating new tier definitions here rather than backporting the existing ones? https://bugs.openjdk.java.net/browse/JDK-8075543 The subtasks also cover nashorn & jaxp which are missed here. jaxp would need JDK-8065673, JDK-8051540 and friends to convert its tests to jtreg. -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
Re: [8u] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u
On 6/27/19 1:50 PM, Severin Gehwolf wrote: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/langtools/webrev/ > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/hotspot/webrev/ Looks fine to me. -- Thanks, -Aleksey
Re: [8u] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u
On Thu, 2019-06-27 at 13:27 +0200, Aleksey Shipilev wrote: > On 6/27/19 1:20 PM, Severin Gehwolf wrote: > > On Thu, 2019-06-27 at 11:58 +0200, Aleksey Shipilev wrote: > > > On 5/22/19 6:34 PM, Severin Gehwolf wrote: > > > hotspot: > > > > > > *) Test exclusion question. Do we really want to exclude these tests from > > > tier1? I would rather see > > > them included and make them fail in regular runs. This would put pressure > > > on fixing them for 8u... > > > > > > 150 # Right now tier1 runs all hotspot tests except RTM tests, > > > 151 # and one serviceability test which seems flakey. > > > 152 hotspot_tier1 = \ > > > 153 :jdk \ > > > 154 -compiler/rtm \ > > > 155 -serviceability/sa/jmap-hashcode/Test8028623.java > > > > I'm not sure about it. We could exclude nothing and go from there. > > However, the more tests we have failing from the get-go the less useful > > it is to enforce tier1 tests to always pass for JDK 8u (bad > > signal/noise ratio). I'd be OK for Test8028623.java, but the > > compiler/rtm tests, I'm not so sure... Thoughts? > > From my perspective, new test profile would inevitably show some (new) > failures. > > We would need to work to fix those failures before we can rely on low SNR in > tier1. Ignoring tests > may skip over the tests that need attention during that transitional period. > We don't ignore the > tests that are failing right now in fastdebug, right? Same thing here. > > In other words, I would rather see tier1 suite to land, and then work on > fixing/ignoring tests once > we understand how/if they are fixable. OK. Updated langtools/hotspot webrevs with no exclusions. jdk had no exclusions to begin with: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/langtools/webrev/ http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/hotspot/webrev/ Thoughts? Thanks, Severin
Re: [8u] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u
On 6/27/19 1:20 PM, Severin Gehwolf wrote: > On Thu, 2019-06-27 at 11:58 +0200, Aleksey Shipilev wrote: >> On 5/22/19 6:34 PM, Severin Gehwolf wrote: >> hotspot: >> >> *) Test exclusion question. Do we really want to exclude these tests from >> tier1? I would rather see >> them included and make them fail in regular runs. This would put pressure on >> fixing them for 8u... >> >> 150 # Right now tier1 runs all hotspot tests except RTM tests, >> 151 # and one serviceability test which seems flakey. >> 152 hotspot_tier1 = \ >> 153 :jdk \ >> 154 -compiler/rtm \ >> 155 -serviceability/sa/jmap-hashcode/Test8028623.java > > I'm not sure about it. We could exclude nothing and go from there. > However, the more tests we have failing from the get-go the less useful > it is to enforce tier1 tests to always pass for JDK 8u (bad > signal/noise ratio). I'd be OK for Test8028623.java, but the > compiler/rtm tests, I'm not so sure... Thoughts? From my perspective, new test profile would inevitably show some (new) failures. We would need to work to fix those failures before we can rely on low SNR in tier1. Ignoring tests may skip over the tests that need attention during that transitional period. We don't ignore the tests that are failing right now in fastdebug, right? Same thing here. In other words, I would rather see tier1 suite to land, and then work on fixing/ignoring tests once we understand how/if they are fixable. -- Thanks, -Aleksey
Re: [8u] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u
On Thu, 2019-06-27 at 11:58 +0200, Aleksey Shipilev wrote: > On 5/22/19 6:34 PM, Severin Gehwolf wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8222737 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/ > > (includes changes to top/hotspot/jdk/langtools repos) > > Excellent work! I eyeballed makefile changes and they seem fine (not an > expert, though). Thanks for the review, Aleksey! > hotspot: > > *) Test exclusion question. Do we really want to exclude these tests from > tier1? I would rather see > them included and make them fail in regular runs. This would put pressure on > fixing them for 8u... > > 150 # Right now tier1 runs all hotspot tests except RTM tests, > 151 # and one serviceability test which seems flakey. > 152 hotspot_tier1 = \ > 153 :jdk \ > 154 -compiler/rtm \ > 155 -serviceability/sa/jmap-hashcode/Test8028623.java I'm not sure about it. We could exclude nothing and go from there. However, the more tests we have failing from the get-go the less useful it is to enforce tier1 tests to always pass for JDK 8u (bad signal/noise ratio). I'd be OK for Test8028623.java, but the compiler/rtm tests, I'm not so sure... Thoughts? > Ran it on my current jdk8u-dev: > > $ CONF=linux-x86_64-normal-server-fastdebug make images test TEST=tier1 > > Summary: langtools_tier1 > FAILED: tools/javac/lambda/LambdaParserTest.java > TEST STATS: name=langtools_tier1 run=3113 pass=3112 fail=1 > > Summary: hotspot_tier1 > FAILED: compiler/ciReplay/TestSA.sh > FAILED: compiler/intrinsics/bmi/verifycode/TZcntTestL.java > FAILED: gc/arguments/TestAggressiveHeap.java > FAILED: runtime/RedefineObject/TestRedefineObject.java > FAILED: runtime/StackGap/testme.sh > TEST STATS: name=hotspot_tier1 run=729 pass=724 fail=5 > > Summary: jdk_tier1 > TEST STATS: name=jdk_tier1 run=1379 pass=1379 fail=0 This seems about right for fastdebug builds. > $ echo $? > 2 > > So, summary is there, exit code is right, and some tests are failing (which > is good for testing this > patch!). Any suggestions on how to proceed with this? Do you want me to do a v3 with no hotspot tests excluded? It would be nice if I could get this patch off of my queue ;-) Thanks, Severin
Re: [8u] RFR: 8222737: [TESTBUG] Allow for tier 1 like testing in OpenJDK 8u
On 5/22/19 6:34 PM, Severin Gehwolf wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8222737 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/ > (includes changes to top/hotspot/jdk/langtools repos) Excellent work! I eyeballed makefile changes and they seem fine (not an expert, though). hotspot: *) Test exclusion question. Do we really want to exclude these tests from tier1? I would rather see them included and make them fail in regular runs. This would put pressure on fixing them for 8u... 150 # Right now tier1 runs all hotspot tests except RTM tests, 151 # and one serviceability test which seems flakey. 152 hotspot_tier1 = \ 153 :jdk \ 154 -compiler/rtm \ 155 -serviceability/sa/jmap-hashcode/Test8028623.java Ran it on my current jdk8u-dev: $ CONF=linux-x86_64-normal-server-fastdebug make images test TEST=tier1 Summary: langtools_tier1 FAILED: tools/javac/lambda/LambdaParserTest.java TEST STATS: name=langtools_tier1 run=3113 pass=3112 fail=1 Summary: hotspot_tier1 FAILED: compiler/ciReplay/TestSA.sh FAILED: compiler/intrinsics/bmi/verifycode/TZcntTestL.java FAILED: gc/arguments/TestAggressiveHeap.java FAILED: runtime/RedefineObject/TestRedefineObject.java FAILED: runtime/StackGap/testme.sh TEST STATS: name=hotspot_tier1 run=729 pass=724 fail=5 Summary: jdk_tier1 TEST STATS: name=jdk_tier1 run=1379 pass=1379 fail=0 $ echo $? 2 So, summary is there, exit code is right, and some tests are failing (which is good for testing this patch!). -- Thanks, -Aleksey
Re: [8u] RFR: 8226870: OpenJDK 8u JRE contains clhsdb and hsdb launchers
On Thu, 2019-06-27 at 11:10 +0200, Aleksey Shipilev wrote: > On 6/27/19 11:06 AM, Severin Gehwolf wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8226870 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8226870/01/webrev/ > > Looks good to me. Thanks for the review, Aleksey! Cheers, Severin
Re: [8u] RFR: 8226870: OpenJDK 8u JRE contains clhsdb and hsdb launchers
On 6/27/19 11:06 AM, Severin Gehwolf wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8226870 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8226870/01/webrev/ Looks good to me. -- Thanks, -Aleksey
[8u] RFR: 8226870: OpenJDK 8u JRE contains clhsdb and hsdb launchers
Hi, Could I get a review for this simple 8u-only build fix? After the 8u backport of JDK-8059038, the JRE images have the serviceability agent launchers, but the SA jar, sa-jdi.jar, is only in the JDK. They are non-functional in the j2re-image after a build currently. This patch filters clhsdb and hsdb via NOT_JRE_BIN_FILES. Bug: https://bugs.openjdk.java.net/browse/JDK-8226870 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8226870/01/webrev/ Before: $ ls j2sdk-image/bin/ appletviewer hsdb jarsigner javadoc java-rmi.cgi jdbjinfo jps jstack keytool pack200 rmid serialver unpack200 xjc clhsdbidlj java javahjcmd jdeps jjsjrunscript jstat native2ascii policytool rmiregistry servertool wsgen extcheck jar javac javapjconsole jhat jmap jsadebugd jstatd orbd rmicschemagentnameserv wsimport $ ls j2re-image/bin/ clhsdb hsdb java jjs keytool orbd pack200 policytool rmid rmiregistry servertool tnameserv unpack200 After: $ ls j2sdk-image/bin/ appletviewer hsdb jarsigner javadoc java-rmi.cgi jdbjinfo jps jstack keytool pack200 rmid serialver unpack200 xjc clhsdbidlj java javahjcmd jdeps jjsjrunscript jstat native2ascii policytool rmiregistry servertool wsgen extcheck jar javac javapjconsole jhat jmap jsadebugd jstatd orbd rmicschemagentnameserv wsimport $ ls j2re-image/bin/ java jjs keytool orbd pack200 policytool rmid rmiregistry servertool tnameserv unpack200 Sorry about this. Thanks, Severin
Re: CFV: New Build Group Member: Matthias Baesken
Vote: yes /Magnus On 2019-06-26 10:29, Volker Simonis wrote: I hereby nominate Matthias Baesken (mbaesken) to Membership in the Build Group. Matthias is a long standing member of the JVM team at SAP. He's main areas of expertise are the build system, compilers/porting and security updates. He's a JDK Reviewer who has contributed more than 90 changes within the last two years [1], many of which were build system related. Votes are due by 10 July 2019, 12:00 CET. Only current Members of the Build Group [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list For Lazy Consensus voting instructions, see [3]. Volker Simonis [1] http://hg.openjdk.java.net/jdk/jdk/search/?rev=((author(%22mbaesken%22)%20and%20not%20desc(%22Contributed-by%22))%20or%20desc(%22Contributed-by%3A%20matthias.baesken%40sap.com%22))%20and%20not%20merge()=100 [2] http://openjdk.java.net/census#build [3] http://openjdk.java.net/groups/#member-vote
