Re: RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system
I recall years ago running into troubles with regex character ranges, e.g. https://unix.stackexchange.com/questions/15980/does-should-lc-collate-affect-character-ranges but my build script wrapper has been setting LC_ALL=C for a long time, and I set LC_COLLATE=C in my normal use shell environment (do regular humans care deeply about getting localized collation order?) On Wed, Oct 2, 2019 at 2:09 AM Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > From the bug report: > We should prefix LC_ALL=C for most, maybe all, tools we use when building. > > This probably means we should run "export LC_ALL=C" early in the > configure script as well. > --- > > The fix itself is trivial. While I know we've had several issues > regarding localization, I could not find any specific instances now that > I was looking for them. I searched JBS for a while but could not dig up > anything that was reproducible. So, unfortunately, I have been unable to > verify that this solves any actual problems. That being said, I believe > this is a prudent fix that should have been in place long time ago. But > if anyone can give me a concrete example that breaks so that I can > verify that this helps, please let me know. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8065704 > WebRev: http://cr.openjdk.java.net/~ihse/JDK-8065704-LC_ALL/webrev.01 > > /Magnus >
Re: RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system
Hello Magnus, The change looks good, but should perhaps also include removal of the few scattered specific instances of LANG=C and LC_ALL=C in the makefiles: make/common/JavaCompilation.gmk: export LC_ALL=C ; ( $(CAT) $$< && $(ECHO) "" ) \ make/autoconf/basics.m4: DATE_WHEN_CONFIGURED=`LANG=C date` Also compare.sh has a bunch which could be replaced with one export at the top. I would expect a full round of builds-infra to be run for this, as well as explicit compare builds as subtle things could be changing. /Erik On 2019-10-02 02:06, Magnus Ihse Bursie wrote: From the bug report: We should prefix LC_ALL=C for most, maybe all, tools we use when building. This probably means we should run "export LC_ALL=C" early in the configure script as well. --- The fix itself is trivial. While I know we've had several issues regarding localization, I could not find any specific instances now that I was looking for them. I searched JBS for a while but could not dig up anything that was reproducible. So, unfortunately, I have been unable to verify that this solves any actual problems. That being said, I believe this is a prudent fix that should have been in place long time ago. But if anyone can give me a concrete example that breaks so that I can verify that this helps, please let me know. Bug: https://bugs.openjdk.java.net/browse/JDK-8065704 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8065704-LC_ALL/webrev.01 /Magnus
Re: RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system
Hi Magnus, Looks good to me. Although I cannot provide any reproducible problematic instance, there have been instances where native tools, such as `date` command had produced localized date, and the build failed to parse it in US format. Anyways, it is a good preventive measure to me. Naoto On 10/2/19 2:06 AM, Magnus Ihse Bursie wrote: From the bug report: We should prefix LC_ALL=C for most, maybe all, tools we use when building. This probably means we should run "export LC_ALL=C" early in the configure script as well. --- The fix itself is trivial. While I know we've had several issues regarding localization, I could not find any specific instances now that I was looking for them. I searched JBS for a while but could not dig up anything that was reproducible. So, unfortunately, I have been unable to verify that this solves any actual problems. That being said, I believe this is a prudent fix that should have been in place long time ago. But if anyone can give me a concrete example that breaks so that I can verify that this helps, please let me know. Bug: https://bugs.openjdk.java.net/browse/JDK-8065704 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8065704-LC_ALL/webrev.01 /Magnus
RFR: JDK-8065704 Set LC_ALL=C for all relevant commands in the build system
From the bug report: We should prefix LC_ALL=C for most, maybe all, tools we use when building. This probably means we should run "export LC_ALL=C" early in the configure script as well. --- The fix itself is trivial. While I know we've had several issues regarding localization, I could not find any specific instances now that I was looking for them. I searched JBS for a while but could not dig up anything that was reproducible. So, unfortunately, I have been unable to verify that this solves any actual problems. That being said, I believe this is a prudent fix that should have been in place long time ago. But if anyone can give me a concrete example that breaks so that I can verify that this helps, please let me know. Bug: https://bugs.openjdk.java.net/browse/JDK-8065704 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8065704-LC_ALL/webrev.01 /Magnus
Re: RFR: JDK-8231505: Bump required boot jdk version to 13
On 2019-10-01 23:37, Erik Joelsson wrote: With the release of JDK 13 it is now time to update the required boot jdk version for JDK 14 (to 13). This patch changes the configure requirements as well as bumps the version used for Jib builds at Oracle. Bug: https://bugs.openjdk.java.net/browse/JDK-8231505 Webrev: http://cr.openjdk.java.net/~erikj/8231505/webrev.01/ Looks good to me. /Magnus /Erik
