Re: RFR: 8263914: CDS fails to find the default shared archive on x86_32 [v2]

2021-03-22 Thread Jie Fu 
On Mon, 22 Mar 2021 04:00:46 GMT, David Holmes  wrote:

>> Jie Fu has updated the pull request incrementally with one additional commit 
>> since the last revision:
>> 
>>   Fix the logic to look for the archive
>
> That looks like the right place to fix this - thanks.
> 
> Let's see what @iklam has to say. :)
> 
> David

Thanks @dholmes-ora and @iklam .

-

PR: https://git.openjdk.java.net/jdk/pull/3109

Integrated: 8263914: CDS fails to find the default shared archive on x86_32

2021-03-22 Thread Jie Fu 
On Mon, 22 Mar 2021 01:30:43 GMT, Jie Fu  wrote:

> Hi all,
> 
> The VM fails to get initialized when running with `java -Xshare:on -version` 
> on x86_32.
> The reason is that the default shared archive (classes_nocoops.jsa) doesn't 
> exist.
> So the build system should generate classes_nocoops.jsa instead of 
> classes.jsa on x86_32.
> 
> Thanks.
> Best regards,
> Jie

This pull request has now been integrated.

Changeset: b23228d1
Author:Jie Fu 
URL:   https://git.openjdk.java.net/jdk/commit/b23228d1
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod

8263914: CDS fails to find the default shared archive on x86_32

Reviewed-by: dholmes, iklam

-

PR: https://git.openjdk.java.net/jdk/pull/3109

Re: RFR: 8263914: CDS fails to find the default shared archive on x86_32 [v2]

2021-03-22 Thread Ioi Lam 
On Mon, 22 Mar 2021 03:37:05 GMT, Jie Fu  wrote:

>> Hi all,
>> 
>> The VM fails to get initialized when running with `java -Xshare:on -version` 
>> on x86_32.
>> The reason is that the default shared archive (classes_nocoops.jsa) doesn't 
>> exist.
>> So the build system should generate classes_nocoops.jsa instead of 
>> classes.jsa on x86_32.
>> 
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   Fix the logic to look for the archive

LGTM

-

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3109

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v29]

2021-03-22 Thread Anton Kozlov 
> Please review the implementation of JEP 391: macOS/AArch64 Port.
> 
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and 
> windows/aarch64. 
> 
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks 
> JDK-8253817, JDK-8253818)
> * src/hotspot/os_cpu/bsd_aarch64: copy of os_cpu/linux_aarch64 with necessary 
> adjustments (JDK-8253819)
> * src/hotspot/share, test/hotspot/gtest: support of write-xor-execute (W^X), 
> required on macOS/AArch64 platform. It's implemented with 
> pthread_jit_write_protect_np provided by Apple. The W^X mode is local to a 
> thread, so W^X mode change relates to the java thread state change (for java 
> threads). In most cases, JVM executes in write-only mode, except when calling 
> a generated stub like SafeFetch, which requires a temporary switch to 
> execute-only mode. The same execute-only mode is enabled when a java thread 
> executes in java or native states. This approach of managing W^X mode turned 
> out to be simple and efficient enough.
> * src/jdk.hotspot.agent: serviceability agent implementation (JDK-8254941)

Anton Kozlov has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now contains 115 commits:

 - Merge branch 'master' into jdk-macos
 - JDK-8262491: bsd_aarch64 part
 - JDK-8263002: bsd_aarch64 part
 - Merge remote-tracking branch 'upstream/jdk/master' into jdk-macos
 - Wider #ifdef block
 - Fix most of issues in java/foreign/ tests
   
   Failures related to va_args are tracked in JDK-8263512.
 - Add Azul copyright
 - Update Oracle copyright years
 - Use Thread::current_or_null_safe in SafeFetch
 - 8262903: [macos_aarch64] Thread::current() called on detached thread
 - ... and 105 more: 
https://git.openjdk.java.net/jdk/compare/a9d2267f...5add9269

-

Changes: https://git.openjdk.java.net/jdk/pull/2200/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2200=28
  Stats: 2947 lines in 75 files changed: 2838 ins; 27 del; 82 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2200.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2200/head:pull/2200

PR: https://git.openjdk.java.net/jdk/pull/2200