Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option
On 27/09/2019 16:48, Severin Gehwolf wrote: > Hi, > > Could I please get a review of this 8u build change backport which adds > --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain > assembler only flags for some builds. For example "-Wa,--generate- > missing-build-notes=yes", to assembly files only. As the build system > is different in 8u over 11u I've re-done the patch. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8227397 > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8227397/jdk8/01/ > > Testing: Built with --with-extra-asflags=-Wa,--generate-missing-build- > notes=yes on Linux x86_64, confirmed linux_x86_64.s gets assembled with > the flag and only that file. > > I've omitted the windows portion of passing as flags to the hotspot > build as I've no idea how. Contributions welcome if that should get > included. > > Thoughts? > > Thanks, > Severin > Looks ok to me. As to the Windows side, it seems there are no ASFLAGS rules at all nor any assembly files: $ grep -r 'ASFLAGS' hotspot/make/ hotspot/make/aix/makefiles/xlc.make:ASFLAGS+= $(ARCHFLAG) hotspot/make/aix/makefiles/rules.make:AS.S= $(AS) $(ASFLAGS) hotspot/make/solaris/makefiles/sparcWorks.make:ASFLAGS += $(AS_ARCHFLAG) hotspot/make/solaris/makefiles/sparcv9.make:ASFLAGS += $(AS_ARCHFLAG) hotspot/make/solaris/makefiles/sparc.make:ASFLAGS += $(AS_ARCHFLAG) hotspot/make/solaris/makefiles/gcc.make:ASFLAGS+= $(ARCHFLAG) hotspot/make/solaris/makefiles/gcc.make:ASFLAGS += -march=k8 -march=amd64 hotspot/make/solaris/makefiles/rules.make:AS.S= $(AS) $(ASFLAGS) hotspot/make/bsd/makefiles/sparcWorks.make:ASFLAGS+= $(ARCHFLAG) hotspot/make/bsd/makefiles/gcc.make:ASFLAGS+= $(ARCHFLAG) hotspot/make/bsd/makefiles/gcc.make:ASFLAGS += -x assembler-with-cpp hotspot/make/bsd/makefiles/rules.make:AS.S= $(AS) $(ASFLAGS) hotspot/make/linux/makefiles/sparcWorks.make:ASFLAGS+= $(ARCHFLAG) hotspot/make/linux/makefiles/gcc.make:ASFLAGS+= $(ARCHFLAG) hotspot/make/linux/makefiles/gcc.make: ASFLAGS+= $(ASFLAGS_DEBUG_SYMBOLS) hotspot/make/linux/makefiles/rules.make:AS.S= $(AS) $(ASFLAGS) $ find hotspot/src/ -name '*.s' hotspot/src/os_cpu/bsd_x86/vm/bsd_x86_64.s hotspot/src/os_cpu/bsd_x86/vm/bsd_x86_32.s hotspot/src/os_cpu/solaris_sparc/vm/solaris_sparc.s hotspot/src/os_cpu/solaris_x86/vm/solaris_x86_32.s hotspot/src/os_cpu/solaris_x86/vm/solaris_x86_64.s hotspot/src/os_cpu/linux_x86/vm/linux_x86_64.s hotspot/src/os_cpu/linux_x86/vm/linux_x86_32.s hotspot/src/os_cpu/linux_sparc/vm/linux_sparc.s so it looks like assembly support would need to be there first before making this change on top. Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option
LGTM On Fri, Jan 17, 2020 at 2:59 AM Severin Gehwolf wrote: > Hi, > > Could I get a second review from an JDK 8u Reviewer, please? > > Thanks, > Severin > > On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote: > > On 2019-09-27 17:48, Severin Gehwolf wrote: > > > Hi, > > > > > > Could I please get a review of this 8u build change backport which > > > adds > > > --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass > > > certain > > > assembler only flags for some builds. For example "-Wa,--generate- > > > missing-build-notes=yes", to assembly files only. As the build > > > system > > > is different in 8u over 11u I've re-done the patch. > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8227397 > > > webrev: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8227397/jdk8/01/ > > Looks good to me. > > > > /Magnus > > > Testing: Built with --with-extra-asflags=-Wa,--generate-missing- > > > build- > > > notes=yes on Linux x86_64, confirmed linux_x86_64.s gets assembled > > > with > > > the flag and only that file. > > > > > > I've omitted the windows portion of passing as flags to the hotspot > > > build as I've no idea how. Contributions welcome if that should get > > > included. > > > > > > Thoughts? > > > > > > Thanks, > > > Severin > > > > > > >
Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option
Hi, Could I get a second review from an JDK 8u Reviewer, please? Thanks, Severin On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote: > On 2019-09-27 17:48, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this 8u build change backport which > > adds > > --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass > > certain > > assembler only flags for some builds. For example "-Wa,--generate- > > missing-build-notes=yes", to assembly files only. As the build > > system > > is different in 8u over 11u I've re-done the patch. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8227397 > > webrev: > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8227397/jdk8/01/ > Looks good to me. > > /Magnus > > Testing: Built with --with-extra-asflags=-Wa,--generate-missing- > > build- > > notes=yes on Linux x86_64, confirmed linux_x86_64.s gets assembled > > with > > the flag and only that file. > > > > I've omitted the windows portion of passing as flags to the hotspot > > build as I've no idea how. Contributions welcome if that should get > > included. > > > > Thoughts? > > > > Thanks, > > Severin > > >
Re: [8u] RFR: 8227397: Add --with-extra-asflags configure option
On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote: > On 2019-09-27 17:48, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this 8u build change backport which adds > > --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain > > assembler only flags for some builds. For example "-Wa,--generate- > > missing-build-notes=yes", to assembly files only. As the build system > > is different in 8u over 11u I've re-done the patch. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8227397 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8227397/jdk8/01/ > Looks good to me. > > /Magnus Thanks for the review, Magnus! Cheers, Severin > > Testing: Built with --with-extra-asflags=-Wa,--generate-missing-build- > > notes=yes on Linux x86_64, confirmed linux_x86_64.s gets assembled with > > the flag and only that file. > > > > I've omitted the windows portion of passing as flags to the hotspot > > build as I've no idea how. Contributions welcome if that should get > > included. > > > > Thoughts? > > > > Thanks, > > Severin > > >
[8u] RFR: 8227397: Add --with-extra-asflags configure option
Hi, Could I please get a review of this 8u build change backport which adds --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain assembler only flags for some builds. For example "-Wa,--generate- missing-build-notes=yes", to assembly files only. As the build system is different in 8u over 11u I've re-done the patch. Bug: https://bugs.openjdk.java.net/browse/JDK-8227397 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8227397/jdk8/01/ Testing: Built with --with-extra-asflags=-Wa,--generate-missing-build- notes=yes on Linux x86_64, confirmed linux_x86_64.s gets assembled with the flag and only that file. I've omitted the windows portion of passing as flags to the hotspot build as I've no idea how. Contributions welcome if that should get included. Thoughts? Thanks, Severin
