Re: Fwd: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6

[David Holmes]

Looks okay.

Thanks,
David

On 4/05/2018 8:01 AM, gary.ad...@oracle.com wrote:

Attached an updated patch for 8202319.
Kim or David could you please sponsor the push of the patch.

On 4/26/18 6:49 PM, gary.ad...@oracle.com wrote:


Adding build-dev and hotspot-runtime-dev aliases.

 Forwarded Message 
Subject: RFR: JDK-8202319: Fix compilation warnings in Solaris 
debug builds for DevStudio 12.6

Date: Thu, 26 Apr 2018 12:35:28 -0400
From: Gary Adams 
Reply-To: gary.ad...@oracle.com
To: OpenJDK Serviceability 



Getting the sources ready for the next Solaris developer studio 
toolchain.

Some additional warnings were found in the debug build.

    Issue:https://bugs.openjdk.java.net/browse/JDK-8202319
    Webrev:http://cr.openjdk.java.net/~gadams/8202319/webrev.00/

This update conditionally disables some new error checks, if the
new toolchain is used.

Re: Fwd: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6

[gary.ad...@oracle.com]

Attached an updated patch for 8202319.
Kim or David could you please sponsor the push of the patch.

On 4/26/18 6:49 PM, gary.ad...@oracle.com wrote:


Adding build-dev and hotspot-runtime-dev aliases.

 Forwarded Message 
Subject: 	RFR: JDK-8202319: Fix compilation warnings in Solaris debug 
builds for DevStudio 12.6

Date:   Thu, 26 Apr 2018 12:35:28 -0400
From:   Gary Adams 
Reply-To:   gary.ad...@oracle.com
To: OpenJDK Serviceability 



Getting the sources ready for the next Solaris developer studio toolchain.
Some additional warnings were found in the debug build.

    Issue:https://bugs.openjdk.java.net/browse/JDK-8202319
Webrev:http://cr.openjdk.java.net/~gadams/8202319/webrev.00/

This update conditionally disables some new error checks, if the
new toolchain is used.



# HG changeset patch
# User gadams
# Date 1525176684 14400
#  Tue May 01 08:11:24 2018 -0400
# Node ID c2219a364d79a09d5de1480ee1fc280e6fcb0f16
# Parent  2ace90aec48858c5d82fd64b546c29b395ea5524
8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6
Reviewed-by: kbarrett, dholmes

diff --git a/src/hotspot/share/runtime/frame.cpp 
b/src/hotspot/share/runtime/frame.cpp
--- a/src/hotspot/share/runtime/frame.cpp
+++ b/src/hotspot/share/runtime/frame.cpp
@@ -1103,6 +1103,9 @@
 
 void frame::oops_do_internal(OopClosure* f, CodeBlobClosure* cf, RegisterMap* 
map, bool use_interpreter_oop_map_cache) {
 #ifndef PRODUCT
+#if defined(__SUNPRO_CC) && __SUNPRO_CC >= 0x5140
+#pragma error_messages(off, SEC_NULL_PTR_DEREF)
+#endif
   // simulate GC crash here to dump java thread in error report
   if (CrashGCForDumpingJavaThread) {
 char *t = NULL;
diff --git a/src/hotspot/share/utilities/vmError.cpp 
b/src/hotspot/share/utilities/vmError.cpp
--- a/src/hotspot/share/utilities/vmError.cpp
+++ b/src/hotspot/share/utilities/vmError.cpp
@@ -1606,6 +1606,9 @@
 }
 
 #ifndef PRODUCT
+#if defined(__SUNPRO_CC) && __SUNPRO_CC >= 0x5140
+#pragma error_messages(off, SEC_NULL_PTR_DEREF)
+#endif
 typedef void (*voidfun_t)();
 // Crash with an authentic sigfpe
 static void crash_with_sigfpe() {

Fwd: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6

[gary.ad...@oracle.com]

Adding build-dev and hotspot-runtime-dev aliases.

 Forwarded Message 
Subject: 	RFR: JDK-8202319: Fix compilation warnings in Solaris debug 
builds for DevStudio 12.6

Date:   Thu, 26 Apr 2018 12:35:28 -0400
From:   Gary Adams 
Reply-To:   gary.ad...@oracle.com
To: OpenJDK Serviceability 



Getting the sources ready for the next Solaris developer studio toolchain.
Some additional warnings were found in the debug build.

   Issue:https://bugs.openjdk.java.net/browse/JDK-8202319
   Webrev:http://cr.openjdk.java.net/~gadams/8202319/webrev.00/

This update conditionally disables some new error checks, if the
new toolchain is used.