Re: RFR: 8197866 Docs.mk still had a reference to java.se.ee

2018-02-13 Thread David Holmes 

Thanks Lance. That fixes my builds.

David

On 14/02/2018 5:36 AM, Lance Andersen wrote:

Hi,

Please review this change to address the missed reference to java.se.ee

——
  hg diff make/Docs.gmk
diff -r 345f41527dcc make/Docs.gmk
--- a/make/Docs.gmk Thu Feb 08 15:35:49 2018 +0100
+++ b/make/Docs.gmk Tue Feb 13 14:31:36 2018 -0500
@@ -445,9 +445,9 @@
  

  # Setup generation of the Java SE API documentation (javadoc + modulegraph)
  
-# The Java SE module scope is just java.se.ee and its transitive indirect

+# The Java SE module scope is just java.se and its transitive indirect
  # exports.
-JAVASE_MODULES := java.se.ee
+JAVASE_MODULES := java.se
  
  $(eval $(call SetupApiDocsGeneration, JAVASE_API, \

  MODULES := $(JAVASE_MODULES), \
——

make and make docs runs clean

——
$ make docs
Building target 'docs' in configuration 'macosx-x64'
Generating JDK_API javadoc for 69 modules
Finished building target 'docs' in configuration 'macosx-x64'
ljanders-mac:Test-jdk10-Feb09 ljanders$
—

Best
Lance
  
   

  Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR: 8197866 Docs.mk still had a reference to java.se.ee

2018-02-13 Thread Tim Bell 

Lance:


Please review this change to address the missed reference to java.se.ee

——
  hg diff make/Docs.gmk
diff -r 345f41527dcc make/Docs.gmk
--- a/make/Docs.gmk Thu Feb 08 15:35:49 2018 +0100
+++ b/make/Docs.gmk Tue Feb 13 14:31:36 2018 -0500
@@ -445,9 +445,9 @@
  

  # Setup generation of the Java SE API documentation (javadoc + modulegraph)

-# The Java SE module scope is just java.se.ee and its transitive indirect
+# The Java SE module scope is just java.se and its transitive indirect
  # exports.
-JAVASE_MODULES := java.se.ee
+JAVASE_MODULES := java.se

  $(eval $(call SetupApiDocsGeneration, JAVASE_API, \
  MODULES := $(JAVASE_MODULES), \
——


Looks good.

/Tim

RFR: 8197866 Docs.mk still had a reference to java.se.ee

2018-02-13 Thread Lance Andersen 
Hi,

Please review this change to address the missed reference to java.se.ee

——
 hg diff make/Docs.gmk 
diff -r 345f41527dcc make/Docs.gmk
--- a/make/Docs.gmk Thu Feb 08 15:35:49 2018 +0100
+++ b/make/Docs.gmk Tue Feb 13 14:31:36 2018 -0500
@@ -445,9 +445,9 @@
 

 # Setup generation of the Java SE API documentation (javadoc + modulegraph)
 
-# The Java SE module scope is just java.se.ee and its transitive indirect
+# The Java SE module scope is just java.se and its transitive indirect
 # exports.
-JAVASE_MODULES := java.se.ee
+JAVASE_MODULES := java.se
 
 $(eval $(call SetupApiDocsGeneration, JAVASE_API, \
 MODULES := $(JAVASE_MODULES), \
——

make and make docs runs clean

——
$ make docs
Building target 'docs' in configuration 'macosx-x64'
Generating JDK_API javadoc for 69 modules
Finished building target 'docs' in configuration 'macosx-x64'
ljanders-mac:Test-jdk10-Feb09 ljanders$
—

Best
Lance
 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com