Re: RFR: 8252844: Update check configuration to Skara format [v2]
On Mon, 7 Sep 2020 08:01:54 GMT, Erik Helin wrote: >> Robin Westberg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apply review suggestion >> >> Co-authored-by: Erik Duveblad > > Looks good! Thanks for reviewing Erik! As this is blocking other pull requests from completing, I plan to integrate it right away. - PR: https://git.openjdk.java.net/jdk/pull/39
Re: RFR: 8252844: Update check configuration to Skara format [v2]
On Mon, 7 Sep 2020 08:03:25 GMT, Robin Westberg wrote: >> Now that the JDK main-line repository is using the Skara tooling, the jcheck >> configuration file should be updated to >> the new format. >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional > commit since the last revision: > > Apply review suggestion > > Co-authored-by: Erik Duveblad Looks good! .jcheck/conf line 27: > 25: > 26: [checks "committer"] > 27: role=contributor Suggestion: role=committer - Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/39
Re: RFR: 8252844: Update check configuration to Skara format [v2]
> Now that the JDK main-line repository is using the Skara tooling, the jcheck > configuration file should be updated to > the new format. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Apply review suggestion Co-authored-by: Erik Duveblad - Changes: - all: https://git.openjdk.java.net/jdk/pull/39/files - new: https://git.openjdk.java.net/jdk/pull/39/files/ee32112a..a23e3d6f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=39&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=39&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/39/head:pull/39 PR: https://git.openjdk.java.net/jdk/pull/39
RFR: 8252844: Update check configuration to Skara format
Now that the JDK main-line repository is using the Skara tooling, the jcheck configuration file should be updated to the new format. Best regards, Robin - Commit messages: - Initial update Changes: https://git.openjdk.java.net/jdk/pull/39/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=39&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8252844 Stats: 29 lines in 1 file changed: 28 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/39.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/39/head:pull/39 PR: https://git.openjdk.java.net/jdk/pull/39
