Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]
On Thu, 8 Oct 2020 07:12:12 GMT, Aleksey Shipilev wrote: >> That makes sense. We should change the order in #547 then first? So the >> final thing would be: >> >> - build release >> - build debug >> - build hotspot no-pch debug >> - build hotspot zero no-pch debug >> - build hotspot minimal no-pch debug > > ...or we drop `debug` to altogether: > > - build release > - build debug > - build hotspot no-pch > - build hotspot zero no-pch > - build hotspot minimal no-pch Yeah I had the same comment there. :) Perhaps just drop "debug" qualifier as they all have it. And perhaps drop the no-pch from the two new ones, it's IMO not that important to display it in the description (unless we were to add for example zero without no-pch) - the full config is fairly easy to figure out from the yml or the test log anyway. - PR: https://git.openjdk.java.net/jdk/pull/546
Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]
On Thu, 8 Oct 2020 07:08:46 GMT, Aleksey Shipilev wrote: >> .github/workflows/submit.yml line 109: >> >>> 107: - build debug >>> 108: - build hotspot no-pch >>> 109: - build debug hotspot no-pch zero >> >> Suggestion: >> >> - build hotspot zero no-pch debug > > That makes sense. We should change the order in #547 then first? So the final > thing would be: > > - build release > - build debug > - build hotspot no-pch debug > - build hotspot zero no-pch debug > - build hotspot minimal no-pch debug ...or we drop `debug` to altogether: - build release - build debug - build hotspot no-pch - build hotspot zero no-pch - build hotspot minimal no-pch - PR: https://git.openjdk.java.net/jdk/pull/546
Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]
On Thu, 8 Oct 2020 06:58:38 GMT, Robin Westberg wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Build with debug and no-pch for zero and minimal > > .github/workflows/submit.yml line 109: > >> 107: - build debug >> 108: - build hotspot no-pch >> 109: - build debug hotspot no-pch zero > > Suggestion: > > - build hotspot zero no-pch debug That makes sense. We should change the order in #547 then first? So the final thing would be: - build release - build debug - build hotspot no-pch debug - build hotspot zero no-pch debug - build hotspot minimal no-pch debug - PR: https://git.openjdk.java.net/jdk/pull/546
Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]
On Wed, 7 Oct 2020 16:28:17 GMT, Aleksey Shipilev wrote: >> Zero VM and Minimal VM builds are routinely discovering the problems with >> internal Hotspot dependencies. Mostly because >> they turn off the whole lot of VM features, and every path that is not >> guarded by a feature #ifdef or build file list >> fails. It would be good to add Zero and Minimal targets to submit workflow. >> >> It seems to add two ~9 minute stages, compared to ~17 minute stage for >> building no-pch hotspot, and ~33 minutes for >> full JDK. >> Attention @rwestberg. >> >> Testing: >> - [x] GH workflow still works; see [latest run >> ](https://github.com/shipilev/jdk/actions/runs/293805791) > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Build with debug and no-pch for zero and minimal Looks good to me! Adding a few additional shorter build shouldn't increase the total runtime, as the test execution waits for all builds to be done, so we are limited by the full builds anyway. One minor comment, perhaps rearrange the description a bit of these new flavors with the differentiating parts first. GitHub cuts them short in the overview list (see the list on the left at https://github.com/shipilev/jdk/actions/runs/293805791 for an example) so you can't currently tell which one is which in the overview without clicking on them. .github/workflows/submit.yml line 109: > 107: - build debug > 108: - build hotspot no-pch > 109: - build debug hotspot no-pch zero Suggestion: - build hotspot zero no-pch debug - Marked as reviewed by rwestberg (Committer). PR: https://git.openjdk.java.net/jdk/pull/546
Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]
On Wed, 7 Oct 2020 16:28:17 GMT, Aleksey Shipilev wrote: >> Zero VM and Minimal VM builds are routinely discovering the problems with >> internal Hotspot dependencies. Mostly because >> they turn off the whole lot of VM features, and every path that is not >> guarded by a feature #ifdef or build file list >> fails. It would be good to add Zero and Minimal targets to submit workflow. >> >> It seems to add two ~9 minute stages, compared to ~17 minute stage for >> building no-pch hotspot, and ~33 minutes for >> full JDK. >> Attention @rwestberg. >> >> Testing: >> - [x] GH workflow still works; see [latest run >> ](https://github.com/shipilev/jdk/actions/runs/293805791) > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Build with debug and no-pch for zero and minimal Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/546
Re: RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]
> Zero VM and Minimal VM builds are routinely discovering the problems with > internal Hotspot dependencies. Mostly because > they turn off the whole lot of VM features, and every path that is not > guarded by a feature #ifdef or build file list > fails. It would be good to add Zero and Minimal targets to submit workflow. > > Testing: > - [ ] (trying to see what automated checks would run on this PR) Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Build with debug and no-pch for zero and minimal - Changes: - all: https://git.openjdk.java.net/jdk/pull/546/files - new: https://git.openjdk.java.net/jdk/pull/546/files/e05c93d9..7e3e6ad9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=546=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=546=00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/546.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/546/head:pull/546 PR: https://git.openjdk.java.net/jdk/pull/546
