Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]
On Tue, 20 Oct 2020 11:39:36 GMT, Kiran Sidhartha Ravikumar wrote: >> Hi Guys, >> >> Please review the integration of tzdata2020c to JDK. >> >> Details regarding the change can be viewed at - >> https://mm.icann.org/pipermail/tz-announce/2020-October/60.html >> Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 >> >> Along with it, there is a test fix for >> https://bugs.openjdk.java.net/browse/JDK-8254865, With tzdata2020b, the test >> fails for the mentioned zones expecting "PST" but JDK has Zone names for >> "MST" for JRE locale provider. Since the >> purpose of the test is to get any GMT-08:00 time zone, I have excluded those >> zones from the test. Please let me know >> if the changes are good to push. >> Thanks, >> Kiran > > Kiran Sidhartha Ravikumar has updated the pull request with a new target base > due to a merge or a rebase. The > incremental webrev excludes the unrelated changes brought in by the > merge/rebase. The pull request contains three > additional commits since the last revision: > - 8254982: Adding comments for removal of zones in BasicDateTime.java > - Merge remote-tracking branch 'origin/master' into JDK-8254982 > - 8254982: (tz) Upgrade time-zone data to tzdata2020c Looks good. Thank you for the changes. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/747
Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]
> Hi Guys, > > Please review the integration of tzdata2020c to JDK. > > Details regarding the change can be viewed at - > https://mm.icann.org/pipermail/tz-announce/2020-October/60.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 > > Along with it, there is a test fix for > https://bugs.openjdk.java.net/browse/JDK-8254865, With tzdata2020b, the test > fails for the mentioned zones expecting "PST" but JDK has Zone names for > "MST" for JRE locale provider. Since the > purpose of the test is to get any GMT-08:00 time zone, I have excluded those > zones from the test. Please let me know > if the changes are good to push. > Thanks, > Kiran Kiran Sidhartha Ravikumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - 8254982: Adding comments for removal of zones in BasicDateTime.java - Merge remote-tracking branch 'origin/master' into JDK-8254982 - 8254982: (tz) Upgrade time-zone data to tzdata2020c - Changes: - all: https://git.openjdk.java.net/jdk/pull/747/files - new: https://git.openjdk.java.net/jdk/pull/747/files/7bd51537..7434663a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=747&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=747&range=00-01 Stats: 26902 lines in 293 files changed: 17268 ins; 8054 del; 1580 mod Patch: https://git.openjdk.java.net/jdk/pull/747.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/747/head:pull/747 PR: https://git.openjdk.java.net/jdk/pull/747
Re: RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c [v2]
On Mon, 19 Oct 2020 19:38:57 GMT, Naoto Sato wrote:
>> Kiran Sidhartha Ravikumar has updated the pull request with a new target
>> base due to a merge or a rebase. The
>> incremental webrev excludes the unrelated changes brought in by the
>> merge/rebase. The pull request contains three
>> additional commits since the last revision:
>> - 8254982: Adding comments for removal of zones in BasicDateTime.java
>> - Merge remote-tracking branch 'origin/master' into JDK-8254982
>> - 8254982: (tz) Upgrade time-zone data to tzdata2020c
>
> test/jdk/java/util/Formatter/BasicDateTime.java line 1695:
>
>> 1693: list.remove("America/Dawson");
>> 1694: list.remove("America/WhiteHorse");
>> 1695: list.remove("Canada/Yukon");
>
> I'd explicitly mention why these time zones are removed from the test.
Thanks, Naoto, I have added the information.
-
PR: https://git.openjdk.java.net/jdk/pull/747
