Re: RFR: 8258447: Move make/hotspot/hotspot.script to make/scripts

2020-12-16 Thread Daniel D . Daugherty
On Tue, 15 Dec 2020 23:28:25 GMT, Magnus Ihse Bursie  wrote:

> The hotspot launcher script is misplaced among the hotspot make files. It 
> should move to make/scripts (and get a proper extension).

The rename and makefile changes look good.
I've used the script on occasion, but not recently (not in the last 6 months).

-

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1791


Re: RFR: 8258447: Move make/hotspot/hotspot.script to make/scripts

2020-12-15 Thread Magnus Ihse Bursie
On Tue, 15 Dec 2020 23:28:25 GMT, Magnus Ihse Bursie  wrote:

> The hotspot launcher script is misplaced among the hotspot make files. It 
> should move to make/scripts (and get a proper extension).

Can someone from hotspot please confirm if this script is still needed/used?

-

PR: https://git.openjdk.java.net/jdk/pull/1791


RFR: 8258447: Move make/hotspot/hotspot.script to make/scripts

2020-12-15 Thread Magnus Ihse Bursie
The hotspot launcher script is misplaced among the hotspot make files. It 
should move to make/scripts (and get a proper extension).

-

Commit messages:
 - 8258447: Move make/hotspot/hotspot.script to make/scripts

Changes: https://git.openjdk.java.net/jdk/pull/1791/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1791&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8258447
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1791.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1791/head:pull/1791

PR: https://git.openjdk.java.net/jdk/pull/1791