Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 14:20:01 GMT, Andrew Leonard wrote: >> A problem was found downstream with Eclipse OpenJ9 builds whereby since >> JDK-8258411 they were unable to extend the module lists. >> This PR adds a IncludeCustomExtension to the conf/module-loader-map.conf, to >> enable the module list extension again. >> >> Signed-off-by: Andrew Leonard > > Andrew Leonard has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The pull request contains one new > commit since the last revision: > > 8260289: Unable to customize module lists after change JDK-8258411 > > Signed-off-by: Andrew Leonard Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 14:20:01 GMT, Andrew Leonard wrote: >> A problem was found downstream with Eclipse OpenJ9 builds whereby since >> JDK-8258411 they were unable to extend the module lists. >> This PR adds a IncludeCustomExtension to the conf/module-loader-map.conf, to >> enable the module list extension again. >> >> Signed-off-by: Andrew Leonard > > Andrew Leonard has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 13:08:58 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> 8260289: Unable to customize module lists after change JDK-8258411 >> >> Signed-off-by: Andrew Leonard > > Changes requested by ihse (Reviewer). > @magicus do you know what the magic pull request command is to re-generate > the webrev having updated the commit? Ah looks like it automatically picked it up :-) - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 13:57:26 GMT, Magnus Ihse Bursie wrote: >> Note, it was the change from "appending" to BOOT_MODULES to just "assigning" >> that broke the existing behaviour with the JDK-8258411 change. > > @andrew-m-leonard (Seems I can't get github to tag you???) > > That sounds good. I think you could move the IncludeCustomExtension to after > all *.conf files, to future-proof it and to make it a bit more consistent -- > "first include conf files, then adjust them in custom extensions". @magicus @AlanBateman please see new commit (webrev https://webrevs.openjdk.java.net/?repo=jdk=2219=01) - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 14:00:42 GMT, Andrew Leonard wrote: >> @andrew-m-leonard (Seems I can't get github to tag you???) >> >> That sounds good. I think you could move the IncludeCustomExtension to after >> all *.conf files, to future-proof it and to make it a bit more consistent -- >> "first include conf files, then adjust them in custom extensions". > > @magicus yes, that's exactly the new commit i've just pushed. > > @(lookups) have been a bit wobbly recently with github.com I have noticed, I > can find some people but not others! @andrew-m-leonard try searching at https://github.com/orgs/openjdk/people - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 13:57:26 GMT, Magnus Ihse Bursie wrote: >> Note, it was the change from "appending" to BOOT_MODULES to just "assigning" >> that broke the existing behaviour with the JDK-8258411 change. > > @andrew-m-leonard (Seems I can't get github to tag you???) > > That sounds good. I think you could move the IncludeCustomExtension to after > all *.conf files, to future-proof it and to make it a bit more consistent -- > "first include conf files, then adjust them in custom extensions". @magicus yes, that's exactly the new commit i've just pushed. @(lookups) have been a bit wobbly recently with github.com I have noticed, I can find some people but not others! - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 13:45:23 GMT, Andrew Leonard wrote: >> The previous behavior provided the ability to "extend" the upstream MODULE >> lists, ie.just add OpenJ9 modules to the base module lists, see: >> https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/01e13c398721628540babac94ac8663be716c0a8/closed/custom/common/Modules.gmk#L21 >> >> The present >> https://github.com/openjdk/jdk/blob/master/make/conf/module-loader-map.conf >> will simply over-write whatever is set in the BOOT_MODULES list. >> >> What I am now going to do is move the IncludeCustomExtension after the >> module-loader-map.conf inclusion. >> The other alternative would be to change module-loader-map.conf so it >> appended to any existing BOOT_MODULES variable, but I think you suggested >> that file is a straight conf file? >> >> @magicus thoughts? > > Note, it was the change from "appending" to BOOT_MODULES to just "assigning" > that broke the existing behaviour with the JDK-8258411 change. @andrew-m-leonard (Seems I can't get github to tag you???) That sounds good. I think you could move the IncludeCustomExtension to after all *.conf files, to future-proof it and to make it a bit more consistent -- "first include conf files, then adjust them in custom extensions". - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
On Mon, 25 Jan 2021 13:08:58 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> 8260289: Unable to customize module lists after change JDK-8258411 >> >> Signed-off-by: Andrew Leonard > > Changes requested by ihse (Reviewer). @magicus do you know what the magic pull request command is to re-generate the webrev having updated the commit? - PR: https://git.openjdk.java.net/jdk/pull/2219
Re: RFR: 8260289: Unable to customize module lists after change JDK-8258411 [v2]
> A problem was found downstream with Eclipse OpenJ9 builds whereby since > JDK-8258411 they were unable to extend the module lists. > This PR adds a IncludeCustomExtension to the conf/module-loader-map.conf, to > enable the module list extension again. > > Signed-off-by: Andrew Leonard Andrew Leonard has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8260289: Unable to customize module lists after change JDK-8258411 Signed-off-by: Andrew Leonard - Changes: - all: https://git.openjdk.java.net/jdk/pull/2219/files - new: https://git.openjdk.java.net/jdk/pull/2219/files/0250fdcc..ffd53bff Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=2219=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2219=00-01 Stats: 14 lines in 2 files changed: 5 ins; 7 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2219.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2219/head:pull/2219 PR: https://git.openjdk.java.net/jdk/pull/2219