Re: RFR: 8277459: Add jwebserver tool [v3]
On Thu, 25 Nov 2021 10:09:21 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix whitespace error, add missing code tag > > src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/Main.java > line 63: > >> 61: System.exit(ec); >> 62: } // otherwise the server has been started successfully and >> runs in >> 63:// another non-daemon thread. > > I wonder if we should add: > > > // another non-daemon thread, or -h or -version have been passed and > // the main thread will simply exit normally. Right, good to mention those two cases. - PR: https://git.openjdk.java.net/jdk/pull/6497
Re: RFR: 8277459: Add jwebserver tool [v3]
On Wed, 24 Nov 2021 17:29:40 GMT, Julia Boes wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > fix whitespace error, add missing code tag src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/Main.java line 63: > 61: System.exit(ec); > 62: } // otherwise the server has been started successfully and runs > in > 63:// another non-daemon thread. I wonder if we should add: // another non-daemon thread, or -h or -version have been passed and // the main thread will simply exit normally. - PR: https://git.openjdk.java.net/jdk/pull/6497
Re: RFR: 8277459: Add jwebserver tool [v3]
On Wed, 24 Nov 2021 17:29:40 GMT, Julia Boes wrote: >> This change introduces jwebserver, a dedicated JDK tool for the Simple Web >> Server. >> >> A description is provided in a follow-up comment. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > fix whitespace error, add missing code tag LGTM - Marked as reviewed by michaelm (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6497
Re: RFR: 8277459: Add jwebserver tool [v3]
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web > Server. > > A description is provided in a follow-up comment. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: fix whitespace error, add missing code tag - Changes: - all: https://git.openjdk.java.net/jdk/pull/6497/files - new: https://git.openjdk.java.net/jdk/pull/6497/files/513c5a1a..60acea9d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=6497=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=6497=01-02 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/6497.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6497/head:pull/6497 PR: https://git.openjdk.java.net/jdk/pull/6497
