Re: RFR: JDK-8200375: Change to GCC 7.3.0 for building Linux at Oracle

2018-04-04 Thread Martin Buchholz 
I presume build folk are aware that older compilers produce more portable
binaries.
My own rule of thumb is to use 5 year old compilers - battle tested, well
aged, but haven't turned to vinegar yet.

On Tue, Apr 3, 2018 at 11:14 AM, Erik Joelsson 
wrote:

> This patch changes the default devkit used to produce builds for Linux x64
> at Oracle. The new devkit is based on GCC 7.3.0.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8200375/webrev.01/
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8200375
>
> /Erik
>
>

Re: RFR: JDK-8200375: Change to GCC 7.3.0 for building Linux at Oracle

2018-04-04 Thread Erik Joelsson 

On 2018-04-04 17:05, David Holmes wrote:

On 4/04/2018 4:14 AM, Erik Joelsson wrote:
This patch changes the default devkit used to produce builds for 
Linux x64 at Oracle. The new devkit is based on GCC 7.3.0.


Webrev: http://cr.openjdk.java.net/~erikj/8200375/webrev.01/


What does the final part of gcc7.3.0-OEL6.4+1.0 refer to? It was 1.3 
and is now 1.0.


It's an internal version string for the devkit. I bump it when making 
changes that aren't changing the compiler or sysroot versions, like 
adding another library to the sysroot (e.g. libffi, freetype). I figured 
restarting it at 1.0 at times like this makes sense.


/Erik

David


Bug: https://bugs.openjdk.java.net/browse/JDK-8200375

/Erik

Re: RFR: JDK-8200375: Change to GCC 7.3.0 for building Linux at Oracle

2018-04-04 Thread David Holmes 

On 4/04/2018 4:14 AM, Erik Joelsson wrote:
This patch changes the default devkit used to produce builds for Linux 
x64 at Oracle. The new devkit is based on GCC 7.3.0.


Webrev: http://cr.openjdk.java.net/~erikj/8200375/webrev.01/


What does the final part of gcc7.3.0-OEL6.4+1.0 refer to? It was 1.3 and 
is now 1.0.


David


Bug: https://bugs.openjdk.java.net/browse/JDK-8200375

/Erik

Re: RFR: JDK-8200375: Change to GCC 7.3.0 for building Linux at Oracle

2018-04-03 Thread Tim Bell 

Erik:

On 04/03/18 12:38, Magnus Ihse Bursie wrote:

On 2018-04-03 20:14, Erik Joelsson wrote:

This patch changes the default devkit used to produce builds for Linux
x64 at Oracle. The new devkit is based on GCC 7.3.0.


Woho! :) The future is here. What a leap, 4.9.2 -> 7.3.0.


Indeed.



Webrev: http://cr.openjdk.java.net/~erikj/8200375/webrev.01/

Looks good to me.

/Magnus


Bug: https://bugs.openjdk.java.net/browse/JDK-8200375


Looks good to me as well.

/Tim

Re: RFR: JDK-8200375: Change to GCC 7.3.0 for building Linux at Oracle

2018-04-03 Thread Magnus Ihse Bursie 

On 2018-04-03 20:14, Erik Joelsson wrote:
This patch changes the default devkit used to produce builds for Linux 
x64 at Oracle. The new devkit is based on GCC 7.3.0.


Woho! :) The future is here. What a leap, 4.9.2 -> 7.3.0.


Webrev: http://cr.openjdk.java.net/~erikj/8200375/webrev.01/

Looks good to me.

/Magnus


Bug: https://bugs.openjdk.java.net/browse/JDK-8200375

/Erik

RFR: JDK-8200375: Change to GCC 7.3.0 for building Linux at Oracle

2018-04-03 Thread Erik Joelsson 
This patch changes the default devkit used to produce builds for Linux 
x64 at Oracle. The new devkit is based on GCC 7.3.0.


Webrev: http://cr.openjdk.java.net/~erikj/8200375/webrev.01/

Bug: https://bugs.openjdk.java.net/browse/JDK-8200375

/Erik