Re: RFR: JDK-8243985 Make source generation by generatecharacter reproducible

2020-04-28 Thread Erik Joelsson

Looks good.

/Erik

On 2020-04-28 02:19, Magnus Ihse Bursie wrote:
For no really good reason, the generatecharacter buildtool outputs the 
current time in the generated source. While this has no effect on the 
generated class files, it makes gensrc comparison fail between builds.


Bug: https://bugs.openjdk.java.net/browse/JDK-8243985
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8243985-make-generatecharacter-reproducible/webrev.01


/Magnus


Re: RFR: JDK-8243985 Make source generation by generatecharacter reproducible

2020-04-28 Thread naoto . sato

Looks good.

Naoto

On 4/28/20 2:19 AM, Magnus Ihse Bursie wrote:
For no really good reason, the generatecharacter buildtool outputs the 
current time in the generated source. While this has no effect on the 
generated class files, it makes gensrc comparison fail between builds.


Bug: https://bugs.openjdk.java.net/browse/JDK-8243985
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8243985-make-generatecharacter-reproducible/webrev.01 



/Magnus


RFR: JDK-8243985 Make source generation by generatecharacter reproducible

2020-04-28 Thread Magnus Ihse Bursie
For no really good reason, the generatecharacter buildtool outputs the 
current time in the generated source. While this has no effect on the 
generated class files, it makes gensrc comparison fail between builds.


Bug: https://bugs.openjdk.java.net/browse/JDK-8243985
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8243985-make-generatecharacter-reproducible/webrev.01


/Magnus