Re: RFR: JDK-8257789: Fix incremental build of test-image and bundles
On Fri, 4 Dec 2020 23:01:26 GMT, Erik Joelsson wrote: > When building the test-bundle incrementally, it always gets rebuilt. This is > caused by the prepare-test-image target in TestImage.gmk, where we create a > README file as part of a recipe for a PHONY target. This means that the > README is always rebuilt, which in turn triggers downstream rebuilds. This is > generally a bad pattern that should be avoided. Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1635
Re: RFR: JDK-8257789: Fix incremental build of test-image and bundles
On Fri, 4 Dec 2020 23:01:26 GMT, Erik Joelsson wrote: > When building the test-bundle incrementally, it always gets rebuilt. This is > caused by the prepare-test-image target in TestImage.gmk, where we create a > README file as part of a recipe for a PHONY target. This means that the > README is always rebuilt, which in turn triggers downstream rebuilds. This is > generally a bad pattern that should be avoided. Looks good. - Marked as reviewed by tbell (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1635
RFR: JDK-8257789: Fix incremental build of test-image and bundles
When building the test-bundle incrementally, it always gets rebuilt. This is caused by the prepare-test-image target in TestImage.gmk, where we create a README file as part of a recipe for a PHONY target. This means that the README is always rebuilt, which in turn triggers downstream rebuilds. This is generally a bad pattern that should be avoided. - Commit messages: - Use target var in recipe - Move readme creation to its own target Changes: https://git.openjdk.java.net/jdk/pull/1635/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1635=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257789 Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/1635.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1635/head:pull/1635 PR: https://git.openjdk.java.net/jdk/pull/1635
