RE: RFR: S, 13 JDK-8226628 The copyright footer should be enclosed in

2019-06-22 Thread Iris Clark
Hi, Jon.

> JBS: https://bugs.openjdk.java.net/browse/JDK-8226628

Looks good.  Thanks for taking care of this.

Iris


Re: RFR: S, 13 JDK-8226628 The copyright footer should be enclosed in

2019-06-21 Thread Lance Andersen
+1
> On Jun 21, 2019, at 8:22 PM, Jonathan Gibbons  
> wrote:
> 
> Please review a small change to make/Docs.gmk so that the copyright footer 
> added to specs pages is enclosed in 
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8226628
> 
> -- Jon
> 
> 
> $ hg diff -R open
> diff -r 179204eb9444 make/Docs.gmk
> --- a/make/Docs.gmk Fri Jun 21 12:09:07 2019 -0700
> +++ b/make/Docs.gmk Fri Jun 21 17:14:56 2019 -0700
> @@ -532,7 +532,7 @@
>  # file. The number 0-2 below represent how many extra directory levels down
>  # below the specs dir the specs html file is located. Each file name is
>  # stored in a variable SPECS_BOTTOM_FILE_$n where $n is 0, 1 or 2.
> -SPECS_BOTTOM = $(COPYRIGHT_BOTTOM)
> +SPECS_BOTTOM = $(COPYRIGHT_BOTTOM)
>  # The legal dir is one ../ below the specs dir, so start with one ../.
>  specs_bottom_rel_path := ../
>  $(foreach n, 0 1 2, \
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 





RFR: S,13 JDK-8226628 The copyright footer should be enclosed in

2019-06-21 Thread Jonathan Gibbons
Please review a small change to make/Docs.gmk so that the copyright 
footer added to specs pages is enclosed in 


JBS: https://bugs.openjdk.java.net/browse/JDK-8226628

-- Jon


$ hg diff -R open
diff -r 179204eb9444 make/Docs.gmk
--- a/make/Docs.gmk Fri Jun 21 12:09:07 2019 -0700
+++ b/make/Docs.gmk Fri Jun 21 17:14:56 2019 -0700
@@ -532,7 +532,7 @@
 # file. The number 0-2 below represent how many extra directory levels 
down

 # below the specs dir the specs html file is located. Each file name is
 # stored in a variable SPECS_BOTTOM_FILE_$n where $n is 0, 1 or 2.
-SPECS_BOTTOM = $(COPYRIGHT_BOTTOM)
+SPECS_BOTTOM = $(COPYRIGHT_BOTTOM)
 # The legal dir is one ../ below the specs dir, so start with one ../.
 specs_bottom_rel_path := ../
 $(foreach n, 0 1 2, \