Re: RFR: 8230043: Lazily load libverify
Hi David, On 2019-08-26 07:12, David Holmes wrote: Hi Claes, This cleanup all appears fine to me. The unused Mutex declarations might be better handled in a separate RFE but I don't insist. You could file the RFE and still fix together in this one changeset. fair enough: https://bugs.openjdk.java.net/browse/JDK-8230140 Testing: tier1-4 Do you know which tests actually test the older verifier? Just thinking that it might be a good idea to make them more obvious. I'm not too familiar with the testing in this area, but was told there are quite a few JCK tests that test the byte code verifiers, libverify included, and that we run the full set of those in tier3. Thanks /Claes
Re: RFR: 8230043: Lazily load libverify
Hi Claes, This cleanup all appears fine to me. The unused Mutex declarations might be better handled in a separate RFE but I don't insist. You could file the RFE and still fix together in this one changeset. Testing: tier1-4 Do you know which tests actually test the older verifier? Just thinking that it might be a good idea to make them more obvious. Thanks, David On 23/08/2019 11:08 pm, Claes Redestad wrote: Hi, please review this cleanup to untangle the old bytecode verifier (libverify). It's currently linked and loaded eagerly and early during bootstrap. Webrev: http://cr.openjdk.java.net/~redestad/8230043/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8230043 - removes dependency on libverify from libjava by moving the check_format.c functions into libjava (they don't need to be exported via JNI) - fixed build to not link libjava with libverify - removes the eager initialization of libverify in os::native_java_library - removes the verify_stubs and directs verifier.cpp to load and call VerifyClassForMajorVersion in libverify directly. The initialization is synchronized on a new mutex, Verify_lock - remove the unused VerifyClass entry point and simplify code in the verifier by removing some indirections Testing: tier1-4 Thanks! /Claes
Re: RFR: 8230043: Lazily load libverify
On 2019-08-23 17:29, Erik Joelsson wrote: Build change looks good. /Erik Thanks for reviewing! /Claes
Re: RFR: 8230043: Lazily load libverify
Build change looks good. /Erik On 2019-08-23 06:08, Claes Redestad wrote: Hi, please review this cleanup to untangle the old bytecode verifier (libverify). It's currently linked and loaded eagerly and early during bootstrap. Webrev: http://cr.openjdk.java.net/~redestad/8230043/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8230043 - removes dependency on libverify from libjava by moving the check_format.c functions into libjava (they don't need to be exported via JNI) - fixed build to not link libjava with libverify - removes the eager initialization of libverify in os::native_java_library - removes the verify_stubs and directs verifier.cpp to load and call VerifyClassForMajorVersion in libverify directly. The initialization is synchronized on a new mutex, Verify_lock - remove the unused VerifyClass entry point and simplify code in the verifier by removing some indirections Testing: tier1-4 Thanks! /Claes
