Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]
On Tue, 16 Mar 2021 21:02:28 GMT, Claes Redestad wrote: >> This patch changes the otherLowercase / otherUppercase bits to be set if >> either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or >> the Unicode Other_Lowercase / Other_Uppercase property is set. This >> simplifies the lookup in Character.isLowerCase/isUpperCase to a single table >> lookup, which appears to be healthy for performance. >> >> I also took the opportunity to clean up the somewhat dated GenerateCharacter >> utility class. >> >> Testing: tier1-3 > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Roger review + additional cleanups Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3028
Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]
On Tue, 16 Mar 2021 21:02:28 GMT, Claes Redestad wrote: >> This patch changes the otherLowercase / otherUppercase bits to be set if >> either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or >> the Unicode Other_Lowercase / Other_Uppercase property is set. This >> simplifies the lookup in Character.isLowerCase/isUpperCase to a single table >> lookup, which appears to be healthy for performance. >> >> I also took the opportunity to clean up the somewhat dated GenerateCharacter >> utility class. >> >> Testing: tier1-3 > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Roger review + additional cleanups Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3028
Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]
On Tue, 16 Mar 2021 21:02:28 GMT, Claes Redestad wrote: >> This patch changes the otherLowercase / otherUppercase bits to be set if >> either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or >> the Unicode Other_Lowercase / Other_Uppercase property is set. This >> simplifies the lookup in Character.isLowerCase/isUpperCase to a single table >> lookup, which appears to be healthy for performance. >> >> I also took the opportunity to clean up the somewhat dated GenerateCharacter >> utility class. >> >> Testing: tier1-3 > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last revision: > > Roger review + additional cleanups Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3028
Re: RFR: 8263677: Improve Character.isLowerCase/isUpperCase lookups [v2]
> This patch changes the otherLowercase / otherUppercase bits to be set if > either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the > Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies > the lookup in Character.isLowerCase/isUpperCase to a single table lookup, > which appears to be healthy for performance. > > I also took the opportunity to clean up the somewhat dated GenerateCharacter > utility class. > > Testing: tier1-3 Claes Redestad has updated the pull request incrementally with one additional commit since the last revision: Roger review + additional cleanups - Changes: - all: https://git.openjdk.java.net/jdk/pull/3028/files - new: https://git.openjdk.java.net/jdk/pull/3028/files/5dc70a95..5698b88c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=3028=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=3028=00-01 Stats: 27 lines in 1 file changed: 2 ins; 8 del; 17 mod Patch: https://git.openjdk.java.net/jdk/pull/3028.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3028/head:pull/3028 PR: https://git.openjdk.java.net/jdk/pull/3028
