Re: RFR: JDK-8214780 Create pandoc package for Windows
It turned out this did not work in Cygwin, since the exe file did not have the executable permission set. And this was preserved by tar. Adding a chmod helped. New webrev: http://cr.openjdk.java.net/~ihse/JDK-8214780-create-pandoc-package-for-windows/webrev.02 /Magnus On 2018-12-04 13:34, Magnus Ihse Bursie wrote: As requested in JDK-8179917, we should create a jib package for pandoc on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8214780 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8214780-create-pandoc-package-for-windows/webrev.01 /Magnus
Re: RFR: JDK-8214780 Create pandoc package for Windows
Looks good. /Erik On 2018-12-05 06:41, Magnus Ihse Bursie wrote: It turned out this did not work in Cygwin, since the exe file did not have the executable permission set. And this was preserved by tar. Adding a chmod helped. New webrev: http://cr.openjdk.java.net/~ihse/JDK-8214780-create-pandoc-package-for-windows/webrev.02 /Magnus On 2018-12-04 13:34, Magnus Ihse Bursie wrote: As requested in JDK-8179917, we should create a jib package for pandoc on Windows. Bug: https://bugs.openjdk.java.net/browse/JDK-8214780 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8214780-create-pandoc-package-for-windows/webrev.01 /Magnus
JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13
Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update: http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in the build of the libraries. A new class file version is defined and the feature version is updated. Other aspects of the changes will be reviewed on other mailing lists, compiler-dev, etc. Thanks, -Joe
Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13
I think jaxp and nashorn TEST.ROOT will also need to be updated. Otherwise build changes look good. /Erik On 2018-12-05 09:28, joe darcy wrote: Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update: http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in the build of the libraries. A new class file version is defined and the feature version is updated. Other aspects of the changes will be reviewed on other mailing lists, compiler-dev, etc. Thanks, -Joe
Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13
Hi Erik, Noted; I'll update the other TEST.ROOT files in the next iteration and before this is pushed. Thanks for the review, -Joe On 12/5/2018 9:56 AM, Erik Joelsson wrote: I think jaxp and nashorn TEST.ROOT will also need to be updated. Otherwise build changes look good. /Erik On 2018-12-05 09:28, joe darcy wrote: Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update: http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in the build of the libraries. A new class file version is defined and the feature version is updated. Other aspects of the changes will be reviewed on other mailing lists, compiler-dev, etc. Thanks, -Joe
Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13
On 05/12/2018 17:28, joe darcy wrote: Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update: http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in the build of the libraries. A new class file version is defined and the feature version is updated. The changes looks good to me. -Alan
Re: JDK 13 RFR of JDK-8205626: Start of release updates for JDK 13
Looks good. Mandy On 12/5/18 9:28 AM, joe darcy wrote: Hello, With the inception of JDK 13 right around the corner, please review the build-related changes of the update: http://cr.openjdk.java.net/~darcy/jdk13-fork.2 As usual, javac defines a new -source/-target 13 which is used in the build of the libraries. A new class file version is defined and the feature version is updated. Other aspects of the changes will be reviewed on other mailing lists, compiler-dev, etc. Thanks, -Joe
