Re: RFR 15 8242462: Residual Cleanup of rmic removal
Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm not sure who are the right people to review bin/unshuffle_list.txt though,.. build team (cc'ed them)? Cheers, -- Igor > On Apr 9, 2020, at 6:48 AM, Roger Riggs wrote: > > Please review a few cleanups I missed on the removal of rmic. > I didn't get a reply on the changes to the hotspot (cds) tests. > (I did get an ok on the javadoc changes) > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319-misc-1/ > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8242462 > > Thanks, Roger >
Re: RFR 15 8242462: Residual Cleanup of rmic removal
unshuffle_list.txt looks good to me. /Erik On 2020-04-10 11:44, Igor Ignatyev wrote: Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm not sure who are the right people to review bin/unshuffle_list.txt though,.. build team (cc'ed them)? Cheers, -- Igor On Apr 9, 2020, at 6:48 AM, Roger Riggs wrote: Please review a few cleanups I missed on the removal of rmic. I didn't get a reply on the changes to the hotspot (cds) tests. (I did get an ok on the javadoc changes) Webrev: http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319-misc-1/ Issue: https://bugs.openjdk.java.net/browse/JDK-8242462 Thanks, Roger
Re: RFR 15 8242462: Residual Cleanup of rmic removal
Runtime test changes look good to me, Misha On 4/10/20 11:44 AM, Igor Ignatyev wrote: Hi Roger, removal of applications/ctw/modules/jdk_rmic.java and changes in doc (assuming .html was generated from .md) look good to me. adding hotspot-runtime alias to bring attention of runtime team. I'm not sure who are the right people to review bin/unshuffle_list.txt though,.. build team (cc'ed them)? Cheers, -- Igor On Apr 9, 2020, at 6:48 AM, Roger Riggs wrote: Please review a few cleanups I missed on the removal of rmic. I didn't get a reply on the changes to the hotspot (cds) tests. (I did get an ok on the javadoc changes) Webrev: http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319-misc-1/ Issue: https://bugs.openjdk.java.net/browse/JDK-8242462 Thanks, Roger
