Re: 8u build failure win7/cygwin64

2015-04-29 Thread gary.ad...@oracle.com 
I've found that disable ccache fixes problems building e_acos ( the 
first native file in the jdk portion of the build).


On 4/29/15 4:23 AM, Magnus Ihse Bursie wrote:

On 2015-04-29 09:50, Semyon Sadetsky wrote:

Hello,

Please advise what is the source of the next issue:
(...libfdlibm/e_acos.obj file is really absent)


Hi Semyon,

Please re-run with make LOG=debug JOBS=1 to get a better log prior 
to the failure.


/Magnus




## Starting jdk
Importing CORBA classes.jar
Importing CORBA src.zip
Importing CORBA bin.zip
Importing JAXP classes.jar
Importing JAXP src.zip
Importing JAXWS src.zip
Importing JAXWS classes.jar
Importing LANGTOOLS src.zip
Importing LANGTOOLS classes.jar
Generating charsetmapping classes
Generating buffer classes
Microsoft (R) C/C++ Optimizing Compiler Version 16.00.40219.01 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

Compiling 161 files for BUILD_TOOLS
Generating exceptions classes
genSocketOptionRegistry.c
Microsoft (R) Incremental Linker Version 10.00.40219.01
Copyright (C) Microsoft Corporation.  All rights reserved.

Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Copying and cleaning 53 properties
Compiling 521 properties into resource bundles
Creating sun/util/LocaleDataMetaInfo.java from 421 found resources.
Generating sun/misc/Version.java
Generating sun/misc/Version.java compact1
Generating sun/misc/Version.java compact3
Generating sun/misc/Version.java compact2
Aliases: Table size 1024 (10 bits), shift 0, max chain depth 3
Classes: Table size 32 (5 bits), shift 1, max chain depth 3
Cache: Table size 32 (5 bits), shift 1, max chain depth 3
Generating beaninfo
Generating Nimbus source files
[Error] encoded value was less than 0: encode(-8.326673E-17, 5.0, 
11.0, 16.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was greater than 3: encode(15.029411, 1.0, 
14.0, 15.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was greater than 3: encode(15.029411, 1.0, 
14.0, 15.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was greater than 3: encode(15.029411, 1.0, 
14.0, 15.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was greater than 3: encode(15.029411, 1.0, 
14.0, 15.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was greater than 3: encode(15.029411, 1.0, 
14.0, 15.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)
[Error] encoded value was greater than 3: encode(15.029411, 1.0, 
14.0, 15.0)
[Error] encoded value was less than 0: encode(-0.05882353, 1.0, 24.0, 
25.0)

[Error] Encountered Infinity: encode(-0.00877193, 0.0, 7.0, 7.0)
Generating HTML DTD file
Compiling 4 files for BUILD_BREAKITERATOR
[Parsed DTD html32 in 159ms]
Compiling 9722 files for BUILD_JDK
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Compiling 235 files for BUILD_SECURITY
Compiling 2 files for BUILD_ACCESSBRIDGE_64
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Could not start process!  Failed with error 2: The system cannot find 
the file specified.


lib/CoreLibraries.gmk:37: recipe for target 
'/cygdrive/c/cygwin64/home/ssadetsk/projects/jdk8/jdk8u-dev/build/windows-x86_64-normal-server-fastdebug/jdk/objs/libfdlibm/e_acos.obj' 
failed
make[2]: *** 
[/cygdrive/c/cygwin64/home/ssadetsk/projects/jdk8/jdk8u-dev/build/windows-x86_64-normal-server-fastdebug/jdk/objs/libfdlibm/e_acos.obj] 
Error 1

make[2]: *** Waiting for unfinished jobs
Could not start process!  Failed with error 2: The system cannot find 
the file specified.


Could not start process!  Failed with error 2: The system cannot find 
the file specified.


lib/CoreLibraries.gmk:37: recipe for target 
'/cygdrive/c/cygwin64/home/ssadetsk/projects/jdk8/jdk8u-dev/build/windows-x86_64-normal-server-fastdebug/jdk/objs/libfdlibm/e_atan2.obj' 
failed
make[2]: *** 
[/cygdrive/c/cygwin64/home/ssadetsk/projects/jdk8/jdk8u-dev/build/windows-x86_64-normal-server-fastdebug/jdk/objs/libfdlibm/e_atan2.obj] 
Error 1
lib/CoreLibraries.gmk:37: recipe for target 
'/cygdrive/c/cygwin64/home/ssadetsk/projects/jdk8/jdk8u-dev/build/windows-x86_64-normal-server-fastdebug/jdk/objs/libfdlibm/e_asin.obj' 
failed
make[2]: *** 
[/cygdrive/c/cygwin64/home/ssadetsk/projects/jdk8/jdk8u-dev/build/windows-x86_64-normal-server-fastdebug/jdk/objs/libfdlibm/e_asin.obj] 
Error 1

BuildJdk.gmk:70: recipe for target

Re: RFR: JDK-8165946: buildjdk logic is incomplete when separate sysroots needed

2016-09-14 Thread gary.ad...@oracle.com 

I'll add the extra check before pushing.

if test "x$BUILD_SYSROOT" = x; then

796 BUILD_SYSROOT="$BUILD_DEVKIT_SYSROOT"

fi

Before there was a devkit option it was common to set sysroot and toolchain
path separately. I don't know if the overlap precedence was ever specified.

On 9/14/16 4:39 AM, Erik Joelsson wrote:

Hello,

Looks ok for now.

I think that for completeness, the --with-build-sysroot option should 
also override a sysroot set by the build-devkit, but it's not that 
important.


/Erik

On 2016-09-13 14:19, Gary Adams wrote:
When the buildjdk logic was added to the jdk9 build system, it did 
not completely
cover the use cases required in the mobile/dev builds. We have been 
working around
this issue using a prebuilt macosx buildjdk with the --with-build-jdk 
autoconf option.
This is an awkward workaround, because the buildjdk had to be new 
enough to match the
requirements of the repos being built. e.g. jdk9 b132 included some 
newer command line

option in the jmod and jlink command build step.

This fix is a more permanent solution adding a --with-build-sysroot 
option to allow
an explicit reference to the sysroot to use on the build system. A 
similar call already exists

when --with-devkit and --with-build-devkit are used.

   JIRA: https://bugs.openjdk.java.net/browse/JDK-8165946
   Webrev: http://cr.openjdk.java.net/~gadams/8165946/wevrev.00/

This is an interim fix in the mobile/dev repos. Many of the platform 
specific checks will need to

be addressed before they can be targeted for the mainstream repos.

Here's an example of how this would be used for an ios-arm64 build :


export 
IOS_SDK_PATH=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk
export 
MACOSX_SDK_PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk

...
configure \
...
--with-sys-root=${IOS_SDK_PATH} \
--with-build-sysroot=${MACOSX_SDK_PATH}

RFR: JDK-8205055: Fix compilation optimization errors with new Solaris toolchain

2018-06-14 Thread gary.ad...@oracle.com 

Locally tested the fix below and via mach5 jobs.
The ~50 failed tests all completed successfully.
It'd be good for Erik to repeat his full testing with
this patch included in case it blocked other issues
from being observed.

This fix can be integrated after the sync from jdk/client.

 Issue: https://bugs.openjdk.java.net/browse/JDK-8205055

Proposed fix:

diff --git a/make/hotspot/lib/JvmOverrideFiles.gmk 
b/make/hotspot/lib/JvmOverrideFiles.gmk

--- a/make/hotspot/lib/JvmOverrideFiles.gmk
+++ b/make/hotspot/lib/JvmOverrideFiles.gmk
@@ -74,6 +74,8 @@

 else ifeq ($(OPENJDK_TARGET_OS), solaris)
   ifneq ($(DEBUG_LEVEL), slowdebug)
+ # dev studio 12.6 workaround
+ BUILD_LIBJVM_arguments.cpp_OPTIMIZATION := LOW

Fwd: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6

2018-04-26 Thread gary.ad...@oracle.com 

Adding build-dev and hotspot-runtime-dev aliases.

 Forwarded Message 
Subject: 	RFR: JDK-8202319: Fix compilation warnings in Solaris debug 
builds for DevStudio 12.6

Date:   Thu, 26 Apr 2018 12:35:28 -0400
From:   Gary Adams <gary.ad...@oracle.com>
Reply-To:   gary.ad...@oracle.com
To: OpenJDK Serviceability <serviceability-...@openjdk.java.net>



Getting the sources ready for the next Solaris developer studio toolchain.
Some additional warnings were found in the debug build.

   Issue:https://bugs.openjdk.java.net/browse/JDK-8202319
   Webrev:http://cr.openjdk.java.net/~gadams/8202319/webrev.00/

This update conditionally disables some new error checks, if the
new toolchain is used.

Re: Fwd: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6

2018-05-03 Thread gary.ad...@oracle.com 

Attached an updated patch for 8202319.
Kim or David could you please sponsor the push of the patch.

On 4/26/18 6:49 PM, gary.ad...@oracle.com wrote:


Adding build-dev and hotspot-runtime-dev aliases.

 Forwarded Message 
Subject: 	RFR: JDK-8202319: Fix compilation warnings in Solaris debug 
builds for DevStudio 12.6

Date:   Thu, 26 Apr 2018 12:35:28 -0400
From:   Gary Adams <gary.ad...@oracle.com>
Reply-To:   gary.ad...@oracle.com
To: OpenJDK Serviceability <serviceability-...@openjdk.java.net>



Getting the sources ready for the next Solaris developer studio toolchain.
Some additional warnings were found in the debug build.

    Issue:https://bugs.openjdk.java.net/browse/JDK-8202319
Webrev:http://cr.openjdk.java.net/~gadams/8202319/webrev.00/

This update conditionally disables some new error checks, if the
new toolchain is used.



# HG changeset patch
# User gadams
# Date 1525176684 14400
#  Tue May 01 08:11:24 2018 -0400
# Node ID c2219a364d79a09d5de1480ee1fc280e6fcb0f16
# Parent  2ace90aec48858c5d82fd64b546c29b395ea5524
8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6
Reviewed-by: kbarrett, dholmes

diff --git a/src/hotspot/share/runtime/frame.cpp 
b/src/hotspot/share/runtime/frame.cpp
--- a/src/hotspot/share/runtime/frame.cpp
+++ b/src/hotspot/share/runtime/frame.cpp
@@ -1103,6 +1103,9 @@
 
 void frame::oops_do_internal(OopClosure* f, CodeBlobClosure* cf, RegisterMap* 
map, bool use_interpreter_oop_map_cache) {
 #ifndef PRODUCT
+#if defined(__SUNPRO_CC) && __SUNPRO_CC >= 0x5140
+#pragma error_messages(off, SEC_NULL_PTR_DEREF)
+#endif
   // simulate GC crash here to dump java thread in error report
   if (CrashGCForDumpingJavaThread) {
 char *t = NULL;
diff --git a/src/hotspot/share/utilities/vmError.cpp 
b/src/hotspot/share/utilities/vmError.cpp
--- a/src/hotspot/share/utilities/vmError.cpp
+++ b/src/hotspot/share/utilities/vmError.cpp
@@ -1606,6 +1606,9 @@
 }
 
 #ifndef PRODUCT
+#if defined(__SUNPRO_CC) && __SUNPRO_CC >= 0x5140
+#pragma error_messages(off, SEC_NULL_PTR_DEREF)
+#endif
 typedef void (*voidfun_t)();
 // Crash with an authentic sigfpe
 static void crash_with_sigfpe() {

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-01 Thread gary.ad...@oracle.com 

First pass over the code I disabled the compilation flag and then
did quick substitution for the easier functions. I commented out the
WSASendDisconnect calls so I could see what tests would fail if
the function was just removed. I have a replacement now that uses
"shutdown(fd,SD_SEND)", but I still have a few more test failures to
investigate.

I updated the error message text for "getaddrinfo".

I'll post a revised webrev after the 4 jshell errors are corrected.


On 2/1/18 3:11 AM, Langer, Christoph wrote:

Hi Gary,

I was having a look at your changes.

I'm wondering what the reason is behind uncommenting WSASendDisconnect in 
Java_sun_nio_ch_SocketDispatcher_preClose0 of file SocketDispatcher.c? And in 
dbgsysSocketClose?

In socketTransport.c, line:
 331 setLastError(0, "gethostbyname: unknown host");
you should change the description text of the error to getaddrinfo instead of 
gethostbyname.

Best regards
Christoph



-Original Message-
From: build-dev [mailto:build-dev-boun...@openjdk.java.net] On Behalf Of Gary 
Adams
Sent: Donnerstag, 25. Januar 2018 19:47
To: OpenJDK Serviceability ; OpenJDK Build 
; OpenJDK Networking 
Subject: RFR: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 
'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

Here's a first pass attempt to remove the -D_WINSOCK_DEPRECATED_NO_WARNINGS
build flag and update the winsock deprecated functions.

Issue: https://bugs.openjdk.java.net/browse/JDK-8080990
Webrev: http://cr.openjdk.java.net/~gadams/8080990/

These are the initial deprecated functions updated:
 gethostbyname -> getaddrinfo
 inet_addr -> inet_pton
 inet_ntoa -> inet_ntop

I'm not sure how to replace the existing WSASendDisconnect calls.
It's not clear that it actually provides a graceful disconnect.

Re: JDK-8080990: libdt_socket/socket_md.c(202) : warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW()

2018-02-07 Thread gary.ad...@oracle.com 

A fresh webrev rebased with latest jdk/jdk repos:
 http://cr.openjdk.java.net/~gadams/8080990/webrev.03/index.html

If there are no more comments, I'll check in locally with these reviewers
  clanger,chegar,erikj

and cut patches on Thurs AM.


On 2/5/18 2:15 PM, Gary Adams wrote:

One more to fix to cover the remaining test failures I was seeing.

Previously, using inet_addr, there was a single -1 return that needed 
to be checked.
Now that we're using inet_pton, there is a -1 and a 0 error return to 
be considered.


My preference would be to leave the dbgSysInetAddr name unchanged and 
have the low level
check for inet_pton errors to simply return the -1 that was previously 
checked.


This specific issue is about the deprecation of library functions on 
windows. I'd recommend not
upgrading the other platforms at this time until a complete update is 
done for ipv6 support.


I'll post a new webrev when I've retested using the updated inet_pton 
error checking.


...

Hi Gary,


>/Here's a revised webrev />//>/http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html 
 />//>/Still testing ... />//>/Using shutdown() fixed problems reported by the />/java/nio/channelSocketChannel tests. /

The fix looks good. I would think we should rename dbgsysInetAddr to dbgsysPToN 
and use inet_pton also for the Unix/Linux platforms. It would be the better 
choice there as well, though we still only support IPv4 in libdt_socket.

>//>/I also noticed prior use of getaddrinfo for "localhost" was not calling 
/>/freeaddrinfo. /
Thanks for spotting/fixing that.

Best regards
Christoph