Re: umount patch

[Tomas M]

Fabio Busatto wrote:
  Hi, this is a very simple patch to add support in umount for -i option.

Ah, good point, I sent a patch for 'mount -i' some time ago (which was 
already included in CVS), but I entirely forgot that 'umount'
needs -i as well!

So I vote for this -i option as well.


Tomas M
slax.org
___
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: mount patch

[Tomas M]

Tomas M wrote:
 Hello,
 this is a patch for mount.c in busybox, to simply ignore -i option.
 
 -i is used in GNU mount for this purpose:
  Don't call the /sbin/mount.filesystem helper even if it exists.
 
 But BusyBox doesn't call this anyway (IMHO) so it's safe to silently 
 ignore it.
 
 This is my first busybox modification ever, so please review the patch 
 if it is correct! It should be.

I forgot to tell you why the patch is needed at all.

It's useful for newest FUSE (filesystem in userspace), where fuse forces 
to use -i option. This causes new fuse (2.7+) to stop working with 
busybox's mount. One is not able to mount any fuse filesystem without -i.


Thank you for your consideration.

Tomas M


___
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox

mount patch

[Tomas M]

Hello,
this is a patch for mount.c in busybox, to simply ignore -i option.

-i is used in GNU mount for this purpose:
 Don't call the /sbin/mount.filesystem helper even if it exists.

But BusyBox doesn't call this anyway (IMHO) so it's safe to silently 
ignore it.


This is my first busybox modification ever, so please review the patch 
if it is correct! It should be.



Thank you


Tomas M
slax.org
diff -pur busybox-1.7.0.orig/util-linux/mount.c busybox-1.7.0/util-linux/mount.c
--- busybox-1.7.0.orig/util-linux/mount.c   2007-08-24 10:50:03.0 
+
+++ busybox-1.7.0/util-linux/mount.c2007-08-28 16:07:30.307887823 +
@@ -1554,7 +1554,7 @@ int mount_main(int argc, char **argv)
 
// Parse remaining options
 
-   opt = getopt32(argv, o:t:rwanfvs, opt_o, fstype);
+   opt = getopt32(argv, o:t:rwanfvsi, opt_o, fstype);
if (opt  0x1) append_mount_options(cmdopts, opt_o); // -o
//if (opt  0x2) // -t
if (opt  0x4) append_mount_options(cmdopts, ro); // -r
@@ -1564,6 +1564,7 @@ int mount_main(int argc, char **argv)
if (opt  0x40) USE_FEATURE_MTAB_SUPPORT(fakeIt = 1); // -f
//if (opt  0x80) // -v: verbose (ignore)
//if (opt  0x100) // -s: sloppy (ignore)
+   //if (opt  0x200) // -i: don't call mount.fstype (ignore)
argv += optind;
argc -= optind;
 
___
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox