[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-06 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053133#comment-17053133
 ] 

Rasmus Thomsen commented on XERCESC-2194:
-

https://github.com/apache/xerces-c/pull/8

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Assignee: Scott Cantor
>Priority: Major
> Fix For: 3.2.3
>
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-06 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053130#comment-17053130
 ] 

Rasmus Thomsen commented on XERCESC-2194:
-

So I just tested this on our Windows machine and it appears that 
SIZE_OF_SSIZE_T is an empty string, but somehow CMake still evaluates that as 
true (?). We're using CMake 3.12.1. I'll open a PR for it :)

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Assignee: Scott Cantor
>Priority: Major
> Fix For: 3.2.3
>
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-05 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052225#comment-17052225
 ] 

Rasmus Thomsen commented on XERCESC-2194:
-

Ah, sorry if it seemed otherwise but my proposed fix isn't tested yet - that 
was mostly what I read out of the CMake docs. I'll go ahead and test it 
tomorrow and submit a change if it works. Thanks for the help already! :)

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Assignee: Scott Cantor
>Priority: Major
> Fix For: 3.2.3
>
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Comment Edited] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-05 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052212#comment-17052212
 ] 

Rasmus Thomsen edited comment on XERCESC-2194 at 3/5/20, 2:58 PM:
--

According to [the CMake 
docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] 
it might be a better idea to use {code}HAVE_${TYPE}{code} in 
XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available:

{code}
-if(SIZEOF_SIZE_T)
+if(HAVE_SIZEOF_SIZE_T)
  set(XERCES_SIZE_T size_t)
  set(XERCES_SIZE_MAX SIZE_MAX)
else()
  set(XERCES_SIZE_T "unsigned long")
  set(XERCES_SIZE_MAX ULONG_MAX)
endif()
-if(SIZEOF_SSIZE_T)
+if(HAVE_SIZEOF_SSIZE_T)
  set(XERCES_SSIZE_T SIZEOF_SSIZE_T)
  set(XERCES_SSIZE_MAX SSIZE_MAX)
else()
  set(XERCES_SSIZE_T long)
  set(XERCES_SSIZE_MAX LONG_MAX)
endif()
{code}

Or something along those lines?


was (Author: cogitri):
According to [the CMake 
docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] 
it might be a better idea to use {code}HAVE_${TYPE}{code} in 
XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available:

{code}
-if(SIZEOF_SIZE_T)
+if(HAVE_SIZEOF_OFF_T)
  set(XERCES_SIZE_T size_t)
  set(XERCES_SIZE_MAX SIZE_MAX)
else()
  set(XERCES_SIZE_T "unsigned long")
  set(XERCES_SIZE_MAX ULONG_MAX)
endif()
-if(SIZEOF_SSIZE_T)
+if(HAVE_ssize_t)
  set(XERCES_SSIZE_T SIZEOF_SSIZE_T)
  set(XERCES_SSIZE_MAX SSIZE_MAX)
else()
  set(XERCES_SSIZE_T long)
  set(XERCES_SSIZE_MAX LONG_MAX)
endif()
{code}

Or something along those lines?

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Priority: Major
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Comment Edited] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-05 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052212#comment-17052212
 ] 

Rasmus Thomsen edited comment on XERCESC-2194 at 3/5/20, 2:58 PM:
--

According to [the CMake 
docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] 
it might be a better idea to use {code}HAVE_${TYPE}{code} in 
XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available:

{code}
-if(SIZEOF_SIZE_T)
+if(HAVE_SIZEOF_OFF_T)
  set(XERCES_SIZE_T size_t)
  set(XERCES_SIZE_MAX SIZE_MAX)
else()
  set(XERCES_SIZE_T "unsigned long")
  set(XERCES_SIZE_MAX ULONG_MAX)
endif()
-if(SIZEOF_SSIZE_T)
+if(HAVE_ssize_t)
  set(XERCES_SSIZE_T SIZEOF_SSIZE_T)
  set(XERCES_SSIZE_MAX SSIZE_MAX)
else()
  set(XERCES_SSIZE_T long)
  set(XERCES_SSIZE_MAX LONG_MAX)
endif()
{code}

Or something along those lines?


was (Author: cogitri):
According to [the CMake 
docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] 
it might be a better idea to use {code}HAVE_${TYPE}{code} in 
XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available:

{code:diff}
-if(SIZEOF_SIZE_T)
+if(HAVE_SIZEOF_OFF_T)
  set(XERCES_SIZE_T size_t)
  set(XERCES_SIZE_MAX SIZE_MAX)
else()
  set(XERCES_SIZE_T "unsigned long")
  set(XERCES_SIZE_MAX ULONG_MAX)
endif()
-if(SIZEOF_SSIZE_T)
+if(HAVE_ssize_t)
  set(XERCES_SSIZE_T SIZEOF_SSIZE_T)
  set(XERCES_SSIZE_MAX SSIZE_MAX)
else()
  set(XERCES_SSIZE_T long)
  set(XERCES_SSIZE_MAX LONG_MAX)
endif()
{code}

Or something along those lines?

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Priority: Major
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-05 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052212#comment-17052212
 ] 

Rasmus Thomsen commented on XERCESC-2194:
-

According to [the CMake 
docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] 
it might be a better idea to use {code}HAVE_${TYPE}{code} in 
XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available:

{code:diff}
-if(SIZEOF_SIZE_T)
+if(HAVE_SIZEOF_OFF_T)
  set(XERCES_SIZE_T size_t)
  set(XERCES_SIZE_MAX SIZE_MAX)
else()
  set(XERCES_SIZE_T "unsigned long")
  set(XERCES_SIZE_MAX ULONG_MAX)
endif()
-if(SIZEOF_SSIZE_T)
+if(HAVE_ssize_t)
  set(XERCES_SSIZE_T SIZEOF_SSIZE_T)
  set(XERCES_SSIZE_MAX SSIZE_MAX)
else()
  set(XERCES_SSIZE_T long)
  set(XERCES_SSIZE_MAX LONG_MAX)
endif()
{code}

Or something along those lines?

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Priority: Major
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-05 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052206#comment-17052206
 ] 

Rasmus Thomsen commented on XERCESC-2194:
-

Hm, CMake does check for ssize_t and recognizes that it's not available: 
{code}-- Check size of ssize_t - failed{code} but we still end up with ssize_t 
in our builds. We're building from the 3.2.2 Git tag. We use MSVC version 
19.14.26428.1

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Priority: Major
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Comment Edited] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-05 Thread Rasmus Thomsen (Jira)


[ 
https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052206#comment-17052206
 ] 

Rasmus Thomsen edited comment on XERCESC-2194 at 3/5/20, 2:52 PM:
--

Hm, CMake does check for ssize_t and recognizes that it's not available: 
{code}-- Check size of ssize_t - failed{code} but we still end up with ssize_t 
in the mentioned header in our builds. We're building from the 3.2.2 Git tag. 
We use MSVC version 19.14.26428.1


was (Author: cogitri):
Hm, CMake does check for ssize_t and recognizes that it's not available: 
{code}-- Check size of ssize_t - failed{code} but we still end up with ssize_t 
in our builds. We're building from the 3.2.2 Git tag. We use MSVC version 
19.14.26428.1

> Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
> --
>
> Key: XERCESC-2194
> URL: https://issues.apache.org/jira/browse/XERCESC-2194
> Project: Xerces-C++
>  Issue Type: Bug
>  Components: Build
>Affects Versions: 3.2.2
>Reporter: Rasmus Thomsen
>Priority: Major
>
> When including Xerces_autoconf_config.hpp on Windows the following error 
> messages:
>  
> {code:cpp}
> error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
> "default-int" wird von C++ nicht unterstützt.
> error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
> {code}
> (Sorry that these are in German - they translate to "Missing type specifier - 
> assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")
> Apparently ssize_t is a POSIX extension and as such isn't available in MSVC 
> (by default?)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org



[jira] [Created] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t

2020-03-05 Thread Rasmus Thomsen (Jira)
Rasmus Thomsen created XERCESC-2194:
---

 Summary: Including Xerces_autoconf_config.hpp on Windows fails due 
to undefined ssize_t
 Key: XERCESC-2194
 URL: https://issues.apache.org/jira/browse/XERCESC-2194
 Project: Xerces-C++
  Issue Type: Bug
  Components: Build
Affects Versions: 3.2.2
Reporter: Rasmus Thomsen


When including Xerces_autoconf_config.hpp on Windows the following error 
messages:

 
{code:cpp}
error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: 
"default-int" wird von C++ nicht unterstützt.
error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t"
{code}

(Sorry that these are in German - they translate to "Missing type specifier - 
assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t")

Apparently ssize_t is a POSIX extension and as such isn't available in MSVC (by 
default?)




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org