Re: [CAF] Bug in Framework::login -- no error processing?

[G. Matthew Rice]

Olaf Alders [EMAIL PROTECTED] writes:
 Eric was kind enough to supply a patch to fix this.  I've applied the  patch
 to my P4 workspace (caf-alders) and submitted it.  I've tested  it out and it
 does indeed fix the problem.  Is it too late to merge  this with the 0.27
 release?

Since it was mostly typo corrections and the code changes seem to have not
caused any concerns from people on the list, I have merged your changes into
the main codeline.  So, it'll show up on the next release.

TTYL,
-- 
g. matthew rice [EMAIL PROTECTED]   starnix, toronto, ontario, ca
phone: 647.722.5301 x242  gpg id: EF9AAD20
http://www.starnix.com  professional linux services  products
___
caf mailing list
caf@lpi.org
http://list.lpi.org/cgi-bin/mailman/listinfo/caf

Re: [CAF] Bug in Framework::login -- no error processing?

[Olaf Alders]

On 9-Feb-06, at 2:31 PM, Eric Lyons wrote:

Trying to debug why the Example code doesn't display errors on the  
login page, I traced into CGI::Application::Framework::login to find:




snip

and indeed, $errs is set correctly, but there's no use of this  
variable in the rest of the login subroutine.  I.e., %tmplvars  
never gets set with anything.

It would appear it needs something after:

   foreach my $hash ( $self-_login_tmpl_params() ) {
   while ( my ($key, $value) = each %$hash ) {
   $tmplvars{$key} = $value;
   }
   }

like:
while ( my($key,$value = each %$errs ) {
   $tmplvars{$key} = $value;
}




Eric was kind enough to supply a patch to fix this.  I've applied the  
patch to my P4 workspace (caf-alders) and submitted it.  I've tested  
it out and it does indeed fix the problem.  Is it too late to merge  
this with the 0.27 release?


O
--
Olaf Alders
[EMAIL PROTECTED]

http://www.vilerichard.com -- pop tunes
http://cdbaby.com/cd/vilerichard


___
caf mailing list
caf@lpi.org
http://list.lpi.org/cgi-bin/mailman/listinfo/caf