Re: [Cake] [PATCH net-next, v2 01/18] net/sched: sch_api: add helper for tc qdisc walker stats dump

[Toke Høiland-Jørgensen via Cake]

Zhengchao Shao  writes:

> The walk implementation of most qdisc class modules is basically the
> same. That is, the values of count and skip are checked first. If
> count is greater than or equal to skip, the registered fn function is
> executed. Otherwise, increase the value of count. So we can reconstruct
> them.
>
> Signed-off-by: Zhengchao Shao 
> ---
>  include/net/pkt_sched.h | 13 +
>  1 file changed, 13 insertions(+)
>
> diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h
> index 29f65632ebc5..243e8b0cb7ea 100644
> --- a/include/net/pkt_sched.h
> +++ b/include/net/pkt_sched.h
> @@ -222,4 +222,17 @@ static inline struct tc_skb_cb *tc_skb_cb(const struct 
> sk_buff *skb)
>   return cb;
>  }
>  
> +static inline bool tc_qdisc_stats_dump(struct Qdisc *sch,
> +struct qdisc_walker *arg,
> +unsigned long cl)
> +{
> + if (arg->count >= arg->skip && arg->fn(sch, cl, arg) < 0) {

Seems a bit confusing that tc_qdisc_stats_dump() reverses the order of
the 'cl' and 'arg' parameters relative to the callback?

-Toke

___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake

[Cake] Oct 2-6 wispa-apalooza conference in las vegas

[Dave Taht via Cake]

I am speaking (talking about rfc7567's demand for fq+aqm on
everything), moderating a panel, and haunting a booth or two, guitar
in hand, at this WISP-oriented conference. A lot of things I(we've)
been working on this past year are coming to a head here, everything
from coping with the broadband maps debacle, the FCC not taking ookla
or samknows latency under load data, and the $60B NTIA broadband fund
programs still not funding ipv6, to the new openwrt and mikrotik
releases, to seeing cake and fq_codel enter more ISP middleboxes via
preseem and libreqos. Anyone here going?

https://wispaevents.org/booth-map/

Rumor has it that at least one new PtMP WISP radio will have fq_codel
in it, in addition to the mikrotik, openwifi and ISPAPP stuff. There
are a bunch of other products there, when I went last time, that were
running "our stuff" (most didn't know it). It's not a hugely technical
conference, but in particular if you want to learn more than you ever
wanted to know about the current state of outdoor fixed wireless,
fiber, and legal stuff, very worth doing. And the food is good.

I like WISP folk a lot, the kind of ornery old-fashioned american
small businessfolk that get s**t done. In my case I'm going to try and
drum up a bit of business for "network tuneups" and custom openwrt
builds, in addition to getting a feel for the state of things in DC.

Bringing funnels.

-- 
FQ World Domination pending: https://blog.cerowrt.org/post/state_of_fq_codel/
Dave Täht CEO, TekLibre, LLC
___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake