Re: Review Request 123941: Get the example to show data
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123941/ --- (Updated May 30, 2015, 5:19 p.m.) Review request for Calligra and Jarosław Staniek. Changes --- Modified pluginmanager to have a legacyname and try to find a plugin by this method Render lines in reportview Fixed file names Repository: kreport Description --- Add class KReportView based on a cut down KexiReportView ... useful to library users Add class for example data Mod plugin manager to load using old names (buggy) PLug it all together Diffs (updated) - examples/CMakeLists.txt 17835962c87dfeec7b5976d0dff5bfd540fff904 examples/KReportExampleData.h PRE-CREATION examples/KReportExampleData.cpp PRE-CREATION examples/designerwindow.h 95866d24ea871cc85a0853520e829fca22a7bbe2 examples/designerwindow.cpp 6d0ceabe011395efb67a066947863d14d566bf67 examples/main.cpp e02759e5820885b146d45c0b17af668a79bf5ae3 examples/window.h 83405f59684bbfe2962725d129b071f7d3c4d1a9 examples/window.cpp 63863eb92faae08fe5830c699b99129503e65447 src/CMakeLists.txt 3928786dcee9072c772d5926264d66053dc81ef7 src/common/KoReportItemLine.cpp 460bfc1955697c3b72cb57bd013150a8473882e1 src/common/KoReportPluginManager.cpp 5746f75437ae11a9f92f8197985c767321d19a5d src/common/KoReportPluginManagerPrivate.h d1d2f1cdb3285ce80174d98965a38fe722531ad0 src/items/check/check.desktop 3e59b4bb5892e9df898d331ae18a64863d13e852 src/items/field/KoReportDesignerItemField.cpp bf7bbf0c22462ba0ce58f300720abd3f7e2b871f src/items/field/field.desktop 4b4fccff681cac00b8a02e787ada7b8d376c213f src/items/image/image.desktop c7efcf2d2ca56c3f47dc0719948f911472123acf src/items/label/label.desktop 62b05ef02a10cad0f86e89458d770ae86acaaab3 src/items/text/text.desktop 937b3438cf2db0c85fa4ac929f65471972f248a8 src/plugins/barcode/kreport_barcodeplugin.desktop 59c769e1c56270419fbcb3ecab161f20b0e3f815 src/plugins/maps/kreport_mapsplugin.desktop c2e09c0b56fc56a9b5cd056f086d36af0c9b1081 src/renderer/KReportView.h PRE-CREATION src/renderer/KReportView.cpp PRE-CREATION src/renderer/KoReportPreRenderer.cpp 86740bb9d1588c1e38ebd05cf06d8843d0e0bdb4 src/wrtembed/KoReportDesignerItemLine.cpp 57f20a7ac3099b4ccc216fdf736f87c8d1da2dd8 Diff: https://git.reviewboard.kde.org/r/123941/diff/ Testing --- http://imgur.com/mseuLA2 Thanks, Adam Pigg ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123942: Keep pointer to related Connection object in query so it can be used to find related tables
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123942/ --- (Updated May 30, 2015, 7:32 p.m.) Status -- This change has been marked as submitted. Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz. Changes --- Submitted with commit fd3942a3c5228acc224ac3afd4f0a4e83a56c16f by Jaroslaw Staniek to branch calligra/2.9. Bugs: 330410 http://bugs.kde.org/show_bug.cgi?id=330410 Repository: calligra Description --- Keep pointer to related Connection object in query, so it can be used to find related tables To do this, add a QuerySchema ctor and allow to call it internally by the parser. We had to move QuerySchemaPrivate to separate files. Diffs - libs/db/CMakeLists.txt 6de23f8bd2840c98623473781324b1ecd9e5fb56 libs/db/parser/sqlparser.h dde41990097f0f893b306e91a38220d12e942780 libs/db/parser/sqlparser.cpp 31713fbdbf4bb7e9c967842f6e5fd44f056bd770 libs/db/parser/sqlparser.y 12ab0180dcf161cd4760ca22871b48d0864b06be libs/db/queryschema.h 3da6837467bf602854bc6d033eee2dd70775ac22 libs/db/queryschema.cpp bb71f979c1af96222e941120dadf5431deb46cc6 libs/db/queryschema_p.h PRE-CREATION libs/db/queryschema_p.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123942/diff/ Testing --- Queries work as expected, changes only relate to the conn pointer Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/#review80989 --- libs/flake/KoGridData.h (line 27) https://git.reviewboard.kde.org/r/123955/#comment55470 Why is the QWidget needed here. Can you give the error message you had? Would be a QObject fix the problem too? libs/flake/KoPathPoint.cpp (line 31) https://git.reviewboard.kde.org/r/123955/#comment55471 Please don't comment out code. Just remove it if it no longer works. libs/flake/KoPathShape.cpp (line 54) https://git.reviewboard.kde.org/r/123955/#comment55472 Don't comment out code. Just remove it if it no longer works. - Thorsten Zachmann On May 30, 2015, 11:04 p.m., Nerdopolis Turfwalker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/ --- (Updated May 30, 2015, 11:04 p.m.) Review request for Calligra. Repository: calligra Description --- get calligra frameworks to compile with qt 5.5 Diffs - filters/words/mobi/MobiFile.cpp 00922b06f995e54e3cbc1d8fd23334626711163f libs/flake/KoGridData.h 19acb74dd69ba706d6ec26cdb394ba2840ad75d5 libs/flake/KoPathPoint.cpp 5ae455480075409d10db5cdb9d1b3692927346c2 libs/flake/KoPathShape.cpp b3d1d22038570519569bc70df96d7352669eace5 libs/widgetutils/KoProperties.cpp 24e0219079f76856ca00a4c7b576413785b528da Diff: https://git.reviewboard.kde.org/r/123955/diff/ Testing --- Compile with Release, and against QT 5.5 Thanks, Nerdopolis Turfwalker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123952: Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123952/ --- Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz. Bugs: 348203 http://bugs.kde.org/show_bug.cgi?id=348203 Repository: calligra Description --- Consistency: use ILIKE/NOT ILIKE operator instead of LIKE for PostgreSQL This fixes the issue PostgreSQL uses case-sensitive search for LIKE SQL operator, Kexi's default is case-insensitive The approach isn't generic enough for other expressions (the context of connection could be better) but it's already much better than ignoring differences between servers. Diffs - kexi/kexidb/drivers/pqxx/pqxxdriver.cpp 83f655c56a7d58c6f0aca87786261d0a6571345a kexi/plugins/queries/kexiquerydesignerguieditor.cpp 2943df6bef7a08312ff19deeb2a146f1da0f450b kexi/widget/tableview/kexicomboboxpopup.cpp 1a0e0eca61f881e638242197dc6cbeef8c69200a libs/db/connection.cpp af245efb17345f515cde3b4457f74e59a849077d libs/db/driver.cpp c1277a8993ced0ec7e4019fed990df8d4a0f5d5f libs/db/driver_p.h 4cdfb5bf051ba3888ffe96974eee19e18a22269c libs/db/expression.h a7b0410a6172c7cc662213f540497855a97501ee libs/db/expression.cpp 794732ea12830dfd09aac4cd0c16675e1ab6fedb libs/db/parser/parser_p.cpp 5f11f4ea8ce947bf3e4e9dfd97e5f259776fc90b Diff: https://git.reviewboard.kde.org/r/123952/diff/ Testing --- Queries work now for pgsql as for sqlite/mysql Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/ --- Review request for Calligra. Repository: calligra Description --- get calligra frameworks to compile with qt 5.5 Diffs - filters/words/mobi/MobiFile.cpp 00922b06f995e54e3cbc1d8fd23334626711163f libs/flake/KoGridData.h 19acb74dd69ba706d6ec26cdb394ba2840ad75d5 libs/flake/KoPathPoint.cpp 5ae455480075409d10db5cdb9d1b3692927346c2 libs/flake/KoPathShape.cpp b3d1d22038570519569bc70df96d7352669eace5 libs/widgetutils/KoProperties.cpp 24e0219079f76856ca00a4c7b576413785b528da Diff: https://git.reviewboard.kde.org/r/123955/diff/ Testing --- Compile with Release, and against QT 5.5 Thanks, Nerdopolis Turfwalker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » OSX,NoOpenGL,clang - Build # 18 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=OSX,Variation=NoOpenGL,compiler=clang/18/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » OSX,NoOpenGL,clang - Build # 19 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=OSX,Variation=NoOpenGL,compiler=clang/19/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » OSX,All,clang - Build # 19 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=OSX,Variation=All,compiler=clang/19/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » Linux,NoOpenGL,gcc - Build # 19 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc/19/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
merging master to frameworks
I'm doing a merge now... Boudewijn ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: merging master to frameworks
Done! On Sat, 30 May 2015, Boudewijn Rempt wrote: I'm doing a merge now... Boudewijn ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » OSX,All,clang - Build # 18 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=OSX,Variation=All,compiler=clang/18/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: 2.9.5 - are you ready?
Hi, Please send me your 2.9.5 change logs. Thanks. On 27 May 2015 at 11:20, Jaroslaw Staniek stan...@kde.org wrote: Hi again, 3 days left, so if you have or plan fixes it's good time to submit them. https://community.kde.org/Calligra/Schedules/2.9/Release_Plan#2.9.5 On 20 May 2015 at 23:45, Jaroslaw Staniek stan...@kde.org wrote: Hi, Actual plan for 2.9.5: - Tagging May 30th - Release June 3rd Comments? And how many 2.9.x releases would you see? -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » Linux,All,gcc - Build # 18 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/18/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » Linux,NoOpenGL,gcc - Build # 18 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc/18/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » Linux,All,gcc - Build # 19 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/19/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » Linux,NoOpenGL,gcc - Build # 20 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc/20/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » Linux,All,gcc - Build # 20 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/20/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123942: Keep pointer to related Connection object in query so it can be used to find related tables
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123942/#review80968 --- Ship it! Ship It! - Adam Pigg On May 30, 2015, 9:41 a.m., Jarosław Staniek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123942/ --- (Updated May 30, 2015, 9:41 a.m.) Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz. Bugs: 330410 http://bugs.kde.org/show_bug.cgi?id=330410 Repository: calligra Description --- Keep pointer to related Connection object in query, so it can be used to find related tables To do this, add a QuerySchema ctor and allow to call it internally by the parser. We had to move QuerySchemaPrivate to separate files. Diffs - libs/db/CMakeLists.txt 6de23f8bd2840c98623473781324b1ecd9e5fb56 libs/db/parser/sqlparser.h dde41990097f0f893b306e91a38220d12e942780 libs/db/parser/sqlparser.cpp 31713fbdbf4bb7e9c967842f6e5fd44f056bd770 libs/db/parser/sqlparser.y 12ab0180dcf161cd4760ca22871b48d0864b06be libs/db/queryschema.h 3da6837467bf602854bc6d033eee2dd70775ac22 libs/db/queryschema.cpp bb71f979c1af96222e941120dadf5431deb46cc6 libs/db/queryschema_p.h PRE-CREATION libs/db/queryschema_p.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123942/diff/ Testing --- Queries work as expected, changes only relate to the conn pointer Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » OSX,NoOpenGL,clang - Build # 20 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=OSX,Variation=NoOpenGL,compiler=clang/20/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra frameworks kf5-qt5 » OSX,All,clang - Build # 20 - Still Failing!
Check console output at https://build.kde.org/job/calligra%20frameworks%20kf5-qt5/PLATFORM=OSX,Variation=All,compiler=clang/20/ to view the results. ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123942: Keep pointer to related Connection object in query so it can be used to find related tables
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123942/ --- Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz. Bugs: 330410 http://bugs.kde.org/show_bug.cgi?id=330410 Repository: calligra Description --- Keep pointer to related Connection object in query, so it can be used to find related tables To do this, add a QuerySchema ctor and allow to call it internally by the parser. We had to move QuerySchemaPrivate to separate files. Diffs - libs/db/CMakeLists.txt 6de23f8bd2840c98623473781324b1ecd9e5fb56 libs/db/parser/sqlparser.h dde41990097f0f893b306e91a38220d12e942780 libs/db/parser/sqlparser.cpp 31713fbdbf4bb7e9c967842f6e5fd44f056bd770 libs/db/parser/sqlparser.y 12ab0180dcf161cd4760ca22871b48d0864b06be libs/db/queryschema.h 3da6837467bf602854bc6d033eee2dd70775ac22 libs/db/queryschema.cpp bb71f979c1af96222e941120dadf5431deb46cc6 libs/db/queryschema_p.h PRE-CREATION libs/db/queryschema_p.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123942/diff/ Testing --- Queries work as expected, changes only relate to the conn pointer Thanks, Jarosław Staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 123943: Port KoDocumentEntry::name() and mimeTypes() to KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123943/ --- Review request for Calligra. Repository: calligra Description --- Getting the data from QPluginLoader::metaData() which contains the entries from the desktop file. Diffs - libs/main/KoDocumentEntry.cpp f24a7ef Diff: https://git.reviewboard.kde.org/r/123943/diff/ Testing --- Verified name() output the Name entry value from the desktop file and mimeTypes() the MimeType entry value. Thanks, Peter Simonsson ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
