Jenkins-kde-ci: calligra calligra-2.9 latest-qt4 » Linux,All,gcc - Build # 18 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20latest-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/18/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 07:57:00 + Build duration: 49 min CHANGE SET Revision 4879c43fc0cbd9beff44eddd046fd79186831985 by boud: (CCBUG:352282 Wintab and Qt rects were passed the wrong way around) change: edit krita/ui/input/wintab/kis_tablet_support_win.cpp JUNIT RESULTS Name: (root) Failed: 26 test(s), Passed: 298 test(s), Skipped: 0 test(s), Total: 324 test(s)Failed: TestSuite.krita-image-KisAsyncMergerTestFailed: TestSuite.krita-image-KisCageTransformWorkerTestFailed: TestSuite.krita-image-KisCloneLayerTestFailed: TestSuite.krita-image-KisPerspectiveTransformWorkerTestFailed: TestSuite.krita-image-KisProcessingsTestFailed: TestSuite.krita-image-KisQueuesProgressUpdaterTestFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-image-KisTransformMaskTestFailed: TestSuite.krita-image-KisWalkersTestFailed: TestSuite.krita-image-LayerStylesTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-resourcemanager-ResourceBundleTestFailed: TestSuite.krita-ui-FillProcessingVisitorTestFailed: TestSuite.krita-ui-FilterStrokeTestFailed: TestSuite.krita-ui-KisActionManagerTestFailed: TestSuite.krita-ui-KisAslLayerStyleSerializerTestFailed: TestSuite.krita-ui-KisNodeManagerTestFailed: TestSuite.krita-ui-KisSelectionManagerTestFailed: TestSuite.krita-ui-KisZoomAndPanTestFailed: TestSuite.krita-ui-kis_shape_controller_testFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report By packages ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra master kf5-qt5 » Linux,All,gcc - Build # 38 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/38/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 04:16:42 + Build duration: 1 hr 0 min CHANGE SET Revision 6c3451bbd8478c5414ebfa3c1bbcd668c0de9d84 by miabraha: (Move debugging to KisTabletDebugger) change: edit krita/ui/input/kis_tablet_debugger.cpp change: edit krita/ui/input/kis_input_manager.cpp change: edit krita/ui/input/kis_shortcut_matcher.cpp change: edit krita/ui/input/kis_input_manager_p.cpp change: edit krita/ui/input/kis_tablet_debugger.h Revision 2f5fa0359b7ad4a09c801cce92eb6b23b35227c3 by miabraha: (Define tablet debug category) change: edit krita/main.cc change: edit krita/libglobal/kis_debug.h change: edit krita/libglobal/kis_debug.cpp change: edit krita/ui/input/kis_input_manager_p.cpp change: edit krita/ui/input/kis_tablet_debugger.h Revision d1ae79f74af2741bfd62ee0c6eeab09cff986117 by miabraha: (Debug tablet event buttons) change: edit krita/ui/input/kis_tablet_debugger.cpp Revision 2ddb2b51c0901d53e949d95b98d28ab9444742b9 by miabraha: (Rename mouseMoved() to cursorMoved()) change: edit krita/ui/input/kis_pan_action.h change: edit krita/ui/input/kis_zoom_action.cpp change: edit krita/ui/input/kis_rotate_canvas_action.h change: edit krita/ui/input/kis_gamma_exposure_action.cpp change: edit krita/ui/input/kis_gamma_exposure_action.h change: edit krita/ui/input/kis_zoom_action.h change: edit krita/ui/input/kis_input_manager.cpp change: edit krita/ui/input/kis_pan_action.cpp change: edit krita/ui/input/kis_abstract_input_action.h change: edit krita/ui/input/kis_abstract_input_action.cpp change: edit krita/ui/input/kis_rotate_canvas_action.cpp change: edit krita/ui/tests/kis_input_manager_test.cpp Revision c5953d30e7c1982dffa4c93c07371afff019b693 by miabraha: (Use eventPos() instead of casting to mouseEvent) change: edit krita/ui/input/kis_abstract_input_action.cpp change: edit krita/ui/input/kis_select_layer_action.cpp change: edit krita/ui/input/kis_zoom_action.cpp change: edit krita/ui/input/kis_change_primary_setting_action.cpp change: edit krita/ui/input/kis_alternate_invocation_action.cpp Revision 4d37faededc027d17a8cad29aaa743b5081a862b by miabraha: (KisShortcutMatcher interface accepts QEvents) change: edit krita/ui/input/kis_input_manager.cpp change: edit krita/ui/input/kis_shortcut_matcher.cpp change: edit krita/ui/input/kis_select_layer_action.cpp change: edit krita/ui/input/kis_input_manager_p.h change: edit krita/ui/input/kis_change_primary_setting_action.cpp change: edit krita/ui/input/kis_alternate_invocation_action.cpp change: edit krita/ui/canvas/kis_tool_proxy.cpp change: edit krita/ui/input/kis_shortcut_matcher.h Revision cddc2944af252e63b746baad71e42904d734a822 by miabraha: (Remove custom event filters and KisTabletEvent) change: edit krita/ui/input/kis_input_manager.cpp change: edit krita/ui/canvas/kis_canvas_controller.cpp change: edit krita/main.cc change: edit krita/ui/input/kis_input_manager_p.h change: edit krita/ui/input/kis_input_manager_p.cpp change: edit krita/ui/input/kis_tablet_debugger.cpp Revision 5f3934dff01849668fca2d1192498e63f4947962 by miabraha: (Sanitize KisInputManager::Private initialization) change: edit krita/ui/input/kis_input_manager.cpp change: edit krita/ui/input/kis_input_manager_p.h change: edit krita/ui/input/kis_input_manager_p.cpp Revision fd959957e24e4210e2b4a53c10e1fd3c097ce08a by miabraha: (Stop blocking events from touch) change: edit krita/ui/input/kis_input_manager_p.h change: edit krita/ui/input/kis_input_manager.cpp Revision c2843ec6a1a5059c1bdb9bed72ebf4c0d6fca992 by miabraha: (Accept and process tablet events by default) change: edit krita/ui/input/kis_alternate_invocation_action.cpp change: edit krita/ui/canvas/kis_tool_proxy.cpp change: edit krita/ui/input/kis_input_manager.h change: edit krita/ui/input/kis_input_manager.cpp change: edit krita/ui/input/kis_change_primary_setting_action.cpp change: edit krita/ui/canvas/kis_tool_proxy.h change: edit krita/ui/input/kis_tool_invocation_action.cpp change: edit krita/ui/input/kis_abstract_input_action.h change: edit krita/ui/canvas/kis_canvas_controller.cpp change: edit krita/ui/input/kis_input_manager_p.h change: edit krita/ui/input/kis_input_manager_p.cpp Revision 7c815f96f36273c54522b4e98a28302cb7a4d2fc by Friedrich W. H. Kossebau: (Port away from qtest_kde.h in filters) change: edit filters/sheets/xlsx/TestFormulaParser.cpp change: edit filters/sheets/xlsx/TestFormulaParser.h Revision 5202995b36e0eb519b26086b6c25787c948fcddd by Friedrich W. H. Kossebau: (Avoid QtTest include) change: edit filters/stage/powerpoint/tests/TestPPT.h change: edit filters/stage/powerpoint/tests/TestPPT.cpp Revision 1dddbcdbceab012ad2edf1a705b592b97f04952d by Friedrich W. H. Kossebau:
Re: Coding standard for qdebug in libs
On 5 September 2015 at 13:41, Boudewijn Remptwrote: > There is one more thing about logging using qCDebug and friends: > the logging categories are supposed to be defined _per library_. > > Which is actually pretty useless and not really how we've been > using categories in Calligra. Logging categories for file > handling, resource management or plugin handling that can be used > across libraries and applications make it possible to focus on > debugging a path through the application's execution. > > I don't debug pigment, I debug color management, for instance, which > is present in pigment, the colorspace plugin and parts of Krita. > > That's why for Krita, I made a generic debug interface in a little > global library that knows about all the categories and that can > be used from everywhere. Yeah that's OK too, case by case. Names for these cross-libs categories can be invented too. Similarly, for database-reladed stuff we even have a GUI logger: http://i.imgur.com/9bfljqF.png > Oe Sat, 5 Sep 2015, Jaroslaw Staniek wrote: > >> Hi, >> This is a proposal for some consistency for naming of debug functions, >> debug headers and logging categories. >> I'll be trying to achieve in code I maintain. I can put some >> guidelines on the dev wiki. >> >> Details: >> After looking at recent commits such as Friedrich's 1dddbcdbceab0 >> "kWarning -> warnPigment" I was wondering if we want to have standards >> for debug handling. >> I don't use one in Kexi, not yet, but use one in >> kdb/kreport/kproperty. With increasing modularity it's quite important >> for our debugging needs to have logging categories. >> >> A scheme could be like >> {libnamelowercase}{Debug|Warning|Critical}() >> >> e.g. I use kdbDebug() << ... ; >> >> Note, for clarity () is used here too like in qDebug(). >> See kdb_debug.h >> https://quickgit.kde.org/?p=kdb.git=blob=src%2Fkdb_debug.h >> >> Furthermore, in kde_debug.cpp >> [https://quickgit.kde.org/?p=kdb.git=blob=src%2Fkdb_debug.cpp] I >> have: >> Q_LOGGING_CATEGORY(KDB_LOG, "org.kde.kdb.core") >> >> Note that you can pick your scheme for string, e.g. >> org.kde.calligra.{someapp} or org.calligra.{someapp} >> and for libs org.kde.{somelib}. It's important to have it unique and >> relatively short. Planning for future expansion is a good way too. >> >> For tests and example apps it may be enough to use default debug or >> for big code decide to add special category too. >> >> I also propose to use a libname prefix for the header name. This is >> what many bits in KF5 do. So we won't have to deal with dozens files >> prefixed with "Debug" soon (so libpigment's DebugPigment.h could >> become PigmentDebug.h or pigment_debug.h). >> >> PS: I am aware e.g. KF5 has various approaches there, use qDebug() >> with no categories, use qCDebug without defines. >> We have not fully migrated to logging categories in apps and internal >> libs so I thought it may be cool to think about consistency early >> enough. >> >> -- >> regards, Jaroslaw Staniek >> >> KDE: >> : A world-wide network of software engineers, artists, writers, >> translators >> : and facilitators committed to Free Software development - http://kde.org >> Calligra Suite: >> : A graphic art and office suite - http://calligra.org >> Kexi: >> : A visual database apps builder - http://calligra.org/kexi >> Qt Certified Specialist: >> : http://www.linkedin.com/in/jstaniek >> ___ >> calligra-devel mailing list >> calligra-devel@kde.org >> https://mail.kde.org/mailman/listinfo/calligra-devel > > ___ > calligra-devel mailing list > calligra-devel@kde.org > https://mail.kde.org/mailman/listinfo/calligra-devel -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Coding standard for qdebug in libs
Hi, This is a proposal for some consistency for naming of debug functions, debug headers and logging categories. I'll be trying to achieve in code I maintain. I can put some guidelines on the dev wiki. Details: After looking at recent commits such as Friedrich's 1dddbcdbceab0 "kWarning -> warnPigment" I was wondering if we want to have standards for debug handling. I don't use one in Kexi, not yet, but use one in kdb/kreport/kproperty. With increasing modularity it's quite important for our debugging needs to have logging categories. A scheme could be like {libnamelowercase}{Debug|Warning|Critical}() e.g. I use kdbDebug() << ... ; Note, for clarity () is used here too like in qDebug(). See kdb_debug.h https://quickgit.kde.org/?p=kdb.git=blob=src%2Fkdb_debug.h Furthermore, in kde_debug.cpp [https://quickgit.kde.org/?p=kdb.git=blob=src%2Fkdb_debug.cpp] I have: Q_LOGGING_CATEGORY(KDB_LOG, "org.kde.kdb.core") Note that you can pick your scheme for string, e.g. org.kde.calligra.{someapp} or org.calligra.{someapp} and for libs org.kde.{somelib}. It's important to have it unique and relatively short. Planning for future expansion is a good way too. For tests and example apps it may be enough to use default debug or for big code decide to add special category too. I also propose to use a libname prefix for the header name. This is what many bits in KF5 do. So we won't have to deal with dozens files prefixed with "Debug" soon (so libpigment's DebugPigment.h could become PigmentDebug.h or pigment_debug.h). PS: I am aware e.g. KF5 has various approaches there, use qDebug() with no categories, use qCDebug without defines. We have not fully migrated to logging categories in apps and internal libs so I thought it may be cool to think about consistency early enough. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 232 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/232/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 09:19:57 + Build duration: 50 min CHANGE SET Revision fd50c144aeb1ee878b05b0841f3d26fcdb1a5eca by boud: (Add some more debug info about screens) change: edit krita/ui/input/wintab/kis_tablet_support_win.cpp JUNIT RESULTS Name: (root) Failed: 25 test(s), Passed: 299 test(s), Skipped: 0 test(s), Total: 324 test(s)Failed: TestSuite.krita-image-KisAsyncMergerTestFailed: TestSuite.krita-image-KisCageTransformWorkerTestFailed: TestSuite.krita-image-KisPerspectiveTransformWorkerTestFailed: TestSuite.krita-image-KisProcessingsTestFailed: TestSuite.krita-image-KisQueuesProgressUpdaterTestFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-image-KisTransformMaskTestFailed: TestSuite.krita-image-KisWalkersTestFailed: TestSuite.krita-image-LayerStylesTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-resourcemanager-ResourceBundleTestFailed: TestSuite.krita-ui-FillProcessingVisitorTestFailed: TestSuite.krita-ui-FilterStrokeTestFailed: TestSuite.krita-ui-KisActionManagerTestFailed: TestSuite.krita-ui-KisAslLayerStyleSerializerTestFailed: TestSuite.krita-ui-KisNodeManagerTestFailed: TestSuite.krita-ui-KisSelectionManagerTestFailed: TestSuite.krita-ui-KisZoomAndPanTestFailed: TestSuite.krita-ui-kis_shape_controller_testFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report By packages ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Coding standard for qdebug in libs
There is one more thing about logging using qCDebug and friends: the logging categories are supposed to be defined _per library_. Which is actually pretty useless and not really how we've been using categories in Calligra. Logging categories for file handling, resource management or plugin handling that can be used across libraries and applications make it possible to focus on debugging a path through the application's execution. I don't debug pigment, I debug color management, for instance, which is present in pigment, the colorspace plugin and parts of Krita. That's why for Krita, I made a generic debug interface in a little global library that knows about all the categories and that can be used from everywhere. Boudewijn Oe Sat, 5 Sep 2015, Jaroslaw Staniek wrote: Hi, This is a proposal for some consistency for naming of debug functions, debug headers and logging categories. I'll be trying to achieve in code I maintain. I can put some guidelines on the dev wiki. Details: After looking at recent commits such as Friedrich's 1dddbcdbceab0 "kWarning -> warnPigment" I was wondering if we want to have standards for debug handling. I don't use one in Kexi, not yet, but use one in kdb/kreport/kproperty. With increasing modularity it's quite important for our debugging needs to have logging categories. A scheme could be like {libnamelowercase}{Debug|Warning|Critical}() e.g. I use kdbDebug() << ... ; Note, for clarity () is used here too like in qDebug(). See kdb_debug.h https://quickgit.kde.org/?p=kdb.git=blob=src%2Fkdb_debug.h Furthermore, in kde_debug.cpp [https://quickgit.kde.org/?p=kdb.git=blob=src%2Fkdb_debug.cpp] I have: Q_LOGGING_CATEGORY(KDB_LOG, "org.kde.kdb.core") Note that you can pick your scheme for string, e.g. org.kde.calligra.{someapp} or org.calligra.{someapp} and for libs org.kde.{somelib}. It's important to have it unique and relatively short. Planning for future expansion is a good way too. For tests and example apps it may be enough to use default debug or for big code decide to add special category too. I also propose to use a libname prefix for the header name. This is what many bits in KF5 do. So we won't have to deal with dozens files prefixed with "Debug" soon (so libpigment's DebugPigment.h could become PigmentDebug.h or pigment_debug.h). PS: I am aware e.g. KF5 has various approaches there, use qDebug() with no categories, use qCDebug without defines. We have not fully migrated to logging categories in apps and internal libs so I thought it may be cool to think about consistency early enough. -- regards, Jaroslaw Staniek KDE: : A world-wide network of software engineers, artists, writers, translators : and facilitators committed to Free Software development - http://kde.org Calligra Suite: : A graphic art and office suite - http://calligra.org Kexi: : A visual database apps builder - http://calligra.org/kexi Qt Certified Specialist: : http://www.linkedin.com/in/jstaniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 231 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/231/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 07:57:00 + Build duration: 49 min CHANGE SET Revision 4879c43fc0cbd9beff44eddd046fd79186831985 by boud: (CCBUG:352282 Wintab and Qt rects were passed the wrong way around) change: edit krita/ui/input/wintab/kis_tablet_support_win.cpp JUNIT RESULTS Name: (root) Failed: 24 test(s), Passed: 300 test(s), Skipped: 0 test(s), Total: 324 test(s)Failed: TestSuite.krita-image-KisAsyncMergerTestFailed: TestSuite.krita-image-KisCageTransformWorkerTestFailed: TestSuite.krita-image-KisPerspectiveTransformWorkerTestFailed: TestSuite.krita-image-KisProcessingsTestFailed: TestSuite.krita-image-KisQueuesProgressUpdaterTestFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-image-KisTransformMaskTestFailed: TestSuite.krita-image-KisWalkersTestFailed: TestSuite.krita-image-LayerStylesTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-resourcemanager-ResourceBundleTestFailed: TestSuite.krita-ui-FillProcessingVisitorTestFailed: TestSuite.krita-ui-FilterStrokeTestFailed: TestSuite.krita-ui-KisActionManagerTestFailed: TestSuite.krita-ui-KisAslLayerStyleSerializerTestFailed: TestSuite.krita-ui-KisNodeManagerTestFailed: TestSuite.krita-ui-KisSelectionManagerTestFailed: TestSuite.krita-ui-KisZoomAndPanTestFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report By packages ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra calligra-2.9 latest-qt4 » Linux,All,gcc - Build # 20 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20latest-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/20/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 14:18:16 + Build duration: 53 min CHANGE SET Revision 94948703fbc768849d3cac757a857908d9614de9 by boud: (BUG:352283 Enable the anti-aliasing option for contiguous selection) change: edit krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc Revision fdab38817c1ae599293427411bde2042e5802e48 by boud: (BUG:352261 Dont crash in the box filter when scaling down to small) change: edit krita/image/kis_filter_weights_applicator.h Revision b08e61d64264832497e12d9aa32d4ec3c25daf4c by boud: (Fix a crash in the painting assistants with certain files.) change: edit krita/ui/kis_painting_assistants_decoration.cpp Revision a00e72de21c205610bfb4cbe68a050395179e477 by boud: (whitespace fixes) change: edit krita/ui/widgets/kis_advanced_color_space_selector.cc Revision 5bd1de6cbf791964cb980f294c0b57ad5a7c3e00 by boud: (BUG:352253 Resize the color selector triangles cache) change: edit krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp change: edit krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.h Revision b3ffd41016439fee2d33719a9af97b89c05cb5ee by boud: (BUG:352238 Re-enable the color picker in the palette docker) change: edit krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.h change: edit krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.cpp JUNIT RESULTS Name: (root) Failed: 25 test(s), Passed: 299 test(s), Skipped: 0 test(s), Total: 324 test(s)Failed: TestSuite.krita-image-KisAsyncMergerTestFailed: TestSuite.krita-image-KisCageTransformWorkerTestFailed: TestSuite.krita-image-KisPerspectiveTransformWorkerTestFailed: TestSuite.krita-image-KisProcessingsTestFailed: TestSuite.krita-image-KisQueuesProgressUpdaterTestFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-image-KisTransformMaskTestFailed: TestSuite.krita-image-KisWalkersTestFailed: TestSuite.krita-image-LayerStylesTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-resourcemanager-ResourceBundleTestFailed: TestSuite.krita-ui-FillProcessingVisitorTestFailed: TestSuite.krita-ui-FilterStrokeTestFailed: TestSuite.krita-ui-KisActionManagerTestFailed: TestSuite.krita-ui-KisAslLayerStyleSerializerTestFailed: TestSuite.krita-ui-KisNodeManagerTestFailed: TestSuite.krita-ui-KisSelectionManagerTestFailed: TestSuite.krita-ui-KisZoomAndPanTestFailed: TestSuite.krita-ui-kis_shape_controller_testFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report By packages ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 234 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/234/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 16:14:28 + Build duration: 51 min CHANGE SET Revision a00e72de21c205610bfb4cbe68a050395179e477 by boud: (whitespace fixes) change: edit krita/ui/widgets/kis_advanced_color_space_selector.cc Revision 5bd1de6cbf791964cb980f294c0b57ad5a7c3e00 by boud: (BUG:352253 Resize the color selector triangles cache) change: edit krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.h change: edit krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp Revision b3ffd41016439fee2d33719a9af97b89c05cb5ee by boud: (BUG:352238 Re-enable the color picker in the palette docker) change: edit krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.h change: edit krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.cpp JUNIT RESULTS Name: (root) Failed: 25 test(s), Passed: 299 test(s), Skipped: 0 test(s), Total: 324 test(s)Failed: TestSuite.krita-image-KisAsyncMergerTestFailed: TestSuite.krita-image-KisCageTransformWorkerTestFailed: TestSuite.krita-image-KisPerspectiveTransformWorkerTestFailed: TestSuite.krita-image-KisProcessingsTestFailed: TestSuite.krita-image-KisQueuesProgressUpdaterTestFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-image-KisTransformMaskTestFailed: TestSuite.krita-image-KisWalkersTestFailed: TestSuite.krita-image-LayerStylesTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-resourcemanager-ResourceBundleTestFailed: TestSuite.krita-ui-FillProcessingVisitorTestFailed: TestSuite.krita-ui-FilterStrokeTestFailed: TestSuite.krita-ui-KisActionManagerTestFailed: TestSuite.krita-ui-KisAslLayerStyleSerializerTestFailed: TestSuite.krita-ui-KisNodeManagerTestFailed: TestSuite.krita-ui-KisSelectionManagerTestFailed: TestSuite.krita-ui-KisZoomAndPanTestFailed: TestSuite.krita-ui-kis_shape_controller_testFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report By packages ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123955/ --- (Updated Sept. 5, 2015, 9:58 p.m.) Status -- This change has been discarded. Review request for Calligra. Repository: calligra Description --- get calligra frameworks to compile with qt 5.5 Diffs - filters/words/mobi/MobiFile.cpp 00922b06f995e54e3cbc1d8fd23334626711163f libs/flake/KoGridData.h 19acb74dd69ba706d6ec26cdb394ba2840ad75d5 libs/flake/KoPathPoint.cpp 5ae455480075409d10db5cdb9d1b3692927346c2 libs/flake/KoPathShape.cpp b3d1d22038570519569bc70df96d7352669eace5 libs/widgetutils/KoProperties.cpp 24e0219079f76856ca00a4c7b576413785b528da Diff: https://git.reviewboard.kde.org/r/123955/diff/ Testing --- Compile with Release, and against QT 5.5 Thanks, Nerdopolis Turfwalker ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra calligra-2.9 stable-qt4 » Linux,All,gcc - Build # 233 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/233/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 11:36:46 + Build duration: 51 min CHANGE SET Revision 7919b948bbc4ec28c3e7cc201cd9ab39adfaa8f9 by boud: (Put the general options in tabs) change: edit krita/ui/forms/wdggeneralsettings.ui Revision 94948703fbc768849d3cac757a857908d9614de9 by boud: (BUG:352283 Enable the anti-aliasing option for contiguous selection) change: edit krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc Revision fdab38817c1ae599293427411bde2042e5802e48 by boud: (BUG:352261 Dont crash in the box filter when scaling down to small) change: edit krita/image/kis_filter_weights_applicator.h Revision b08e61d64264832497e12d9aa32d4ec3c25daf4c by boud: (Fix a crash in the painting assistants with certain files.) change: edit krita/ui/kis_painting_assistants_decoration.cpp JUNIT RESULTS Name: (root) Failed: 24 test(s), Passed: 300 test(s), Skipped: 0 test(s), Total: 324 test(s)Failed: TestSuite.krita-image-KisAsyncMergerTestFailed: TestSuite.krita-image-KisCageTransformWorkerTestFailed: TestSuite.krita-image-KisPerspectiveTransformWorkerTestFailed: TestSuite.krita-image-KisProcessingsTestFailed: TestSuite.krita-image-KisQueuesProgressUpdaterTestFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-image-KisTransformMaskTestFailed: TestSuite.krita-image-KisWalkersTestFailed: TestSuite.krita-image-LayerStylesTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-resourcemanager-ResourceBundleTestFailed: TestSuite.krita-ui-FillProcessingVisitorTestFailed: TestSuite.krita-ui-FilterStrokeTestFailed: TestSuite.krita-ui-KisActionManagerTestFailed: TestSuite.krita-ui-KisAslLayerStyleSerializerTestFailed: TestSuite.krita-ui-KisNodeManagerTestFailed: TestSuite.krita-ui-KisSelectionManagerTestFailed: TestSuite.krita-ui-KisZoomAndPanTestFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report By packages ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra calligra-2.9 latest-qt4 » Linux,All,gcc - Build # 19 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20calligra-2.9%20latest-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/19/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 10:27:39 + Build duration: 54 min CHANGE SET Revision fd50c144aeb1ee878b05b0841f3d26fcdb1a5eca by boud: (Add some more debug info about screens) change: edit krita/ui/input/wintab/kis_tablet_support_win.cpp Revision 7919b948bbc4ec28c3e7cc201cd9ab39adfaa8f9 by boud: (Put the general options in tabs) change: edit krita/ui/forms/wdggeneralsettings.ui JUNIT RESULTS Name: (root) Failed: 26 test(s), Passed: 298 test(s), Skipped: 0 test(s), Total: 324 test(s)Failed: TestSuite.krita-image-KisAsyncMergerTestFailed: TestSuite.krita-image-KisCageTransformWorkerTestFailed: TestSuite.krita-image-KisCloneLayerTestFailed: TestSuite.krita-image-KisPerspectiveTransformWorkerTestFailed: TestSuite.krita-image-KisProcessingsTestFailed: TestSuite.krita-image-KisQueuesProgressUpdaterTestFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-image-KisTransformMaskTestFailed: TestSuite.krita-image-KisWalkersTestFailed: TestSuite.krita-image-LayerStylesTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-resourcemanager-ResourceBundleTestFailed: TestSuite.krita-ui-FillProcessingVisitorTestFailed: TestSuite.krita-ui-FilterStrokeTestFailed: TestSuite.krita-ui-KisActionManagerTestFailed: TestSuite.krita-ui-KisAslLayerStyleSerializerTestFailed: TestSuite.krita-ui-KisNodeManagerTestFailed: TestSuite.krita-ui-KisSelectionManagerTestFailed: TestSuite.krita-ui-KisZoomAndPanTestFailed: TestSuite.krita-ui-kis_shape_controller_testFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report By packages ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Jenkins-kde-ci: calligra master kf5-qt5 » Linux,All,gcc - Build # 41 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/41/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 20:36:13 + Build duration: 1 hr 2 min CHANGE SET Revision e48214cfea5b187a9ffadeaee69ef0586b6b6853 by Friedrich W. H. Kossebau: (Remove unused formatting methods from DOC imports WordsGraphicsHandler) change: edit filters/words/msword-odf/graphicshandler.cpp JUNIT RESULTS Name: (root) Failed: 18 test(s), Passed: 174 test(s), Skipped: 0 test(s), Total: 192 test(s)Failed: TestSuite.Plan-RCPSTesterFailed: TestSuite.Plan-TJ-SchedulerTesterFailed: TestSuite.Plan-TJTesterFailed: TestSuite.Plan-WorkPackageProxyModelTesterFailed: TestSuite.kchart-TestLoading-bug239802Failed: TestSuite.kformula-LoadAndSaveFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-ui-MoveStrokeTestFailed: TestSuite.libs-flake-TestImageCollectionFailed: TestSuite.libs-kotext-TestBorderFailed: TestSuite.libs-kotext-styles-TestStyleManagerFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report PACKAGES 260/302 (86%)FILES 2199/4511 (49%)CLASSES 2199/4511 (49%)LINE 116261/432346 (27%)CONDITIONAL 100074/175572 (57%) By packages FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/12 (0%)CONDITIONAL 0/0 (100%) devtools.rng2cpp FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 639/742 (86%)CONDITIONAL 568/654 (87%) filters.libmso FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 881/7700 (11%)CONDITIONAL 2319/3980 (58%) filters.libmso.generated FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 4205/11203 (38%)CONDITIONAL 5061/9234 (55%) filters.libmsooxml FILES 2/34 (6%)CLASSES 2/34 (6%)LINE 3/8064 (0%)CONDITIONAL 2/4 (50%) filters.libmsooxml.generated FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/743 (0%)CONDITIONAL 0/0 (100%) filters.libodf2 FILES 6/28 (21%)CLASSES 6/28 (21%)LINE 97/1629 (6%)CONDITIONAL 86/172 (50%) filters.libodf2.chart FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/582 (0%)CONDITIONAL 0/0 (100%) filters.sheets.excel.sidewinder FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 695/726 (96%)CONDITIONAL 2175/3864 (56%) filters.sheets.xlsx FILES 4/5 (80%)CLASSES 4/5 (80%)LINE 111/276 (40%)CONDITIONAL 85/170 (50%) filters.stage.powerpoint FILES 8/9 (89%)CLASSES 8/9 (89%)LINE 1653/2693 (61%)CONDITIONAL 2284/3994 (57%) filters.stage.powerpoint.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 55/57 (96%)CONDITIONAL 104/206 (50%) interfaces FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/63 (86%)CONDITIONAL 29/49 (59%) karbon.common FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/153 (0%)CONDITIONAL 0/0 (100%) karbon.common.commands FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/65 (0%)CONDITIONAL 0/0 (100%) karbon.plugins.stencilbox FILES 3/12 (25%)CLASSES 3/12 (25%)LINE 9/531 (2%)CONDITIONAL 1/2 (50%) karbon.plugins.tools FILES 4/10 (40%)CLASSES 4/10 (40%)LINE 24/1162 (2%)CONDITIONAL 1/2 (50%) karbon.plugins.tools.CalligraphyTool FILES 3/8 (38%)CLASSES 3/8 (38%)LINE 17/1023 (2%)CONDITIONAL 2/4 (50%) karbon.plugins.tools.filterEffectTool FILES 2/18 (11%)CLASSES 2/18 (11%)LINE 10/1311 (1%)CONDITIONAL 2/4 (50%) karbon.ui FILES 1/10 (10%)CLASSES 1/10 (10%)LINE 2/1566 (0%)CONDITIONAL 2/4 (50%) karbon.ui.commands FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/29 (0%)CONDITIONAL 0/0 (100%) karbon.ui.dialogs FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/59 (0%)CONDITIONAL 0/0 (100%) karbon.ui.dockers FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/613 (0%)CONDITIONAL 0/0 (100%) karbon.ui.widgets FILES 1/9 (11%)CLASSES 1/9 (11%)LINE 2/1190 (0%)CONDITIONAL 2/4 (50%) kexi.core FILES 27/55 (49%)CLASSES 27/55 (49%)LINE 951/4253 (22%)CONDITIONAL 350/602 (58%) kexi.kexiutils FILES 8/29 (28%)CLASSES 8/29 (28%)LINE 209/2464 (8%)CONDITIONAL 90/128 (70%) kexi.kexiutils.completer FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 482/871 (55%)CONDITIONAL 254/396 (64%) kexi.kexiutils.completer.private FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 2/4 (50%)CONDITIONAL 0/0 (100%) kexi.main FILES 6/15 (40%)CLASSES
Jenkins-kde-ci: calligra master kf5-qt5 » Linux,All,gcc - Build # 40 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/calligra%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/40/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Sep 2015 13:04:48 + Build duration: 1 hr 4 min CHANGE SET Revision 015238235e1a7fdf21a5905d1d957655bdc587c9 by boud: (BUG:352283 Enable the anti-aliasing option for contiguous selection) change: edit krita/plugins/tools/selectiontools/kis_tool_select_contiguous.cc Revision 0554bdb9d760e597be6ec51746624ca4cc8a2773 by boud: (BUG:352261 Dont crash in the box filter when scaling down to small) change: edit krita/image/kis_filter_weights_applicator.h Revision d4a330da0f03810f18a136b49ce54d19657ba945 by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit kexi/kexi.desktop change: edit kexi/plugins/forms/widgets/mapbrowser/kexiforms_mapwidgetplugin.desktop change: edit kexi/plugins/forms/kexi_formplugin.desktop change: edit kexi/plugins/queries/kexi_queryplugin.desktop change: edit kexi/plugins/forms/widgets/webbrowser/kexiforms_webbrowserwidgetplugin.desktop change: edit kexi/plugins/forms/kexiforms_dbwidgetsplugin.desktop change: edit kexi/plugins/tables/kexi_tableplugin.desktop change: edit kexi/plugins/importexport/csv/kexi_csvimportexportplugin.desktop change: edit kexi/plugins/reports/kexi_reportplugin.desktop change: edit karbon/plugins/stencilbox/karbon_stencilbox.desktop change: edit kexi/formeditor/factories/kexiforms_standardwidgetsplugin.desktop change: edit kexi/formeditor/widgetfactory.desktop Revision c236a802358b643445cac9356cf42fa926ef7519 by Jarosław Staniek: (Formatting handled by the Client (since a2aa539a6) so format() and mm()) change: edit filters/libmso/writer.cpp Revision 752285c9152a7a211b652ad7d17396bd8c7bb9f3 by Jarosław Staniek: (GIT_SILENT Not needed include) change: edit filters/libmso/writer.cpp Revision ef47a739ac4de6d005af55c331ec976fc082e791 by boud: (BUG:352253 Resize the color selector triangles cache) change: edit krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp change: edit krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.h Revision 5e1bf2969e92e4c4d0f85f2e30edd6b2ef56bb5c by boud: (BUG:352238 Re-enable the color picker in the palette docker) change: edit krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.cpp change: edit krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.h JUNIT RESULTS Name: (root) Failed: 18 test(s), Passed: 174 test(s), Skipped: 0 test(s), Total: 192 test(s)Failed: TestSuite.Plan-RCPSTesterFailed: TestSuite.Plan-TJ-SchedulerTesterFailed: TestSuite.Plan-TJTesterFailed: TestSuite.Plan-WorkPackageProxyModelTesterFailed: TestSuite.kchart-TestLoading-bug239802Failed: TestSuite.kformula-LoadAndSaveFailed: TestSuite.krita-image-KisStoreLimitsTestFailed: TestSuite.krita-paintop-EmbeddedPatternManagerTestFailed: TestSuite.krita-plugin-format-jpeg_testFailed: TestSuite.krita-plugins-formats-psd_testFailed: TestSuite.krita-ui-MoveStrokeTestFailed: TestSuite.libs-flake-TestImageCollectionFailed: TestSuite.libs-kotext-TestBorderFailed: TestSuite.libs-kotext-styles-TestStyleManagerFailed: TestSuite.libs-textlayout-TestBlockLayoutFailed: TestSuite.sheets-CellFailed: TestSuite.sheets-DatetimeFunctionsFailed: TestSuite.sheets-InformationFunctions COBERTURA RESULTS Cobertura Coverage Report PACKAGES 260/302 (86%)FILES 2199/4511 (49%)CLASSES 2199/4511 (49%)LINE 116263/432347 (27%)CONDITIONAL 100075/175572 (57%) By packages FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/12 (0%)CONDITIONAL 0/0 (100%) devtools.rng2cpp FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 639/742 (86%)CONDITIONAL 568/654 (87%) filters.libmso FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 881/7700 (11%)CONDITIONAL 2319/3980 (58%) filters.libmso.generated FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 4205/11203 (38%)CONDITIONAL 5061/9234 (55%) filters.libmsooxml FILES 2/34 (6%)CLASSES 2/34 (6%)LINE 3/8064 (0%)CONDITIONAL 2/4 (50%) filters.libmsooxml.generated FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/743 (0%)CONDITIONAL 0/0 (100%) filters.libodf2 FILES 6/28 (21%)CLASSES 6/28 (21%)LINE 97/1629 (6%)CONDITIONAL 86/172 (50%) filters.libodf2.chart FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/582 (0%)CONDITIONAL 0/0 (100%) filters.sheets.excel.sidewinder FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 695/726 (96%)CONDITIONAL 2175/3864 (56%) filters.sheets.xlsx FILES 4/5 (80%)CLASSES 4/5 (80%)LINE 111/276 (40%)CONDITIONAL 85/170 (50%) filters.stage.powerpoint FILES 8/9 (89%)CLASSES 8/9 (89%)LINE 1653/2693 (61%)CONDITIONAL 2284/3994 (57%)