[Differential] [Commented On] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

2016-03-27 Thread Jarosław Staniek 
staniek added a comment.


  In https://phabricator.kde.org/D1032#23331, @aspotashev wrote:
  
  > Looks good to me.
  >
  > P.S.  We probably need to share the kundo2 library between Kexi, Krita and 
Calligra.
  
  
  Thanks Alexander. Yes, this, or we would replace with Qt5 if there's 
equivalent. Research on that is still a TODO.

REPOSITORY
  rCALLIGRA Calligra

REVISION DETAIL
  https://phabricator.kde.org/D1032

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, kossebau, rempt, boemann, aspotashev
Cc: Calligra-Devel-list, staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[Differential] [Closed] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

2016-03-27 Thread Jarosław Staniek 
This revision was automatically updated to reflect the committed changes.
Closed by commit rCALLIGRA68ac8207a9cf: Make KUndo2Stack::push return false if 
the command was merged (and deleted)… (authored by staniek).

REPOSITORY
  rCALLIGRA Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1032?vs=2484=2977

REVISION DETAIL
  https://phabricator.kde.org/D1032

AFFECTED FILES
  libs/kundo2/kundo2stack.cpp
  libs/kundo2/kundo2stack.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, kossebau, rempt, boemann, aspotashev
Cc: Calligra-Devel-list, staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 127371: Support selections in Calligra ODT plugin for Okular (main textflow-only for now)

2016-03-27 Thread Friedrich W. H. Kossebau 


> On March 18, 2016, 7:54 p.m., Camilla Boemann wrote:
> > In general my reservations is the same as you explain - an entire method 
> > just to enable a plugin
> > 
> > in theory it would be possible to use selectionRect but I conceede it would 
> > be really un-economical

I so hoped you had a better idea :) Too bad then.
At least the code is isolated and does not interfer with other code, so if we 
hopefully one day can discard it again due to native selection possible it 
could be simply dropped again without any problems.


> On March 18, 2016, 7:54 p.m., Camilla Boemann wrote:
> > libs/textlayout/KoTextLayoutEndNotesArea.h, line 48
> > 
> >
> > apidox pls since it's use is so specific

Added a longer APIDOX comment to KoTextLayoutArea::generateCharAreaInfos() 
where also all other area methods have all their comments.


> On March 18, 2016, 7:54 p.m., Camilla Boemann wrote:
> > libs/textlayout/KoTextLayoutTableArea.cpp, line 287
> > 
> >
> > because for painting we want to repeat the headers on every page :)

But isn't that ensured by the separate loops for the header rows and the 
`firstRow` calculation?
I just had another look, and now even less than before grasp what both 
`testRow` and `visitedCells` are supposed to do in the end.
Need to catch you on irc to teach me :)
So keeping this TODO for now and doing with commit including it, as something 
here either is fishy or needs better documentation for newbies like me :)


- Friedrich W. H.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127371/#review93691
---


On March 18, 2016, 12:56 a.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127371/
> ---
> 
> (Updated March 18, 2016, 12:56 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> A first approach to collect chars and their positions on a given page, as 
> needed by Okular.
> 
> I followed the logic used for painting, as that one also needs to calculate 
> what content is part of a certain page, so copying the algorithm seemed most 
> obvious for a start.
> 
> Disadvantage: This approach needs access to internal data of the area 
> objects, so I had to add the code to the actual *Area classes. So they now 
> carry logic for a currently single use-case, which also is not the most 
> typical. Surely not a lot of code, but ideally this special need for the 
> Okular plugin should not add its payload for everyone.
> 
> So looking for better ideas here, at least for later.
> 
> TODOs for the future:
> - text from master pages (headers/footers)
> - text in objects (floating text boxes, diagrams, whatever)
> - include header/paragraph numbering/bullet points
> - only add line-breaks for real paragraph ends perhaps
> 
> Please give this some first round of feedback. IMHO it already adds value, as 
> it finally allows to copy text from the main textflow.
> So would not mind to have this as-is for 3.0, to be improved than at least 
> later, if not before. Unless it is unacceptable for good reasons :)
> 
> In a perfect future Okular´s plugin API will allow native selections, so all 
> the knowledge about text flow is not lost. But for now we have to support the 
> API which exists.
> 
> (Short note: I will not be able to instantly reply, currently seeing to 
> replace broken IT, might take another week at least, no email or irc for now. 
> This patch here was already uploaded before things turned defunct locally, so 
> pushing it out now for review at least).
> 
> 
> Diffs
> -
> 
>   extras/okularodtgenerator/OkularOdtGenerator.h c4404c4 
>   extras/okularodtgenerator/OkularOdtGenerator.cpp d1d428d 
>   libs/textlayout/KoCharAreaInfo.h PRE-CREATION 
>   libs/textlayout/KoTextLayoutArea.h 27934d7 
>   libs/textlayout/KoTextLayoutArea.cpp bacfa58 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 6c1eb12 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp 2c1e241 
>   libs/textlayout/KoTextLayoutTableArea.h 8d912ee 
>   libs/textlayout/KoTextLayoutTableArea.cpp 4d2cdc1 
> 
> Diff: https://git.reviewboard.kde.org/r/127371/diff/
> 
> 
> Testing
> ---
> 
> Normal text, text in tables, text in generated content, footnotes & endnotes 
> could be selected in the ODT (& DOC/DOCX/WPD) files I tried.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[Differential] [Accepted] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed

2016-03-27 Thread aspotashev (Alexander Potashev) 
aspotashev accepted this revision.
aspotashev added a comment.
This revision is now accepted and ready to land.


  Looks good to me.
  
  P.S.  We probably need to share the kundo2 library between Kexi, Krita and 
Calligra.

REPOSITORY
  rCALLIGRA Calligra

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1032

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, kossebau, rempt, boemann, aspotashev
Cc: Calligra-Devel-list, staniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel