D17352: Made descriptions for DEC2BIN/OCT2BIN/HEX2DEC/HEX2BIN mention input number system
aspotashev added a comment. Please add the bug report ID to the commit message, see for example: https://cgit.kde.org/calligra.git/commit/?id=f1e95f48e44ed548b41ab855432cb57d9c79eee9 REPOSITORY R8 Calligra BRANCH conversion-function-descriptions-mention-input-system (branched from master) REVISION DETAIL https://phabricator.kde.org/D17352 To: niccolove, aspotashev Cc: aspotashev, Calligra-Devel-list, dcaliste, cochise, vandenoever
D17352: Made descriptions for DEC2BIN/OCT2BIN/HEX2DEC/HEX2BIN mention input number system
aspotashev accepted this revision. aspotashev added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R8 Calligra BRANCH conversion-function-descriptions-mention-input-system (branched from master) REVISION DETAIL https://phabricator.kde.org/D17352 To: niccolove, aspotashev Cc: aspotashev, Calligra-Devel-list, dcaliste, cochise, vandenoever
Re: calligra release planned for 04-12-2016
2016-11-26 17:12 GMT+03:00 Dag <dand...@get2net.dk>: > Hi Albert. > Found the "syntax error" in the calligra part we releases now, the rest is > in kexi. > It seems either xgettext chokes on a long context or (more likely) > calligra_xgettext.sh chokes on the msg xgettext produces. Shorting the msg > by 1 character did the trick. > > But: it seems calligra_xgettext.sh adds (qtundo-format) to (almost?) all > messages, effectively doubling the amount of messages wether they are > undo/redo msg or not! > No way to tell which are phony though :( calligra_xgettext.sh should extract the qtundo messages into one .pot file, then extract the non-qtundo messages into another .pot file and finally merge these .pot files together. Because it extracts different (zero-intersection) sets of messages, no messages are duplicated in the final .pot file. -- Alexander Potashev
Re: Test tarballs available for 3.0.0-pre-beta1 of KDb/KProperty/KReport and proposed release schedule
2016-09-05 18:03 GMT+03:00 Jaroslaw Staniek <stan...@kde.org>: > Dear All, > Background blog entry: > https://blogs.kde.org/2016/09/04/kdb-3-kproperty-3-kreport-3-kexi-3-and-special-offer-during-akademy > > 1. If someone is interested in building, first versions of tarballs > for KDb/KProperty/KReport 3.0.0-pre-beta1. > > https://drive.google.com/folderview?id=0B0o42yCJezrDNTVfRklJY2JxVDg=sharing > > They have been created using kde:releaseme and contain translations. > This task is formulated at https://phabricator.kde.org/T3592 - you can > watch it if you want. > > Order of building: KProperty before KReport as KReport depends on KProperty. > Pretty standard cmake building process, it will guide you when you > miss dependencies. > Feel free to also enable examples, tests and run the tests. > > Kexi tarball would join there probably today. > All code is currently from master git branches, tags are called like x.y.z. > As you can see, unlike for KF5, versions of the tarballs are't > necessarily synced. This reflects fact that we're reserving right to > release any of them separately as long as declared compatibilities are > assured. > > 2. Proposed release schedule: all the frameworks and Kexi in one day. > Opinion is welcome here. > > - string freeze: Monday Sep 12 > - beta1 release: Monday Sep 19 Please CC kde-i18n-doc when schedule is final. -- Alexander Potashev
[Differential] [Accepted] D1032: Make KUndo2Stack::push return false if the command was merged (and deleted) rather than pushed
aspotashev accepted this revision. aspotashev added a comment. This revision is now accepted and ready to land. Looks good to me. P.S. We probably need to share the kundo2 library between Kexi, Krita and Calligra. REPOSITORY rCALLIGRA Calligra BRANCH master REVISION DETAIL https://phabricator.kde.org/D1032 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt, boemann, aspotashev Cc: Calligra-Devel-list, staniek ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 124257: advancedcolorselector: Fix UI layout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124257/ --- (Updated Июль 5, 2015, 12:04 п.п.) Status -- This change has been marked as submitted. Review request for Calligra and Scott Petrovic. Repository: calligra Description --- CCMAIL: scottpetro...@gmail.com Diffs - krita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui b9e2411fb07b2f5516739208612dd32762d72699 Diff: https://git.reviewboard.kde.org/r/124257/diff/ Testing --- Layout is stretchable. Thanks, Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request 124257: advancedcolorselector: Fix UI layout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124257/ --- Review request for Calligra and Scott Petrovic. Repository: calligra Description --- CCMAIL: scottpetro...@gmail.com Diffs - krita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui b9e2411fb07b2f5516739208612dd32762d72699 Diff: https://git.reviewboard.kde.org/r/124257/diff/ Testing --- Layout is stretchable. Thanks, Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request 124257: advancedcolorselector: Fix UI layout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124257/ --- (Updated Июль 5, 2015, 2:13 д.п.) Review request for Calligra and Scott Petrovic. Changes --- reorder groupboxes Repository: calligra Description --- CCMAIL: scottpetro...@gmail.com Diffs (updated) - krita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui b9e2411fb07b2f5516739208612dd32762d72699 Diff: https://git.reviewboard.kde.org/r/124257/diff/ Testing --- Layout is stretchable. Thanks, Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: GPL Linking exception or transformation to LGPL?
2015-06-15 9:44 GMT+03:00 Jaroslaw Staniek stan...@kde.org: - as Jos has said unless the code is distributed, no changes have (even in GPL) to be published; we're not using AGPL Hi everyone, I also did not get why AGPL was mentioned. This following applies here: http://www.gnu.org/licenses/gpl-faq.en.html#UnreleasedMods (Or you can read the GPLv2 license and easily come to the same conclusion.) -- Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: GPL Linking exception or transformation to LGPL?
2015-06-15 9:52 GMT+03:00 Jos van den Oever jos.van.den.oe...@kogmbh.com: On 06/15/2015 08:44 AM, Jaroslaw Staniek wrote: Hi Christophe, I find it awesome. As history shows our contribution model is largely based on such cases. Several things: - as Jos has said unless the code is distributed, no changes have (even in GPL) to be published; we're not using AGPL - architectural: to encourage reuse we need to have a library, could you list the files you're using? - practical: if you list files that you need we can collect list of persons that own the copyright The list was attached to the previous mail. The paths are all in relative to the sheets/ directory. The files contain copyrights like this: Copyright (C) 1998-2002 The KSpread Team calligra-devel@kde.org Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). for f in $(cat /tmp/files.txt |cut -f 1 -d ' '); do grep copyright -i $f; done|sort|uniq Hi Jos, More importantly, _all_ the files listed in files.txt are under GNU Library GPL v2 only: This library is free software; you can redistribute it and/or modify it under the terms of the GNU Library General Public License as published by the Free Software Foundation; only version 2 of the License. Does this mean we cannot relicense under e.g. LGPLv2.1? -- Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Committing kundo2 patches tomorrow
2011/6/25 Jaroslaw Staniek stan...@kde.org: Hi, Kudos for this contribution but is KUndo2 tested at all, especially with Kexi? Isn't there a clear infinite recursion at kundo2stack.cpp:1065 and 1084? That's clearly my mistake, sorry. Fixed in master, but in a different way than you suggested. I probably didn't test Kexi with kundo2, I don't remember exactly. But now I tested Kexi and I couldn't reproduce the crash due to stack overflow (well, I made Kexi crash in 20 seconds, but it has nothing to do with recursion). -- Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Add libkundo2 to Calligra
On June 25, 2011, 7:54 p.m., Jarosław Staniek wrote:
Hi, please consider adding this patch to avoid infinite recursion. Needed
at least on g++ is (SUSE Linux) 4.5.0 20100604 [gcc-4_5-branch revision
160292].
diff --git a/libs/kundo2/kundo2stack.cpp b/libs/kundo2/kundo2stack.cpp
index 6af1d05..658df1f 100644
--- a/libs/kundo2/kundo2stack.cpp
+++ b/libs/kundo2/kundo2stack.cpp
@@ -1062,7 +1062,7 @@ bool KUndo2QStack::isActive() const
QAction* KUndo2QStack::createRedoAction(KActionCollection*
actionCollection, const QString actionName)
{
-QAction* action = createRedoAction(actionCollection);
+QAction* action =
createRedoAction(static_castQObject*(actionCollection));
if(actionName.isEmpty()) {
action-setObjectName(KStandardAction::name(KStandardAction::Redo));
@@ -1081,7 +1081,7 @@ QAction*
KUndo2QStack::createRedoAction(KActionCollection* actionCollection, con
QAction* KUndo2QStack::createUndoAction(KActionCollection*
actionCollection, const QString actionName)
{
-QAction* action = createUndoAction(actionCollection);
+QAction* action =
createUndoAction(static_castQObject*(actionCollection));
if(actionName.isEmpty()) {
action-setObjectName(KStandardAction::name(KStandardAction::Undo));
Fixed differently in master branch.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101414/#review4158
---
On May 22, 2011, 12:17 p.m., Alexander Potashev wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101414/
---
(Updated May 22, 2011, 12:17 p.m.)
Review request for Calligra.
Summary
---
kundo2 is a fork of Qt's Undo Framework (QUndoStack, QUndoView, ...).
It contains two bugfixes the are going to be available only in Qt 4.8:
https://qt.gitorious.org/qt/qt/merge_requests/1212
https://qt.gitorious.org/qt/qt/merge_requests/2610
To start using kundo2, one should port Calligra to it. This can be done
by adding target_link_libraries(... kundo2) into CMakeLists.txt files
for all modules from Calligra that use Qt Undo Framework, and by
switching from QUndo classes to KUndo2 classes.
(switching to KUndo2 classes can easily be done by using a script)
Script for forward and backward porting:
https://github.com/aspotashev/libkundo2/blob/master/port-kundo2.sh
After Calligra starts requiring Qt 4.8+, this library can be removed,
because it has no advantages over Qt's Undo Framework 4.8.
Diffs
-
libs/CMakeLists.txt 6179f0a
libs/kundo2/CMakeLists.txt PRE-CREATION
libs/kundo2/kundo2_export.h PRE-CREATION
libs/kundo2/kundo2command.h PRE-CREATION
libs/kundo2/kundo2group.h PRE-CREATION
libs/kundo2/kundo2group.cpp PRE-CREATION
libs/kundo2/kundo2model.h PRE-CREATION
libs/kundo2/kundo2model.cpp PRE-CREATION
libs/kundo2/kundo2qstack.h PRE-CREATION
libs/kundo2/kundo2stack.h PRE-CREATION
libs/kundo2/kundo2stack.cpp PRE-CREATION
libs/kundo2/kundo2stack_p.h PRE-CREATION
libs/kundo2/kundo2view.h PRE-CREATION
libs/kundo2/kundo2view.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101414/diff
Testing
---
It compiles.
Thanks,
Alexander
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Committing kundo2 patches tomorrow
Pushed. 2011/6/20 Alexander Potashev aspotas...@gmail.com: Hi, I'm going to commit the following 3 patches tomorrow, they will add kundo2 library and make the whole Calligra use it: 1. https://git.reviewboard.kde.org/r/101414/ (add kundo2 library) 2. https://git.reviewboard.kde.org/r/101415/ (link Calligra to kundo2) 3. https://git.reviewboard.kde.org/r/101416/ (port all Calligra code to use kundo2) The third patch involves ~1700 lines, so you may expect conflicts when you merge your branches to master. If you are going to commit some huge changes to master soon, you might want me to defer pushing of the above patches in order to avoid hundreds of conflicts. I will probably even need to regenerate the third patch tomorrow to avoid conflicts with changes that will happen in master during the next hours. The third patch can be generated by running the script https://github.com/aspotashev/libkundo2/blob/master/port-kundo2.sh with argument forward. Backward porting can be done by using the same script with argument backward. In short, kundo2 is needed to make localization of undo actions more flexible until Qt 4.8 is released. When Calligra dependencies will be raised to Qt 4.8, we can drop kundo2 and switch back to Qt Undo Framework. -- Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Committing kundo2 patches tomorrow
Hi, I'm going to commit the following 3 patches tomorrow, they will add kundo2 library and make the whole Calligra use it: 1. https://git.reviewboard.kde.org/r/101414/ (add kundo2 library) 2. https://git.reviewboard.kde.org/r/101415/ (link Calligra to kundo2) 3. https://git.reviewboard.kde.org/r/101416/ (port all Calligra code to use kundo2) The third patch involves ~1700 lines, so you may expect conflicts when you merge your branches to master. If you are going to commit some huge changes to master soon, you might want me to defer pushing of the above patches in order to avoid hundreds of conflicts. I will probably even need to regenerate the third patch tomorrow to avoid conflicts with changes that will happen in master during the next hours. The third patch can be generated by running the script https://github.com/aspotashev/libkundo2/blob/master/port-kundo2.sh with argument forward. Backward porting can be done by using the same script with argument backward. In short, kundo2 is needed to make localization of undo actions more flexible until Qt 4.8 is released. When Calligra dependencies will be raised to Qt 4.8, we can drop kundo2 and switch back to Qt Undo Framework. -- Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Review Request: Add target_link_libraries(... kundo2) to CMakeLists.txt files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101415/ --- (Updated June 18, 2011, 4:11 p.m.) Review request for Calligra. Changes --- Reduced number of target_link_libraries(... kundo2) by using LINK_INTERFACE_LIBRARIES. Summary --- Add target_link_libraries(... kundo2) to CMakeLists.txt files of all modules of Calligra that use Qt's Undo Framework. Requires https://git.reviewboard.kde.org/r/101414/ Diffs (updated) - kplato/libs/kernel/CMakeLists.txt 6dc30b1 kplato/libs/models/CMakeLists.txt ad9f50c libs/flake/CMakeLists.txt 4d41250 Diff: http://git.reviewboard.kde.org/r/101415/diff Testing --- This cannot possibly break anything. Of course, if you have already applied https://git.reviewboard.kde.org/r/101414/ Thanks, Alexander ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Review Request: Add target_link_libraries(... kundo2) to CMakeLists.txt files
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101415/ --- Review request for Calligra. Summary --- Add target_link_libraries(... kundo2) to CMakeLists.txt files of all modules of Calligra that use Qt's Undo Framework. Requires https://git.reviewboard.kde.org/r/101414/ Diffs - braindump/plugins/stateshape/CMakeLists.txt 72c38eb braindump/plugins/webshape/CMakeLists.txt 5234f63 karbon/common/CMakeLists.txt e940d9f karbon/plugins/flattenpath/CMakeLists.txt f83620b karbon/plugins/refinepath/CMakeLists.txt caf6aa7 karbon/plugins/roundcorners/CMakeLists.txt 82b7159 karbon/plugins/tools/CMakeLists.txt 7e4aeb6 karbon/plugins/whirlpinch/CMakeLists.txt 2e920e2 karbon/ui/CMakeLists.txt 0773216 kexi/formeditor/CMakeLists.txt 0f48560 kexi/plugins/forms/CMakeLists.txt 8d9c2d8 kformula/CMakeLists.txt 8f46594 kformula/flake/CMakeLists.txt 5b3b7bc kplato/CMakeLists.txt 605535f kplato/libs/kernel/CMakeLists.txt 6dc30b1 kplato/libs/models/CMakeLists.txt ad9f50c kplato/libs/ui/CMakeLists.txt 6d64c1c kplato/workpackage/CMakeLists.txt b9ef576 kpresenter/part/CMakeLists.txt a2b01ee kpresenter/plugins/eventactions/CMakeLists.txt e4810cd krita/image/CMakeLists.txt 47d13c3 krita/plugins/extensions/dockers/historydocker/CMakeLists.txt 513dae3 krita/plugins/tools/tool_transform2/CMakeLists.txt fe93230 krita/ui/CMakeLists.txt 517adb6 libs/flake/CMakeLists.txt c2164b7 libs/kopageapp/CMakeLists.txt 4cdf024 libs/kopageapp/tools/backgroundTool/CMakeLists.txt ba1ddc3 libs/kotext/CMakeLists.txt bacba79 libs/main/CMakeLists.txt 55a71a3 libs/textlayout/CMakeLists.txt 4fb35c5 plugins/artistictextshape/CMakeLists.txt 638edac plugins/chartshape/CMakeLists.txt 2daccfc plugins/defaultTools/CMakeLists.txt 6c7f138 plugins/musicshape/CMakeLists.txt 3fa3d87 plugins/pathshapes/CMakeLists.txt e773367 plugins/pictureshape/CMakeLists.txt 373c589 plugins/textshape/CMakeLists.txt a583a2a plugins/treeshape/CMakeLists.txt da0917d plugins/vectorshape/CMakeLists.txt b629e7f plugins/videoshape/CMakeLists.txt 697ed5b tables/CMakeLists.txt a6445ba tools/koabstraction/CMakeLists.txt f9b3882 words/part/CMakeLists.txt dd3b917 Diff: http://git.reviewboard.kde.org/r/101415/diff Testing --- This cannot possibly break anything. Of course, if you have already applied https://git.reviewboard.kde.org/r/101414/ Thanks, Alexander ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
Re: Usage of libkundo2 in Calligra (Qt's maximal dependency)
2011/5/16 Boudewijn Rempt b...@valdyas.org: Yes, I agree that that is the way to go. We want nicely translatable undo messages. Ok, now I'm going to clean things up and create a review request. Will you take on the maintenance and so on? I can't guarantee that I'll be available (i.e. online) during the next months. But it must be very easy to revert the dependency on libkundo2. I actually think that it will make sense for us to start depending on Qt 4.8 as soon as it's packaged by most distributions (and meego) since it fixes a lot of bugs. Other applications like Step and Kig will wait for Qt 4.8, because nobody uses them. ;) Aw, I'm not so sure about that -- but they can use the same strategy for now, right? Yes, but KDE SC 4.7 is in feature and dependency freeze already. It still can be done if you convince people that it's just bugfixing, but not a new feature ;) But still it don't really care about Step and Kig, and will unlikely spend time on them. -- Alexander Potashev ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
