T12815: Create Calligra Framework by separating out applications and libraries

[Damien Caliste]

dcaliste added a comment.


  As a nobody, my opinion on the rightfullness to split or not the repository 
is of no interest. But what I like in the proposition of @leinir is the target 
to separate the "engine" from the UI (_i.e._ the widgetery). As an example 
(hopefully not outdated), the "find" classes, the one to search and replace, 
are deeply liked to the widgets that control them. It makes it impossible to 
reuse these class in a UI different from the original one.
  
  Separating the repositories is a way to enforce this engine _vs._ UI design. 
But it can also be achieved in the monolithic repo, by removing the 
dependencies to `kowidgets` in the CMakeLists for instance. I would be happy to 
join any task that would goes in that direction.

TASK DETAIL
  https://phabricator.kde.org/T12815

To: dcaliste
Cc: dcaliste, boemann, pino, rjvbb, ngraham, ognarb, Calligra-Devel-list, 
#calligra:_3.0, leinir, davidllewellynjones, cochise, vandenoever

D26050: Fix build with poppler 82

[Damien Caliste]

dcaliste added a comment.


  I like the idea of trying to move away from the monolythic release. Not that 
my opinion matters much, but I'm willing to help in the endeavor. I'll try to 
participate in tasks in that direction as much as my free time will allow it.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D26050

To: tcanabrava, #calligra:_3.0
Cc: dcaliste, leinir, asturmlechner, ognarb, anthonyfieroni, 
Calligra-Devel-list, davidllewellynjones, cochise, vandenoever

D25715: Use RTF default color as default Qt format

[Damien Caliste]

dcaliste added a comment.


  @pvuorela as you prefer, anyway, it's a question of taste, I find it myself 
easier to follow if the information is on one variable only. But your solution 
is good also, the file is small and is kept small so easy to follow.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25715

To: pvuorela, davidllewellynjones, dcaliste
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25715: Use RTF default color as default Qt format

[Damien Caliste]

dcaliste added a comment.


  Just a suggestion to avoid adding a variable which meaning may be redundant 
with the state of an already existing one. Otherwise LGTM.

INLINE COMMENTS

> ColorTableDestination.cpp:26
>  ColorTableDestination::ColorTableDestination( Reader *reader, 
> AbstractRtfOutput *output, const QString  ) :
> -  Destination( reader, output, name )
> +  Destination( reader, output, name ), m_currentColor(Qt::black), 
> m_colorSet(false)
>  {

We let the initialisation by default m_currentColor(QColor())

> ColorTableDestination.cpp:37
>   if ( controlWord == "red" ) {
>   m_currentColor.setRed( value );
>   } else if (controlWord == "green" ) {

Before setting the red value, we add:

  if (! m_currentColor.isValid())
m_currentColor = QColor::Black;

To avoid uninitialised values in other channels.

> ColorTableDestination.cpp:39
>   } else if (controlWord == "green" ) {
>   m_currentColor.setGreen( value );
>   } else if (controlWord == "blue" ) {

The same for blue and green.

> ColorTableDestination.cpp:54
>   if ( plainText == ";" ) {
> - m_output->appendToColourTable( m_currentColor );
> + m_output->appendToColourTable( m_colorSet ?  m_currentColor : 
> QColor() );
>   resetCurrentColor();

Here we pass m_currentColor, inconditionaly, since the invalid status is 
equivalent to the flag being false.

> ColorTableDestination.cpp:63
>  {
>   m_currentColor = Qt::black;
> + m_colorSet = false;

And finally, we reset to QColor(), instead of black.

> ColorTableDestination.h:45
>   QColor m_currentColor;
> + bool m_colorSet;
>};

I'm wondering, if we could use the invalid status of QColor as this flag ?

See later…

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25715

To: pvuorela, davidllewellynjones, dcaliste
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, cochise, 
vandenoever

D25008: Add XLSX spreadsheets import optimisations for small/readonly devices

[Damien Caliste]

dcaliste added a comment.


  @davidllewellynjones, I hadn't time yet to test the patch, but the idea and 
implementation is already looking great in my opinion. Maybe, just one remark 
after looking at the proposed additions: not saving the formale, but the values 
should not be named read-only. Indeed, maybe in the future, we would like to be 
able to "inspect" the content of a cell, even on portable devices. Being able 
to read the formulae should then be possible, even if not for modification. I 
may suggest the following naming changes (functionality to load by values to 
help loading time is great) :
  
  - MSOOXML_IMPORT_READ_ONLY -> MSOOXML_IMPORT_BY_VALUES or 
MSOOXML_IMPORT_VALUES_ONLY
  - MSOOXML::readonlySpreadsheet() -> MSOOXML::byValuesSpreadsheet() or 
MSOOXML::valuesOnlySpreadsheet()

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D25008

To: davidllewellynjones, #calligra:_3.0, pvuorela, dcaliste
Cc: Calligra-Devel-list, davidllewellynjones, dcaliste, cochise, vandenoever

D24831: Migrate csv plugins from kdebug to qdebug

[Damien Caliste]

dcaliste accepted this revision.
dcaliste added a comment.
This revision is now accepted and ready to land.


  The patch looks fine, thank you.

REPOSITORY
  R8 Calligra

BRANCH
  csv_qdebug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24831

To: pvuorela, dcaliste, leinir
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D24761: Asign correct column width when importing XLS file

[Damien Caliste]

dcaliste added a comment.


  Well, after reading the difference between the logical and physical DPI 
values: 
https://stackoverflow.com/questions/16561879/what-is-the-difference-between-logicaldpix-and-physicaldpix-in-qt
 (see the first answer), using the logical value is consistent with the hard 
coded "arial 10" font metric some line above.
  
  Maybe adding a comment near the modified line explaining that logicalDPI 
should be used because of the "Arial 10" font metric being nice also on high 
DPI screen would be nice. If not too much burden…
  
  Good catch @davidllewellynjones !

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D24761

To: davidllewellynjones, #calligra:_3.0, pvuorela
Cc: dcaliste, davidllewellynjones, Calligra-Devel-list, cochise, vandenoever

D23492: Correct anchor detection in QML components.

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:f0f0eedf1e74: Correct anchor detection in QML components. 
(authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23492?vs=65201=65245

REVISION DETAIL
  https://phabricator.kde.org/D23492

AFFECTED FILES
  components/impl/PresentationImpl.cpp
  components/impl/SpreadsheetImpl.cpp
  components/impl/TextDocumentImpl.cpp

To: dcaliste, leinir, pvuorela, danders, boemann
Cc: Calligra-Devel-list, #calligra:_3.0, dcaliste, cochise, vandenoever

D23679: Correct anchor detection in QML components.

[Damien Caliste]

dcaliste abandoned this revision.
dcaliste added a comment.


  Sorry, made a mistake with arc… This differential revision  is already D23492 
.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D23679

To: dcaliste
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D23679: Correct anchor detection in QML components.

[Damien Caliste]

dcaliste created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REPOSITORY
  R8 Calligra

BRANCH
  anchors

REVISION DETAIL
  https://phabricator.kde.org/D23679

AFFECTED FILES
  components/impl/PresentationImpl.cpp
  components/impl/SpreadsheetImpl.cpp
  components/impl/TextDocumentImpl.cpp

To: dcaliste
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D23492: Correct anchor detection in QML components.

[Damien Caliste]

dcaliste updated this revision to Diff 65201.
dcaliste added a comment.


  Thank you pvuorela pointing out other places for this construct. I've updated 
the patch with a fix for the faulty loops for spreadsheets and presentations 
also.

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23492?vs=64739=65201

REVISION DETAIL
  https://phabricator.kde.org/D23492

AFFECTED FILES
  components/impl/PresentationImpl.cpp
  components/impl/SpreadsheetImpl.cpp
  components/impl/TextDocumentImpl.cpp

To: dcaliste, leinir, pvuorela, danders, boemann
Cc: Calligra-Devel-list, #calligra:_3.0, dcaliste, cochise, vandenoever

D23492: Correct anchor detection in QML components.

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, pvuorela, danders, boemann.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  The loop to translate the anchor shape position in TextDocumentImpl was 
mis-written, always testing shape's parent, instead of parent's parent. This 
was creating an infinite loop in case an email address was present in a table 
for instance.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D23492

AFFECTED FILES
  components/impl/TextDocumentImpl.cpp

To: dcaliste, leinir, pvuorela, danders, boemann
Cc: Calligra-Devel-list, #calligra:_3.0, dcaliste, cochise, vandenoever

D19941: Avoid deprecated setSupportedDragActions

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:4f304e579fce: Avoid deprecated setSupportedDragActions 
(authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19941?vs=54483=54844

REVISION DETAIL
  https://phabricator.kde.org/D19941

AFFECTED FILES
  plugins/dockers/shapecollection/CollectionItemModel.cpp
  plugins/dockers/shapecollection/CollectionItemModel.h

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19760: Support Qt <5.7 on KoShape flag usage

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:b08a4bac940d: Support Qt 5.7 on KoShape flag usage 
(authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19760?vs=53886=54841

REVISION DETAIL
  https://phabricator.kde.org/D19760

AFFECTED FILES
  libs/flake/KoShape.cpp

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19973: MsooXmlCommonRead: protect member for double free

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:c06c5e01455f: MsooXmlCommonRead: protect member for double 
free (authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19973?vs=54555=54845

REVISION DETAIL
  https://phabricator.kde.org/D19973

AFFECTED FILES
  filters/libmsooxml/MsooXmlCommonReader.cpp
  filters/libmsooxml/MsooXmlCommonReaderImpl.h

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19885: Implement logging category for excel plugins

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:5e9da957f156: Implement logging category for excel plugins 
(authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19885?vs=54337=54839

REVISION DETAIL
  https://phabricator.kde.org/D19885

AFFECTED FILES
  filters/sheets/excel/sidewinder/chartsubstreamhandler.cpp
  filters/sheets/excel/sidewinder/excel.cpp
  filters/sheets/excel/sidewinder/formulas.cpp
  filters/sheets/excel/sidewinder/globalssubstreamhandler.cpp
  filters/sheets/excel/sidewinder/objects.cpp
  filters/sheets/excel/sidewinder/utils.cpp
  filters/sheets/excel/sidewinder/utils.h
  filters/sheets/excel/sidewinder/worksheetsubstreamhandler.cpp
  filters/sheets/excel/sidewinder/xmltk.h

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:b29f7aa31c5e: Avoid deprecated QAbstractItemModel::reset() 
(authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19884?vs=54322=54840

REVISION DETAIL
  https://phabricator.kde.org/D19884

AFFECTED FILES
  plugins/textshape/TextDocumentStructureModel.cpp

To: pvuorela, danders
Cc: danders, dcaliste, Calligra-Devel-list, cochise, vandenoever

D19912: Implement logging category for rtf-qt

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:85b57f2e64bb: Implement logging category for rtf-qt 
(authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19912?vs=54405=54838

REVISION DETAIL
  https://phabricator.kde.org/D19912

AFFECTED FILES
  filters/words/rtf/import/3rdparty/rtf-qt/src/CMakeLists.txt
  filters/words/rtf/import/3rdparty/rtf-qt/src/ColorTableDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Destination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/DocumentDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/FontTableDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/InfoDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/InfoTimeDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/PcdataDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/PictDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/StyleSheetDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/TextDocumentRtfOutput.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Token.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Tokenizer.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/UserPropsDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfdebug.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfdebug.h
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfreader.cpp

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19938: Avoid deprecated QRegion::subtract()

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:149cd73c722b: Avoid deprecated QRegion::subtract() 
(authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19938?vs=54476=54842

REVISION DETAIL
  https://phabricator.kde.org/D19938

AFFECTED FILES
  libs/vectorimage/libwmf/WmfParser.cpp

To: pvuorela, #calligra:_3.0, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19761: Remove obsolete syncX() workaround

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:b0e185c8a3a6: Remove obsolete syncX() workaround (authored 
by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19761?vs=53887=54843

REVISION DETAIL
  https://phabricator.kde.org/D19761

AFFECTED FILES
  stage/part/KPrAnimationDirector.cpp

To: pvuorela, danders
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D19884: Avoid deprecated QAbstractItemModel::reset()

[Damien Caliste]

dcaliste added inline comments.

INLINE COMMENTS

> TextDocumentStructureModel.cpp:308
>  
> -reset();
>  }

I did the same changes in https://phabricator.kde.org/D15102 at another place 
and I put the begin and end at the start and end of the routine, like you did. 
But I remember that I got review asking not to risk to change signal order 
emission, in case, and put the begin/end just around the m_textDocument 
assignment.

I'm not completely sure that I remember correctly and I cannot find it in 
Phabricator anymore...

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19884

To: pvuorela
Cc: dcaliste, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

[Damien Caliste]

dcaliste added a comment.


  Thank you all for the review.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15053

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: boemann, anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:560701ff2443: Consistently use qreal in libs/pigment 
(authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15053?vs=40892=43312

REVISION DETAIL
  https://phabricator.kde.org/D15053

AFFECTED FILES
  libs/pigment/KoColorConversions.cpp
  libs/pigment/KoColorSpace.cpp
  libs/pigment/KoColorSpace.h
  libs/pigment/KoColorSpaceAbstract.h
  libs/pigment/KoColorSpaceTraits.h
  libs/pigment/colorprofiles/KoDummyColorProfile.cpp
  libs/pigment/colorprofiles/KoDummyColorProfile.h
  libs/pigment/colorspaces/KoAlphaColorSpace.h
  libs/pigment/colorspaces/KoLabColorSpace.cpp
  libs/pigment/colorspaces/KoLabColorSpace.h
  libs/pigment/colorspaces/KoRgbU16ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU16ColorSpace.h
  libs/pigment/colorspaces/KoRgbU8ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU8ColorSpace.h
  libs/pigment/colorspaces/KoSimpleColorSpace.h

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: boemann, anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

[Damien Caliste]

dcaliste added a comment.


  Thank you @leinir for your review. I've not disappeared, but I'm still 
thinking about a way not to expose the impl object from Document class, while 
not cluttering the Document API with methods like setBackgroundColor(), 
setPageCache() or any other future canvas methods that I may think about.
  
  So still working on this and I'll come back with a solution when I'll have 
one!

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

[Damien Caliste]

dcaliste added a comment.


  Sorry, I was not clear in my description, I'm not setting the paper 
background color, but the item background color, i.e. the small area around and 
between the pages. In most desktop application it is light grey. But when using 
the KWCanvasItem in another context, it would be nice to be able to set this 
color. It's kind of desktop color if you prefer.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: boemann, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15775: Make the item background color and page cache properties available from View component

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, danders, anthonyfieroni, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Currently, the item background color and the page cache properties in Words 
are built-in values (_resp. _ set to QColor(232, 233, 234) and false). They 
cannot be changed from QML or at all (for the background color). Users of 
libCalligraComponents.so and friends must patch the sources to change their 
behaviours.
  
  This PR introduces a method to set the background color in KWCanvasItem. It 
also expands Components::View by overloading the fillColor property of 
QQuickPaintedItem and adds a pageCacheEnabled(bool) property.
  
  The two new properties are implemented for text documents and are irrelevant 
for the other kind of document (but may have some sense in the future, if 
needed).
  
  Is it the right way to go?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15775

AFFECTED FILES
  components/Document.cpp
  components/Document.h
  components/View.cpp
  components/View.h
  components/impl/DocumentImpl.cpp
  components/impl/DocumentImpl.h
  components/impl/TextDocumentImpl.cpp
  components/impl/TextDocumentImpl.h
  words/part/KWCanvasBase.cpp
  words/part/KWCanvasBase.h
  words/part/KWCanvasItem.cpp
  words/part/KWCanvasItem.h

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15728: Try to avoid segfaults on shape factory not found

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:ccb647780104: Try to avoid segfaults on shape factory not 
found (authored by dcaliste).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15728?vs=42242=42258#toc

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15728?vs=42242=42258

REVISION DETAIL
  https://phabricator.kde.org/D15728

AFFECTED FILES
  plugins/commentshape/CommentShape.cpp
  plugins/defaultTools/connectionTool/ConnectionTool.cpp
  plugins/dockers/shapecollection/ShapeCollectionDocker.cpp
  plugins/textshape/TextTool.cpp
  sheets/Sheet.cpp
  sheets/part/Doc.cpp
  stage/part/KPrEndOfSlideShowPage.cpp
  stage/part/KPrNotes.cpp
  stage/part/KPrPlaceholderStrategy.cpp
  stage/part/KPrPlaceholderTextStrategy.cpp
  words/part/KWDocument.cpp

To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15728: Try to avoid segfaults on shape factory not found

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, anthonyfieroni, danders, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Try to catch every pattern of KoShapeRegistry::instance()->value() in the 
code and check the return pointer before using it.
  
  It's a follow-up of https://phabricator.kde.org/D15679.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15728

AFFECTED FILES
  plugins/commentshape/CommentShape.cpp
  plugins/defaultTools/connectionTool/ConnectionTool.cpp
  sheets/Sheet.cpp
  sheets/part/Doc.cpp
  stage/part/KPrEndOfSlideShowPage.cpp
  stage/part/KPrNotes.cpp
  stage/part/KPrPlaceholderStrategy.cpp
  stage/part/KPrPlaceholderTextStrategy.cpp
  words/part/KWDocument.cpp

To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15617: Move away from kdebug and kdelibs4 in filter/sheets

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:a06f24de8708: Move away from kdebug and kdelibs4 in 
filter/sheets (authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15617?vs=41990=42234

REVISION DETAIL
  https://phabricator.kde.org/D15617

AFFECTED FILES
  filters/sheets/excel/import/ExcelImport.cpp
  filters/sheets/excel/import/ImportUtils.cpp
  filters/sheets/excel/import/ImportUtils.h
  filters/sheets/excel/import/excelimporttoods.cc
  filters/sheets/xlsx/XlsxImport.cpp
  filters/sheets/xlsx/XlsxUtils.h
  filters/sheets/xlsx/XlsxXmlCommentsReader.cpp
  filters/sheets/xlsx/XlsxXmlCommentsReader.h
  filters/sheets/xlsx/XlsxXmlCommonReader.cpp
  filters/sheets/xlsx/XlsxXmlDocumentReader.cpp
  filters/sheets/xlsx/XlsxXmlSharedStringsReader.cpp
  filters/sheets/xlsx/XlsxXmlStylesReader.cpp
  filters/sheets/xlsx/XlsxXmlTableReader.cpp
  filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15679: Add missing dependencies for PART_STAGE

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, danders, anthonyfieroni, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Currently, KPrNotes is using the text shape and the picture shape in its 
creator method (see line 67 and line 78). As a consequence, in a presentation, 
when creating a new page in KPrDocument.cpp#171, the page creation itself is 
creating a KPrNotes (see KPrPage.cpp#56) and finally if one of the two shape 
plugins is not compiled, the Q_ASSERT() will catch the non existing shape, at 
best, or if compiled with QT_NO_DEBUG, the program will crash.
  
  As PART_WORD is depending on PLUGIN_TEXTSHAPE, I'm modifying the depency tree 
to add PLUGIN_TEXTSHAPE and PLUGIN_PICTURESHAPE for PART_STAGE.
  
  Compiling then plugins/pictureshape, I took the opportunity to update two 
function calls in QMouseEvent.
  
  Maybe it would be nice to replace the Q_ASSERT with an if (factory) {} and 
put a warning in the else part in case of a wrong installation and plugins are 
missing. What do you think ?

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15679

AFFECTED FILES
  CalligraProducts.cmake
  plugins/pictureshape/CropWidget.cpp

To: dcaliste, leinir, danders, anthonyfieroni, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15622: Upgrade intersect() to intersected() calls

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:427b182ebea1: Upgrade intersect() to intersected() calls 
(authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15622?vs=41993=42051

REVISION DETAIL
  https://phabricator.kde.org/D15622

AFFECTED FILES
  libs/vectorimage/libwmf/WmfParser.cpp
  libs/vectorimage/libwmf/qwmf.cc
  plugins/chartshape/Legend.cpp
  words/part/KWViewModeNormal.cpp

To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:919c672526ef: Remove deprecated use of QDate::setYMD() and 
QFlag instead of QWindowFlag (authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15620?vs=41985=42050

REVISION DETAIL
  https://phabricator.kde.org/D15620

AFFECTED FILES
  plugins/textshape/dialogs/LanguageTab.cpp
  plugins/textshape/dialogs/LanguageTab.h
  sheets/dialogs/ConditionalDialog.cpp
  sheets/dialogs/ConditionalDialog.h
  sheets/functions/datetime.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15619: Remove use of kglobal.h in sheets

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:71363fdfd076: Remove use of kglobal.h in sheets (authored 
by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15619?vs=41984=42032

REVISION DETAIL
  https://phabricator.kde.org/D15619

AFFECTED FILES
  sheets/FunctionModuleRegistry.cpp
  sheets/FunctionRepository.cpp
  sheets/dialogs/AutoFormatDialog.cpp
  sheets/part/ToolRegistry.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15622: Upgrade intersect() to intersected() calls

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, anthonyfieroni, danders, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Some calls that I missed when upgrading the intersect dprecation.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15622

AFFECTED FILES
  libs/vectorimage/libwmf/WmfParser.cpp
  libs/vectorimage/libwmf/qwmf.cc
  plugins/chartshape/Legend.cpp
  words/part/KWViewModeNormal.cpp

To: dcaliste, leinir, anthonyfieroni, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15617: Move away from kdebug and kdelibs4 in filter/sheets

[Damien Caliste]

dcaliste updated this revision to Diff 41990.
dcaliste added a comment.


  Update the patch, using categories for logging.

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15617?vs=41981=41990

REVISION DETAIL
  https://phabricator.kde.org/D15617

AFFECTED FILES
  filters/sheets/excel/import/ExcelImport.cpp
  filters/sheets/excel/import/ImportUtils.cpp
  filters/sheets/excel/import/ImportUtils.h
  filters/sheets/excel/import/excelimporttoods.cc
  filters/sheets/xlsx/XlsxImport.cpp
  filters/sheets/xlsx/XlsxUtils.h
  filters/sheets/xlsx/XlsxXmlCommentsReader.cpp
  filters/sheets/xlsx/XlsxXmlCommentsReader.h
  filters/sheets/xlsx/XlsxXmlCommonReader.cpp
  filters/sheets/xlsx/XlsxXmlDocumentReader.cpp
  filters/sheets/xlsx/XlsxXmlSharedStringsReader.cpp
  filters/sheets/xlsx/XlsxXmlStylesReader.cpp
  filters/sheets/xlsx/XlsxXmlTableReader.cpp
  filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15617: Move away from kdebug and kdelibs4 in filter/sheets

[Damien Caliste]

dcaliste added a comment.


  @anthonyfieroni I see, like in filters/sheets/html for instance. I'm going to 
update the diff as soon as ready. Thanks for the comment.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15617

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15620: Remove deprecated use of QDate::setYMD() and QFlag instead of QWindowFlag

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, danders, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Some more deprecation changes.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15620

AFFECTED FILES
  plugins/textshape/dialogs/LanguageTab.cpp
  plugins/textshape/dialogs/LanguageTab.h
  sheets/dialogs/ConditionalDialog.cpp
  sheets/dialogs/ConditionalDialog.h
  sheets/functions/datetime.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15619: Remove use of kglobal.h in sheets

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, danders, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Use QGlobalStatic instead of kdelibs4 kglobal.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15619

AFFECTED FILES
  sheets/FunctionModuleRegistry.cpp
  sheets/FunctionRepository.cpp
  sheets/dialogs/AutoFormatDialog.cpp
  sheets/part/ToolRegistry.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15617: Move away from kdebug and kdelibs4 in filter/sheets

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, danders, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Like done by commit 
https://phabricator.kde.org/R8:50c327a76dc6edaa0137b1caf7e1e4e7afb3a531, use 
directly qDebug() in replacement of kDebug().

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15617

AFFECTED FILES
  filters/sheets/excel/import/ExcelImport.cpp
  filters/sheets/excel/import/excelimporttoods.cc
  filters/sheets/xlsx/XlsxImport.cpp
  filters/sheets/xlsx/XlsxXmlCommentsReader.cpp
  filters/sheets/xlsx/XlsxXmlCommentsReader.h
  filters/sheets/xlsx/XlsxXmlCommonReader.cpp
  filters/sheets/xlsx/XlsxXmlDocumentReader.cpp
  filters/sheets/xlsx/XlsxXmlSharedStringsReader.cpp
  filters/sheets/xlsx/XlsxXmlStylesReader.cpp
  filters/sheets/xlsx/XlsxXmlTableReader.cpp
  filters/sheets/xlsx/XlsxXmlWorksheetReader.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15236: Add missing dependencies in CMakeLists.txt

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:6b52b86ae29c: Add missing dependencies in CMakeLists.txt 
(authored by dcaliste).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15236?vs=40902=41970#toc

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15236?vs=40902=41970

REVISION DETAIL
  https://phabricator.kde.org/D15236

AFFECTED FILES
  libs/flake/CMakeLists.txt
  libs/main/CMakeLists.txt
  libs/odf/CMakeLists.txt
  libs/store/CMakeLists.txt
  libs/widgets/CMakeLists.txt
  plugins/textshape/CMakeLists.txt
  sheets/CMakeLists.txt
  sheets/shape/CMakeLists.txt
  stage/part/CMakeLists.txt
  words/part/CMakeLists.txt

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15232: Update deprecated use of setResizeMode()

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:bc9397bc9959: Update deprecated use of setResizeMode() 
(authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15232?vs=40895=41968

REVISION DETAIL
  https://phabricator.kde.org/D15232

AFFECTED FILES
  plugins/textshape/dialogs/TableOfContentsConfigure.cpp
  plugins/textshape/dialogs/TableOfContentsStyleConfigure.cpp
  sheets/dialogs/SortDialog.cpp
  words/part/dockers/KWNavigationWidget.cpp

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:5873bc9d963c: Move to use QUrlQuery in favor of deprecated 
queryItemValue() from QUrl (authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15231?vs=40893=41967

REVISION DETAIL
  https://phabricator.kde.org/D15231

AFFECTED FILES
  components/Global.cpp
  components/impl/TextDocumentImpl.cpp
  sheets/dialogs/LinkDialog.cpp

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:4ebf41d68d71: Replace deprecated use of 
QWeakPointerQObject* in favor of QPointerQObject* (authored by 
dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15103?vs=40514=41965

REVISION DETAIL
  https://phabricator.kde.org/D15103

AFFECTED FILES
  filters/sheets/excel/sidewinder/excel.cpp
  libs/main/KoFilterManager_p.h
  libs/text/KoList.cpp
  libs/text/KoList.h
  libs/text/KoList_p.h
  libs/text/KoTextDocument.cpp
  libs/text/KoTextDocument.h
  libs/text/KoTextEditor_undo.cpp
  libs/text/KoTextInlineRdf.cpp
  libs/text/KoTextMeta.cpp
  libs/text/OdfTextTrackStyles.h
  libs/text/commands/ChangeTrackedDeleteCommand.cpp
  libs/text/commands/ChangeTrackedDeleteCommand.h
  libs/text/commands/DeleteCommand.cpp
  libs/text/commands/DeleteCommand.h
  libs/text/commands/InsertDeleteChangesCommand.h
  libs/text/commands/InsertNoteCommand.h
  libs/text/commands/RemoveDeleteChangesCommand.h
  libs/text/commands/TextPasteCommand.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/TextTool.h

To: dcaliste, #calligra:_3.0, leinir, danders, boemann
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:e4a5dc4f46f2: Update deprecated QAbstractItemModel::reset() 
to use {begin,end}ResetModel()… (authored by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15102?vs=40512=41963

REVISION DETAIL
  https://phabricator.kde.org/D15102

AFFECTED FILES
  components/models/ContentsModel.cpp
  components/models/ContentsModel.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  libs/pageapp/KoPADocumentModel.cpp
  libs/pageapp/KoPADocumentModel.h
  stage/part/KPrCustomSlideShowsModel.cpp
  stage/part/KPrSlidesSorterDocumentModel.cpp
  stage/part/KPrSlidesSorterDocumentModel.h
  stage/part/tools/animationtool/KPrCollectionItemModel.cpp
  stage/part/tools/animationtool/KPrCollectionItemModel.h

To: dcaliste, #calligra:_3.0, leinir
Cc: piggz, Calligra-Devel-list, dcaliste, cochise, vandenoever

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

[Damien Caliste]

This revision was automatically updated to reflect the committed changes.
Closed by commit R8:fe471acca71b: Dont use obsolete QRectF and 
QAbstractItemModel functions (authored by dcaliste).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D14975?vs=40193=41961#toc

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14975?vs=40193=41961

REVISION DETAIL
  https://phabricator.kde.org/D14975

AFFECTED FILES
  libs/flake/tools/KoCreateShapeStrategy.cpp
  libs/flake/tools/KoShapeRubberSelectStrategy.cpp
  libs/kundo2/kundo2model.cpp
  libs/widgets/KoLineStyleModel.cpp
  libs/widgets/KoResourceModel.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, dcaliste, cochise, vandenoever

D15236: Add missing dependencies in CMakeLists.txt

[Damien Caliste]

dcaliste edited the summary of this revision.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15236

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15236: Add missing dependencies in CMakeLists.txt

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Add missing dependencies in target_link_libraries() cmake macro here and 
there. Added dependencies comes from #include<> directives for specific 
headers, like for instance having #include but not specifying 
KF5::WidgetsAddons.
  
  I'm still a bit puzzled know how it can compile without these modifications 
since required '-I path' compiler options are then missing… Maybe because I'm 
using non standard pathes for compilation.
  
  Additionally, I've moved the add_includedirs() macro in sheets/CMakeLists.txt 
inside the ifdef PART_SHEETS, otherwise the eigen3 include directory variable 
may not be set, when configuring without part_sheets and cmake fails in that 
case.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15236

AFFECTED FILES
  libs/flake/CMakeLists.txt
  libs/main/CMakeLists.txt
  libs/odf/CMakeLists.txt
  libs/store/CMakeLists.txt
  libs/widgets/CMakeLists.txt
  plugins/textshape/CMakeLists.txt
  sheets/CMakeLists.txt
  sheets/shape/CMakeLists.txt
  stage/part/CMakeLists.txt
  words/part/CMakeLists.txt

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15232: Update deprecated use of setResizeMode()

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Some additional deprecation updates.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15232

AFFECTED FILES
  plugins/textshape/dialogs/TableOfContentsConfigure.cpp
  plugins/textshape/dialogs/TableOfContentsStyleConfigure.cpp
  sheets/dialogs/SortDialog.cpp
  words/part/dockers/KWNavigationWidget.cpp

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl

[Damien Caliste]

dcaliste added a reviewer: Calligra: 3.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15231

To: dcaliste, leinir, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15231: Move to use QUrlQuery in favor of deprecated queryItemValue() from QUrl

[Damien Caliste]

dcaliste created this revision.
dcaliste added a reviewer: leinir.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Some more deprecation upgrades:
  
  There is now in Qt a dedicated class for queries in urls, so accessors from 
QUrl have been moved to this dedicated class.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15231

AFFECTED FILES
  components/Global.cpp
  components/impl/TextDocumentImpl.cpp
  sheets/dialogs/LinkDialog.cpp

To: dcaliste, leinir
Cc: Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

[Damien Caliste]

dcaliste updated this revision to Diff 40892.
dcaliste added a comment.


  Update the patch not to use the form ```qBound(qreal(0.0), a, qreal(1.0))``` 
but ```qBound(0.0, a, 1.0)``` instead. For reference, original form was 
```qBound(0.0, a, 1.0)``` which was causing issues when qreal <-> float, 
because of mixed doubles and floats.

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15053?vs=40358=40892

REVISION DETAIL
  https://phabricator.kde.org/D15053

AFFECTED FILES
  libs/pigment/KoColorConversions.cpp
  libs/pigment/KoColorSpace.cpp
  libs/pigment/KoColorSpace.h
  libs/pigment/KoColorSpaceAbstract.h
  libs/pigment/KoColorSpaceTraits.h
  libs/pigment/colorprofiles/KoDummyColorProfile.cpp
  libs/pigment/colorprofiles/KoDummyColorProfile.h
  libs/pigment/colorspaces/KoAlphaColorSpace.h
  libs/pigment/colorspaces/KoLabColorSpace.cpp
  libs/pigment/colorspaces/KoLabColorSpace.h
  libs/pigment/colorspaces/KoRgbU16ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU16ColorSpace.h
  libs/pigment/colorspaces/KoRgbU8ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU8ColorSpace.h
  libs/pigment/colorspaces/KoSimpleColorSpace.h

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

[Damien Caliste]

dcaliste added a comment.


  @piggz thank you for the proposition. I've discussed with jpetrell, pvuorela 
and lbt on #sailfishos (see Tuesday 21th discussion, or the Tuesday before) and 
currently they prefer to have KF5 dependency packages within Calligra, not as 
standalone libraries in mer-core. Depending later on additional packages 
creating new demand on KF5, some packages may be migrated to mer-core. So far 
so good for me. I think 5.34 is the latest version to compile with 5.6 (at 
least, that's the case for KI18n, so I'm using consistently this version for 
the other packages). I'm using git repos, so there is no problem to get any 
version I want. It's a matter of git checkout v5.xx.0.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15102

To: dcaliste, #calligra:_3.0, leinir
Cc: piggz, Calligra-Devel-list, cochise, vandenoever

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

[Damien Caliste]

dcaliste added reviewers: leinir, danders.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15103

To: dcaliste, #calligra:_3.0, leinir, danders
Cc: Calligra-Devel-list, cochise, vandenoever

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

[Damien Caliste]

dcaliste added a comment.


  @leinir, thank you. Instead of compiling with deprecation off, it's better to 
correct them ;)
  
  I've finished making 3.1.0 compile in Sailfish SDK based on KF5 5.34.0 with 
minor tweaks, see http://git.merproject.org/dcaliste/calligra-bundle
  I'm commiting here all modifications that makes sense to upstream, new diffs 
will arrive soon, not only about deprecations.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15102

To: dcaliste, #calligra:_3.0, leinir
Cc: Calligra-Devel-list, cochise, vandenoever

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

[Damien Caliste]

dcaliste updated this revision to Diff 40514.
dcaliste added a comment.


  Propagate changes into filters: missing conversion from QSharedPointer into 
QPointer.

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15103?vs=40513=40514

REVISION DETAIL
  https://phabricator.kde.org/D15103

AFFECTED FILES
  filters/sheets/excel/sidewinder/excel.cpp
  libs/main/KoFilterManager_p.h
  libs/text/KoList.cpp
  libs/text/KoList.h
  libs/text/KoList_p.h
  libs/text/KoTextDocument.cpp
  libs/text/KoTextDocument.h
  libs/text/KoTextEditor_undo.cpp
  libs/text/KoTextInlineRdf.cpp
  libs/text/KoTextMeta.cpp
  libs/text/OdfTextTrackStyles.h
  libs/text/commands/ChangeTrackedDeleteCommand.cpp
  libs/text/commands/ChangeTrackedDeleteCommand.h
  libs/text/commands/DeleteCommand.cpp
  libs/text/commands/DeleteCommand.h
  libs/text/commands/InsertDeleteChangesCommand.h
  libs/text/commands/InsertNoteCommand.h
  libs/text/commands/RemoveDeleteChangesCommand.h
  libs/text/commands/TextPasteCommand.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/TextTool.h

To: dcaliste, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15103: Replace deprecated use of QWeakPointer in favor of QPointer

[Damien Caliste]

dcaliste created this revision.
dcaliste added a reviewer: Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  QWeakPointer has been deprecated to store pointers on QObject. QPointer 
should be used instead.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15103

AFFECTED FILES
  libs/main/KoFilterManager_p.h
  libs/text/KoList.cpp
  libs/text/KoList.h
  libs/text/KoList_p.h
  libs/text/KoTextDocument.cpp
  libs/text/KoTextDocument.h
  libs/text/KoTextEditor_undo.cpp
  libs/text/KoTextInlineRdf.cpp
  libs/text/KoTextMeta.cpp
  libs/text/OdfTextTrackStyles.h
  libs/text/commands/ChangeTrackedDeleteCommand.cpp
  libs/text/commands/ChangeTrackedDeleteCommand.h
  libs/text/commands/DeleteCommand.cpp
  libs/text/commands/DeleteCommand.h
  libs/text/commands/InsertDeleteChangesCommand.h
  libs/text/commands/InsertNoteCommand.h
  libs/text/commands/RemoveDeleteChangesCommand.h
  libs/text/commands/TextPasteCommand.h
  plugins/textshape/TextTool.cpp
  plugins/textshape/TextTool.h

To: dcaliste, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15102: Update deprecated QAbstractItemModel::reset() to use {begin, end}ResetModel() instead

[Damien Caliste]

dcaliste created this revision.
dcaliste added a reviewer: Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  Replace QAbstractItemModel::reset() with the more recent 
{begin,end}ResetModel() calls.
  
  Also remove the deprecated calls to setSupportedDragActions() and replace 
them by implementing supportedDragActions().

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15102

AFFECTED FILES
  components/models/ContentsModel.cpp
  components/models/ContentsModel.h
  karbon/ui/dockers/KarbonLayerModel.cpp
  karbon/ui/dockers/KarbonLayerModel.h
  libs/pageapp/KoPADocumentModel.cpp
  libs/pageapp/KoPADocumentModel.h
  stage/part/KPrCustomSlideShowsModel.cpp
  stage/part/KPrSlidesSorterDocumentModel.cpp
  stage/part/KPrSlidesSorterDocumentModel.h
  stage/part/tools/animationtool/KPrCollectionItemModel.cpp
  stage/part/tools/animationtool/KPrCollectionItemModel.h

To: dcaliste, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

[Damien Caliste]

dcaliste added a comment.


  After test (PRODUCTSET="KARBON"), it's not breaking karbon build on amd64.
  
  I cannot test easily on arm because karbon depends on KF5kdelibs4support, 
which is not available. But at least, proposed patch makes PART_WORDS and 
PART_STAGE compilable when qreal <=> float.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15053

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

[Damien Caliste]

dcaliste added a comment.


  Ok, I'll try in the afternoon or during the week-end and comment here.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15053

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

[Damien Caliste]

dcaliste added a comment.


  I'm crosscompiling in SailfishOS SDK. I'm in the process of upgrading 
Calligra there to latest version. @leinir have done it earlier with version 
2.9.x. At that moment, pigment was not containing that kind of function to 
change luminosity... where the conversions are used. I don't know if it's the 
best way to handle the issue. Don't hesitate to comment !

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15053

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D15053: Consistently use qreal in libs/pigment

[Damien Caliste]

dcaliste created this revision.
dcaliste added reviewers: leinir, danders, Calligra: 3.0.
dcaliste added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
dcaliste requested review of this revision.

REVISION SUMMARY
  On my ARM environment, qreal is interpreted as float, not double. Currently 
in libs/pigment, qreal is implicitly treated like a double, while writing 
something like qmax(v, 0.), where v is a qreal. 0. is a double and the compiler 
complains because there is no function using (float, double).
  
  There are also many conversions that are done between floats and doubles in 
KoColorSpace.cpp. So I've updated all necessary functions to accept qreal 
instead of double or float. As a result, the API has been changed. I've checked 
that it's still compiling on amd64 in addition to arm for instance but I'm not 
sure that I didn't break something in the plugins for instance.
  
  I would like to hear your review on this patch. If I'm creating some issues, 
I'm eager to try to solve them.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15053

AFFECTED FILES
  libs/pigment/KoColorConversions.cpp
  libs/pigment/KoColorSpace.cpp
  libs/pigment/KoColorSpace.h
  libs/pigment/KoColorSpaceAbstract.h
  libs/pigment/KoColorSpaceTraits.h
  libs/pigment/colorprofiles/KoDummyColorProfile.cpp
  libs/pigment/colorprofiles/KoDummyColorProfile.h
  libs/pigment/colorspaces/KoAlphaColorSpace.h
  libs/pigment/colorspaces/KoLabColorSpace.cpp
  libs/pigment/colorspaces/KoLabColorSpace.h
  libs/pigment/colorspaces/KoRgbU16ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU16ColorSpace.h
  libs/pigment/colorspaces/KoRgbU8ColorSpace.cpp
  libs/pigment/colorspaces/KoRgbU8ColorSpace.h
  libs/pigment/colorspaces/KoSimpleColorSpace.h

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

[Damien Caliste]

dcaliste updated this revision to Diff 40193.
dcaliste added a comment.


  Update the patch in stackChanged() call to have the exact behaviour than 
before in this method.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14975?vs=40152=40193

REVISION DETAIL
  https://phabricator.kde.org/D14975

AFFECTED FILES
  libs/flake/tools/KoCreateShapeStrategy.cpp
  libs/flake/tools/KoShapeRubberSelectStrategy.cpp
  libs/kundo2/kundo2model.cpp
  libs/widgets/KoLineStyleModel.cpp
  libs/widgets/KoResourceModel.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

[Damien Caliste]

dcaliste added a comment.


  @danders I agree with your remark, I was wondering exactly the same. It's 
safer to put the begin / end together. I'll update the diff and add a comment 
to suggest to move the end after the setCurrentIndex() after extensive testing.

REVISION DETAIL
  https://phabricator.kde.org/D14975

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF and QAbstractItemModel functions

[Damien Caliste]

dcaliste retitled this revision from "Don't use obsolete QRectF functions" to 
"Don't use obsolete QRectF and QAbstractItemModel functions".

REVISION DETAIL
  https://phabricator.kde.org/D14975

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF functions

[Damien Caliste]

dcaliste updated this revision to Diff 40152.
dcaliste added a comment.


  I've added replacements for QAbstractItemModel::reset(). This allow to "lock" 
the model during the reset. So I've tried to put the beginResetModel() before 
the change of the private members, and the endResetModel() after.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14975?vs=40151=40152

REVISION DETAIL
  https://phabricator.kde.org/D14975

AFFECTED FILES
  libs/flake/tools/KoCreateShapeStrategy.cpp
  libs/flake/tools/KoShapeRubberSelectStrategy.cpp
  libs/kundo2/kundo2model.cpp
  libs/widgets/KoLineStyleModel.cpp
  libs/widgets/KoResourceModel.cpp

To: dcaliste, leinir, danders, #calligra:_3.0
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever

D14975: Don't use obsolete QRectF functions

[Damien Caliste]

dcaliste added a comment.


  @anthonyfieroni Ok, will update the diff with other replacements of obsolete 
functions.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D14975

To: dcaliste, leinir
Cc: anthonyfieroni, Calligra-Devel-list, cochise, vandenoever