D15111: [KoUnit] Let's show pixel units

[Noah Davis]

ndavis added a comment.


  In D15111#671510 , @boemann wrote:
  
  > Nothing prevents Karbon from having a m_pixelUnit with ppi collected from a 
widget for user control
  >
  > and the use that unit like inkscape does.
  >
  > But what this patch does is enable it in general with an arbitrary chosen 
ppi value
  >
  > Why not measure in apples too - it will make as much sense ..
  
  
  I'm not an expert on this subject, so I'll just trust your opinion.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0, ndavis, #vdg
Cc: staniek, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in KoUnit.h:59-60
> Are you using HiDPI resolution? Scale factor, Calligra is not hidpi 
> compatible, i think

I am using 96 font DPI (not forced) and 1x scaling at 1920x1080.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0, ndavis, #vdg
Cc: staniek, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Noah Davis]

ndavis added a comment.


  In D15111#671492 , @boemann wrote:
  
  > And that is why this proposal should be rejected as is
  >
  > pixels is not a unit unless assigned a ppi on a case by case basis
  >
  > and thus it needs to be something requested and not EVER something that is 
always available !
  
  
  Is px in Inkscape a different kind of unit from px in Karbon? Some kinds of 
vector graphics //have// to be done with pixel units, such as icons. It's fine 
if you think Karbon should focus primarily on making graphics for physical 
media, but you can't have a general purpose vector graphics program without 
supporting pixel units in the same way that Inkscape does.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0, ndavis, #vdg
Cc: staniek, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in KoUnit.h:59-60
> @ndavis, DPI is 96, it's not configurable for now.

Was it already like that when I made the comment? When I export an SVG, it's 
proportioned like the DPI was 72 if I open it in Gwenview or Inkscape. 48x48 
becomes 36x36.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0, ndavis, #vdg
Cc: staniek, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever

D15111: [KoUnit] Let's show pixel units

[Noah Davis]

ndavis added a comment.


  This does need DPI configuration for pixel units to be useful. Or maybe you 
could just set the DPI to 96 for pixel units since that's probably what most 
people want.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D15111

To: anthonyfieroni, boemann, danders, #calligra:_3.0, ndavis, #vdg
Cc: staniek, Calligra-Devel-list, davidllewellynjones, dcaliste, ognarb, 
cochise, vandenoever