[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets
staniek marked an inline comment as done. staniek added a comment. In https://phabricator.kde.org/D360#7130, @kossebau wrote: > Not sure I would have moved the main.cpp into the other file, but there is no > policy in Calligra about such utils apps, so if you prefer it like that, keep > it as you did now. (I prefer having entry points in a separate file, even do > main.cpp files for plugins, but I know that this is my personal style only. > And as long the util app is sharing the same folder with other stuff, the > main.cpp could be conflicting, so...). Using the KF5 naming, this is a test, and our QTests are called autotests. There, tests/ contain (interactive) apps. Example: ktextwidgets/tests/ktextedittest.cpp We're not yet following this scheme in calligra (no idea if we want this extra rename) but I use it in KDb, etc. I followed KF5 already. The third type of dir is example/ - a real-world app. (that's for the record, sorry for repeating obvious things) Thx! REVISION DETAIL https://phabricator.kde.org/D360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, rempt, kossebau Cc: Calligra-Devel-list ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets
kossebau added a comment. Issue in any case: this patch misses to also move the test app, filedialogtester. Then I wonder if we could first come up with a definition what the purpose of kowidgets and kowidgetutils is. And if perhaps we should split them up some more or reshuffle together with other libs. Especially would I like to see a split between QWidget things and non-gui classes, so QtQuick solutions do not get trojan libs which come with QWidget stuff. Other than that I would agree that KoFileDialog might be rather belong into kowidgetutils, due to not having a dep on other stuff in the Calligra libs, if that is the current difference between kowidgets and kowidgetutils. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, rempt, kossebau Cc: Calligra-Devel-list ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
[Differential] [Updated] D360: KoFileDialog rather belongs to kowidgetutils than kowidgetsThis way apps can use the class without larger deps of kowidgets
staniek updated the summary for this revision. staniek added reviewers: kossebau, rempt. staniek added a project: Calligra: 3.0. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: staniek, kossebau, rempt Cc: Calligra-Devel-list ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
