Re: Calligra and Okular versions

2016-12-09 Thread Albert Astals Cid
El divendres, 9 de desembre de 2016, a les 15:49:08 CET, Jonathan Riddell va 
escriure:
> Recently Okular's internal version changed and so did the requirement
> for Okular by Calligra.
> 
> Okular is now set to 0.99.0 for the stable Applications/16.12 branch
> and Calligra wants 0.99.60.

I fucked up with the version increase.

Cheers,
  Albert

> 
> How before these versions changed I had a version of Calligra master
> (due to become 3.0.0 shortly) which compiled fine with Okular from
> Applications/16.12
> http://build.neon.kde.org/job/xenial_stable_calligra_calligra_bin_amd64/1/
> 
> It would be a shame if Calligra released without a version of Okular
> that it worked with also being released.  Does Calligra work with
> Okular from Applications/16.12 ?
> 
> Jonathan




Re: Calligra and Okular versions

2016-12-09 Thread Andreas Sturmlechner
On Friday, 9 December 2016 at 15:49, Jonathan Riddell wrote:
> Okular is now set to 0.99.0 for the stable Applications/16.12 branch
> and Calligra wants 0.99.60.

I was puzzled how that could happen again, since I made the calligra commit 
that dialled back the okular requirement from 1.0.0 to 0.99.60 (which worked a 
few weeks ago). That was necessary due to okular commit 
ebeeac8d72b258b516929344b43ceec3a57e06e7 setting version to

0.99.${KDE_APPLICATIONS_VERSION_MICRO}

which was bound to break (go backwards) when moving from beta/RC numbers 
16.11.60 to 16.12.0 release.

Regards,
Andreas



Re: Calligra and Okular versions

2016-12-09 Thread Jonathan Riddell
On Fri, Dec 09, 2016 at 07:55:30PM +0100, Andreas Sturmlechner wrote:
> On Friday, 9 December 2016 at 15:49, Jonathan Riddell wrote:
> > Okular is now set to 0.99.0 for the stable Applications/16.12 branch
> > and Calligra wants 0.99.60.
> 
> I was puzzled how that could happen again, since I made the calligra commit 
> that dialled back the okular requirement from 1.0.0 to 0.99.60 (which worked 
> a 
> few weeks ago). That was necessary due to okular commit   
> ebeeac8d72b258b516929344b43ceec3a57e06e7 setting version to
> 
> 0.99.${KDE_APPLICATIONS_VERSION_MICRO}
> 
> which was bound to break (go backwards) when moving from beta/RC numbers 
> 16.11.60 to 16.12.0 release.

I highlighted a related issue not long ago
https://marc.info/?l=kde-devel=147929111915475=2

Jonathan


Re: Calligra and Okular versions

2016-12-09 Thread Jonathan Riddell
> Depending on whether 16.12.0 tarballs have already been made either Calligra
> needs to adapt to that now, or Okular could still get fixed.

tars have been made for 16.12 but aren't released until next week so
maybe Albert can update that

Jonathan


Re: Calligra and Okular versions

2016-12-09 Thread Friedrich W. H. Kossebau
Thanks for the heads-up, Jonathan.

Am Freitag, 9. Dezember 2016, 15:49:08 CET schrieb Jonathan Riddell:
> Recently Okular's internal version changed and so did the requirement
> for Okular by Calligra.
> 
> Okular is now set to 0.99.0 for the stable Applications/16.12 branch
> and Calligra wants 0.99.60.
> 
> How before these versions changed I had a version of Calligra master
> (due to become 3.0.0 shortly) which compiled fine with Okular from
> Applications/16.12
> http://build.neon.kde.org/job/xenial_stable_calligra_calligra_bin_amd64/1/
> 
> It would be a shame if Calligra released without a version of Okular
> that it worked with also being released.  Does Calligra work with
> Okular from Applications/16.12 ?

Yes, it does.

What happened is that Okular has 
ecm_setup_version(0.99.${KDE_APPLICATIONS_VERSION_MICRO}
  VARIABLE_PREFIX OKULAR
  VERSION_HEADER "${CMAKE_CURRENT_BINARY_DIR}/core/version.h"
  PACKAGE_VERSION_FILE "${CMAKE_CURRENT_BINARY_DIR}/
Okular5ConfigVersion.cmake")

and someone bumped KDE_APPLICATIONS_VERSION_MICRO from 90 to 0, but noone made 
sure the 0.99 gets bumped too. :/

Depending on whether 16.12.0 tarballs have already been made either Calligra 
needs to adapt to that now, or Okular could still get fixed.

Cheers
Friedrich



Calligra and Okular versions

2016-12-09 Thread Jonathan Riddell
Recently Okular's internal version changed and so did the requirement
for Okular by Calligra.

Okular is now set to 0.99.0 for the stable Applications/16.12 branch
and Calligra wants 0.99.60.

How before these versions changed I had a version of Calligra master
(due to become 3.0.0 shortly) which compiled fine with Okular from
Applications/16.12
http://build.neon.kde.org/job/xenial_stable_calligra_calligra_bin_amd64/1/

It would be a shame if Calligra released without a version of Okular
that it worked with also being released.  Does Calligra work with
Okular from Applications/16.12 ?

Jonathan