D15403: {Style] Default sheets to white background
This revision was automatically updated to reflect the committed changes. Closed by commit R8:e5fc394f4a54: [Style] Default sheets to white background (authored by anthonyfieroni). REPOSITORY R8 Calligra CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15403?vs=41338=41840 REVISION DETAIL https://phabricator.kde.org/D15403 AFFECTED FILES sheets/Style.cpp To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D15403: {Style] Default sheets to white background
danders accepted this revision. This revision is now accepted and ready to land. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D15403: {Style] Default sheets to white background
danders added a comment. Hmm, imo styling odf apps content area should be considdered a bug :=) Because: All info pertaining to presentation of content is stored in odf file and is controllable by user, so styling it would often create strange resullts. (And it would not be much wysiwyg about it) Of course everything else like tools, dialogs, window decorations can be styled. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D15403: {Style] Default sheets to white background
anthonyfieroni added a comment. It's inspired in forum discussion, it has predominately advice that other Calligra apps has a white background despite palette but sheets. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D15403: {Style] Default sheets to white background
boemann added a comment. No Idea about the code, but in general I have no problem with sheets respecting the palette REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D15403: {Style] Default sheets to white background
anthonyfieroni edited the summary of this revision. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
D15403: {Style] Default sheets to white background
anthonyfieroni created this revision. anthonyfieroni added reviewers: danders, boemann. Herald added a project: Calligra: 3.0. Herald added a subscriber: Calligra-Devel-list. anthonyfieroni requested review of this revision. REVISION SUMMARY Other applications does not respect palette for background but Calligrasheets. Make default to white background with black text, when starts ending cell background is palette' one, text too. REPOSITORY R8 Calligra REVISION DETAIL https://phabricator.kde.org/D15403 AFFECTED FILES sheets/Style.cpp To: anthonyfieroni, danders, boemann Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever
