D19912: Implement logging category for rtf-qt

2019-03-26 Thread Damien Caliste 
This revision was automatically updated to reflect the committed changes.
Closed by commit R8:85b57f2e64bb: Implement logging category for rtf-qt 
(authored by pvuorela, committed by dcaliste).

REPOSITORY
  R8 Calligra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19912?vs=54405=54838

REVISION DETAIL
  https://phabricator.kde.org/D19912

AFFECTED FILES
  filters/words/rtf/import/3rdparty/rtf-qt/src/CMakeLists.txt
  filters/words/rtf/import/3rdparty/rtf-qt/src/ColorTableDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Destination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/DocumentDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/FontTableDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/InfoDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/InfoTimeDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/PcdataDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/PictDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/StyleSheetDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/TextDocumentRtfOutput.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Token.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Tokenizer.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/UserPropsDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfdebug.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfdebug.h
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfreader.cpp

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Dag Andersen 
danders added a comment.


  In D19912#435067 , @pvuorela wrote:
  
  > In D19912#435058 , @danders 
wrote:
  >
  > > Strange indents, could you fix it?
  >
  >
  > That's what I commented on the summary. On some parts rtf-qt uses plain 
spaces for indentation and those parts look good. Then in the same file other 
methods might have a hard tab or a hard tab followed by spaces. If you really 
want, I can try to retain the old whitespace, but it's indentation-wise more or 
less broken already anyway :) Alternatively could run astyle for the 
subdirectory, though maybe best done as separate commit.
  
  
  Yes, sorry, as you say better done separatly.
  
  > The directory README also states "Temporary local copy of Brad Hards' 
rtf-qt library.", though as upstream hasn't had changes since 2011, it seems 
like a permanent one by now.
  
  Probably.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Pekka Vuorela 
pvuorela added a comment.


  In D19912#435058 , @danders wrote:
  
  > Strange indents, could you fix it?
  
  
  That's what I commented on the summary. On some parts rtf-qt uses plain 
spaces for indentation and those parts look good. Then in the same file other 
methods might have a hard tab or a hard tab followed by spaces. If you really 
want, I can try to retain the old whitespace, but it's indentation-wise more or 
less broken already anyway :) Alternatively could run astyle for the 
subdirectory, though maybe best done as separate commit.
  
  The directory README also states "Temporary local copy of Brad Hards' rtf-qt 
library.", though as upstream hasn't had changes since 2011, it seems like a 
permanent one by now.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Dag Andersen 
danders accepted this revision.
danders added a comment.
This revision is now accepted and ready to land.


  Strange indents, could you fix it?
  Otherwise ok.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

To: pvuorela, danders
Cc: danders, Calligra-Devel-list, dcaliste, cochise, vandenoever

D19912: Implement logging category for rtf-qt

2019-03-20 Thread Pekka Vuorela 
pvuorela created this revision.
Herald added a project: Calligra: 3.0.
Herald added a subscriber: Calligra-Devel-list.
pvuorela requested review of this revision.

REVISION SUMMARY
  To be noted that indentation looks a bit off, rtf-qt has a mixed bag of hard 
tabs and spaces, used only spaces here.

REPOSITORY
  R8 Calligra

REVISION DETAIL
  https://phabricator.kde.org/D19912

AFFECTED FILES
  filters/words/rtf/import/3rdparty/rtf-qt/src/CMakeLists.txt
  filters/words/rtf/import/3rdparty/rtf-qt/src/ColorTableDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Destination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/DocumentDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/FontTableDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/InfoDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/InfoTimeDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/PcdataDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/PictDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/StyleSheetDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/TextDocumentRtfOutput.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Token.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/Tokenizer.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/UserPropsDestination.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfdebug.cpp
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfdebug.h
  filters/words/rtf/import/3rdparty/rtf-qt/src/rtfreader.cpp

To: pvuorela
Cc: Calligra-Devel-list, dcaliste, cochise, vandenoever