Re: Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[C. Boemann]

On Monday 31 August 2015 11:24:48 Friedrich W. H. Kossebau wrote:
> Am Freitag, 28. August 2015, 19:18:18 schrieb Friedrich W. H. Kossebau:
> > Am Freitag, 28. August 2015, 15:48:39 schrieb Boudewijn Rempt:
> > > On Thu, 27 Aug 2015, Friedrich W. H. Kossebau wrote:
> > > > * after that:
> > > >  2.9 only bugfixes, no more features
> > > >  master unfrozen, so open for features and porting from
> > > >  kdelibs4support
> > > 
> > > I also would like to cleanup the coding style, still...
> 
> Does any of the non-Krita maintainers want to do a cleanup of the coding
> style?
> 
> If not and it's only Krita where that should happen, could that be done
> after the split-off, Boud? Especially when you realize your plan to dump
> history and start out with a plain snapshot, that would then be a good time
> to also do the reformatting.
> 
> Yue, Jarosław, Tomas, Camilla, Leinir, anyone of you want to do a
> reformatting of any part of Calligra?
> 
> Cheers
> Friedrich
> 
> ___
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
I have no big urge to so no - I think we are generally there - but I also 
think that nw(ish) would be a good time

Camilla
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Dmitry Kazakov]

Hi, Stefano!

Now Dmitry, what are the situations where you really need it? Because it's
> weird that someone else didn't find/write a ready to use solution for it.
>

Emacs has a feature to autocomplete parts of the filename in non-sequential
order if they are split with underscores. I got really accustomed to this
feature. E.g. you can type '_setting

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Jaroslaw Staniek]

On 31 August 2015 at 11:24, Friedrich W. H. Kossebau 
wrote:

> Am Freitag, 28. August 2015, 19:18:18 schrieb Friedrich W. H. Kossebau:
> > Am Freitag, 28. August 2015, 15:48:39 schrieb Boudewijn Rempt:
> > > On Thu, 27 Aug 2015, Friedrich W. H. Kossebau wrote:
> > > > * after that:
> > > >  2.9 only bugfixes, no more features
> > > >  master unfrozen, so open for features and porting from
> kdelibs4support
> > >
> > > I also would like to cleanup the coding style, still...
>
> Does any of the non-Krita maintainers want to do a cleanup of the coding
> style?
>
> If not and it's only Krita where that should happen, could that be done
> after
> the split-off, Boud? Especially when you realize your plan to dump history
> and
> start out with a plain snapshot, that would then be a good time to also do
> the
> reformatting.
>
> Yue, Jarosław, Tomas, Camilla, Leinir, anyone of you want to do a
> reformatting
> of any part of Calligra?
>

For me: as the very last step, even after renames (hint: renames using
global search/replace in creator change can break formatting/indentation of
args).

​

​Where the step (N-1) is: "make sure the formatter tools working properly".

Ideally someone shall do this research for us, as this ​is KDE-wide need so
we can ask for that in the wider public.

-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Friedrich W. H. Kossebau]

Am Freitag, 28. August 2015, 19:18:18 schrieb Friedrich W. H. Kossebau:
> Am Freitag, 28. August 2015, 15:48:39 schrieb Boudewijn Rempt:
> > On Thu, 27 Aug 2015, Friedrich W. H. Kossebau wrote:
> > > * after that:
> > >  2.9 only bugfixes, no more features
> > >  master unfrozen, so open for features and porting from kdelibs4support
> > 
> > I also would like to cleanup the coding style, still...

Does any of the non-Krita maintainers want to do a cleanup of the coding 
style?

If not and it's only Krita where that should happen, could that be done after 
the split-off, Boud? Especially when you realize your plan to dump history and 
start out with a plain snapshot, that would then be a good time to also do the 
reformatting.

Yue, Jarosław, Tomas, Camilla, Leinir, anyone of you want to do a reformatting 
of any part of Calligra?

Cheers
Friedrich

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Boudewijn Rempt]

On Mon, 31 Aug 2015, Friedrich W. H. Kossebau wrote:


Am Freitag, 28. August 2015, 19:18:18 schrieb Friedrich W. H. Kossebau:

Am Freitag, 28. August 2015, 15:48:39 schrieb Boudewijn Rempt:
> On Thu, 27 Aug 2015, Friedrich W. H. Kossebau wrote:
> > * after that:
> >  2.9 only bugfixes, no more features
> >  master unfrozen, so open for features and porting from kdelibs4support
> 
> I also would like to cleanup the coding style, still...


Does any of the non-Krita maintainers want to do a cleanup of the coding 
style?


If not and it's only Krita where that should happen, could that be done after 
the split-off, Boud? Especially when you realize your plan to dump history and 
start out with a plain snapshot, that would then be a good time to also do the 
reformatting.


Yes, sure.



Yue, Jarosław, Tomas, Camilla, Leinir, anyone of you want to do a reformatting 
of any part of Calligra?


Cheers
Friedrich

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Boudewijn Rempt]

On Mon, 31 Aug 2015, Boudewijn Rempt wrote:

To amplify a bit, why I want to do the reformat as part of the kf5
port: we'll be hitting pretty much every other line anyway, with K->Q
changes. And there are places where our inconsistenty really is unpleased,
for instance, all the places where we have fileName vs filename. I really
want to clean things like that up now as well, so we have a clean base
for the next ten years.

And that's why I think we'll be hitting almost all of the code anyway. But
it can wait until we're done merging the animation/lod things and until
the repo split is done.

Boudewijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Tomas Mecir]

2015-08-31 11:24 GMT+02:00 Friedrich W. H. Kossebau :

> Does any of the non-Krita maintainers want to do a cleanup of the coding
> style?
>

Indifferent here. Not objecting to it, but I don't really have much need
for it either.

/ Tomas
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Jaroslaw Staniek]

On 31 August 2015 at 10:44, Dmitry Kazakov  wrote:
>
>
>> >> 2) I am personally against of automated whitespace reformatting,
>> >> because
>> >> it pollutes history of files without any use. Includes,
>> >> slots, forward declarations reformattings are ok. Whitespace no.
>> >
>> >
>> > There is a lot of use in whitespace cleanup: it makes the code
>> > consistent and readable.
>>
>> Yes, we discussed that a bit a while ago. Initially I was critical
>> too. But whitespace changes can be ignored when generating diff _and_
>> blame (the -w option). Anyone can add this flag in git options for
>> diff/blame. I'd do so.
>>
>> I'd like to note that we don't have a proven formatting tool for now
>> for all C++ elements. astyle got broken, and clang formatter can be
>> better but we need an expert. Missing things may be minor but we can't
>> make the result worse in problematic areas than the original. Not even
>> KF5 has a formatting tool, last I checked.
>
>
> Yes, the last time we discussed it, I raised quite a few issues with the
> formatter and got a response that "they are limitations of the formatter
and
> cannot be overcome easily". So why we should spend time on it at all if it
> doesn't solve any real issue? At least in Krita I don't see any real
problem
> with formatting. Yes, there are a few places where it is non-standard, but
> we fix it when refactoring these lines.

How about that:
​
​A kind of the same here.Personally ​I can live in kexi.git without
formatting and renames for some time, in this dept non-app repos like
kreport.git deserve renames first for basic consistency (there are classes
with no prefixes, Ko prefixes and KReport prefixes, all mixed now). Because
it's more like a 'public' code, headers are actually installed.
​
When kexi.git and krita.git and
​(​
​​
cut-off
​)​
calligra.git
​gets created, repo maintainers can decide with to do regarding formatting.
I hope it can wait. First we're
​ about to have some renames. Every calligra subproject has specific time
frames and workforce. Let's distribute the decision


PS: Re-wrapping
​looks like the most intrusive change. git diff -w won't ignore it. Example:

*​Original: one line​*

​​
void FoobarClass::setFoobar(VeryLongType a1, VeryLongType a2,
​​
VeryLongType a3)

->
*Formatted: 2 lines​*
*​​*


void FoobarClass::setFoobar(VeryLongType a1, VeryLongType a2,
​​
VeryLongType a3)

​--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Boudewijn Rempt]

On Sun, 30 Aug 2015, Dmitry Kazakov wrote:


Hi, Friedrich!

I have several points against total reformatting of everything.

1) We are planning to alpha-release LevelOfDetail and Animation functionality 
soon for users to test. And we cannot base this
version on Frameworks, because the latter one has no decent tablet support on 
Linux (Qt5 makes the line look jittery and we have no
decision yet how to fix that). So we cannot merge it in atm.


You _have_ to. You can't go on building the animation branch against 2.9
and expect to be able to merge it to master later on. There will be too
many changes, not just whitespace cleanups. It's a pity that tablet support
isn't fixed yet, but that's not a reason not to move feature development
to the master/kf5/qt5 branch. We'll have to make sure tablet support is 
good again anyway.



2) I am personally against of automated whitespace reformatting, because it 
pollutes history of files without any use. Includes,
slots, forward declarations reformattings are ok. Whitespace no.


There is a lot of use in whitespace cleanup: it makes the code
consistent and readable.


3) Renaming files into CamesCaseStyle.cpp instead of underscore_style.cpp will 
break my workflow. You have to expect me to spent at
least 2 working days on readjusting my workflow. I'm ok with it, though I would 
prefer to spend this time on something more useful
for Krita.


Well, we can do two things, after we've split up the repositories:
rename everything to camelcase, or everything to underscores. As
for me, Qt Creator makes it much easier to work with files that 
have the same names as the class themselves.


Boudewijn
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[René J . V . Bertin]

 3) Renaming files into CamesCaseStyle.cpp instead of underscore_style.cpp 
 will break my workflow. You have to expect me to spent at
 least 2 working days on readjusting my workflow. I'm ok with it, though I 
 would prefer to spend this time on something more useful
 for Krita.

Well, we can do two things, after we've split up the repositories:
rename everything to camelcase, or everything to underscores. As
for me, Qt Creator makes it much easier to work with files that 
have the same names as the class themselves.

I'd advise against using case filenames, or at least be very attentive not to 
depend on filename differences that are in case only. This *will* lead to 
problems on MS Windows and Mac OS X.

R
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Jaroslaw Staniek]

We're not going to do that. No FooBar.cpp and foobar.cpp files, just FooBar.cpp.

On 30 August 2015 at 12:44, René J.V. rjvber...@gmail.com wrote:
 3) Renaming files into CamesCaseStyle.cpp instead of underscore_style.cpp 
 will break my workflow. You have to expect me to spent at
 least 2 working days on readjusting my workflow. I'm ok with it, though I 
 would prefer to spend this time on something more useful
 for Krita.

Well, we can do two things, after we've split up the repositories:
rename everything to camelcase, or everything to underscores. As
for me, Qt Creator makes it much easier to work with files that
have the same names as the class themselves.

 I'd advise against using case filenames, or at least be very attentive not to 
 depend on filename differences that are in case only. This *will* lead to 
 problems on MS Windows and Mac OS X.

 R
 ___
 calligra-devel mailing list
 calligra-devel@kde.org
 https://mail.kde.org/mailman/listinfo/calligra-devel



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Jaroslaw Staniek]

On 30 August 2015 at 10:29, Boudewijn Rempt b...@valdyas.org wrote:
 On Sun, 30 Aug 2015, Dmitry Kazakov wrote:

 Hi, Friedrich!

 I have several points against total reformatting of everything.

 1) We are planning to alpha-release LevelOfDetail and Animation
 functionality soon for users to test. And we cannot base this
 version on Frameworks, because the latter one has no decent tablet support
 on Linux (Qt5 makes the line look jittery and we have no
 decision yet how to fix that). So we cannot merge it in atm.


 You _have_ to. You can't go on building the animation branch against 2.9
 and expect to be able to merge it to master later on. There will be too
 many changes, not just whitespace cleanups. It's a pity that tablet support
 isn't fixed yet, but that's not a reason not to move feature development
 to the master/kf5/qt5 branch. We'll have to make sure tablet support is good
 again anyway.

 2) I am personally against of automated whitespace reformatting, because
 it pollutes history of files without any use. Includes,
 slots, forward declarations reformattings are ok. Whitespace no.


 There is a lot of use in whitespace cleanup: it makes the code
 consistent and readable.

Yes, we discussed that a bit a while ago. Initially I was critical
too. But whitespace changes can be ignored when generating diff _and_
blame (the -w option). Anyone can add this flag in git options for
diff/blame. I'd do so.

I'd like to note that we don't have a proven formatting tool for now
for all C++ elements. astyle got broken, and clang formatter can be
better but we need an expert. Missing things may be minor but we can't
make the result worse in problematic areas than the original. Not even
KF5 has a formatting tool, last I checked.

 3) Renaming files into CamesCaseStyle.cpp instead of underscore_style.cpp
 will break my workflow. You have to expect me to spent at
 least 2 working days on readjusting my workflow. I'm ok with it, though I
 would prefer to spend this time on something more useful
 for Krita.


 Well, we can do two things, after we've split up the repositories:
 rename everything to camelcase, or everything to underscores. As
 for me, Qt Creator makes it much easier to work with files that have the
 same names as the class themselves.

+ We're in Qt/KF5-centric world where CamelCase is used.


 Boudewijn

 ___
 calligra-devel mailing list
 calligra-devel@kde.org
 https://mail.kde.org/mailman/listinfo/calligra-devel



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

RE: Big reformat of sources before unfreeze of master (was: Re: Schedule to switch back to master for feature development)

[Camilla Boemann]

-Original Message-

Camilla, you also looked into that reformatting, no? Could you collect further 
experiences how to do that?

I looked into a small program that could format the initializer list - but 
forgot all about it - I can look at it again on Tuesday - but it was meant to 
be run after any other reformatting

Iirc I had something working but not sure how robust it is - still several 
hours of hacking before it will be safe to use

___
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel