Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-26 Thread Camilla Boemann

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review101127
---



Also Anthony - for the really simple commits and stuff in karbon you can just 
commit without review request - we will review when we see the commit mails - 
just don't break build or push big stuff without some kind of warning etc

- Camilla Boemann


On Nov. 26, 2016, 6:12 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 26, 2016, 6:12 a.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-25 Thread Anthony Fieroni

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/
---

(Updated Ноев. 26, 2016, 8:12 преди обяд)


Status
--

This change has been marked as submitted.


Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.


Repository: calligra


Description
---

As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so i 
can be Co-Maintainer, i'm missing experience with graphics nor vector graphics 
software but i will try to help and fixing bugs.


Diffs
-

  CalligraProducts.cmake 965e9d8 

Diff: https://git.reviewboard.kde.org/r/129421/diff/


Testing
---

Builds.


Thanks,

Anthony Fieroni



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-20 Thread Camilla Boemann


> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?
> 
> Camilla Boemann wrote:
> put calligra as reviewer, however we are not really using this 
> reviewboard anymore, but rather phabricator instead
> 
> Anthony Fieroni wrote:
> So should i put this and other one patch in phabricator ?
> 
> Camilla Boemann wrote:
> no that is not needed - we allow many types of review - also in person or 
> via a mail - even in some cases self review
> 
> Anthony Fieroni wrote:
> Can we ship this, Arch (removed Karbon from git build), KaOS (removed it 
> entirely from repo)?

no not yet, but if you keep the fixes coming we can remove it right before 
release


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-20 Thread Anthony Fieroni


> On Ноев. 18, 2016, 12:09 преди обяд, Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?
> 
> Camilla Boemann wrote:
> put calligra as reviewer, however we are not really using this 
> reviewboard anymore, but rather phabricator instead
> 
> Anthony Fieroni wrote:
> So should i put this and other one patch in phabricator ?
> 
> Camilla Boemann wrote:
> no that is not needed - we allow many types of review - also in person or 
> via a mail - even in some cases self review

Can we ship this, Arch (removed Karbon from git build), KaOS (removed it 
entirely from repo)?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Ноев. 19, 2016, 9:38 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Ноев. 19, 2016, 9:38 след обяд)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-20 Thread René J . V . Bertin
On Saturday November 19 2016 21:52:21 Camilla Boemann wrote:

>> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, 
>> so i can be Co-Maintainer, i'm missing experience with graphics nor vector 
>> graphics software but i will try to help and fixing bugs.

Let me just say that's great news! I'll try to follow this, and as soon as 
there's some stability (I think I heard about a 3.1 series?) I'll start looking 
into bring this and other Calligra components into my MacPorts KF5 tree so they 
can be tested on Mac too.

R.


Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Camilla Boemann


> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?
> 
> Camilla Boemann wrote:
> put calligra as reviewer, however we are not really using this 
> reviewboard anymore, but rather phabricator instead
> 
> Anthony Fieroni wrote:
> So should i put this and other one patch in phabricator ?

no that is not needed - we allow many types of review - also in person or via a 
mail - even in some cases self review


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni


> On Ноев. 18, 2016, 12:09 преди обяд, Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?
> 
> Camilla Boemann wrote:
> put calligra as reviewer, however we are not really using this 
> reviewboard anymore, but rather phabricator instead

So should i put this and other one patch in phabricator ?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Ноев. 19, 2016, 9:38 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Ноев. 19, 2016, 9:38 след обяд)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Camilla Boemann


> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us
> 
> Anthony Fieroni wrote:
> Ok. I will be the maintainer. I will add you to reviewer of my patches or 
> other guy?

put calligra as reviewer, however we are not really using this reviewboard 
anymore, but rather phabricator instead


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 19, 2016, 7:38 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 19, 2016, 7:38 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/
---

(Updated Ноев. 19, 2016, 9:38 след обяд)


Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.


Repository: calligra


Description
---

As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so i 
can be Co-Maintainer, i'm missing experience with graphics nor vector graphics 
software but i will try to help and fixing bugs.


Diffs (updated)
-

  CalligraProducts.cmake 965e9d8 

Diff: https://git.reviewboard.kde.org/r/129421/diff/


Testing
---

Builds.


Thanks,

Anthony Fieroni



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni


> On Ноев. 18, 2016, 12:09 преди обяд, Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?
> 
> Camilla Boemann wrote:
> I'm sorry I don't understand what you mean? Also karbon doesn't have a 
> maintainter. That webpage is wrong/out of date. You are very welcome to 
> become the new maintainer, but let's not remove that message until we have 
> seen that you are staying with us

Ok. I will be the maintainer. I will add you to reviewer of my patches or other 
guy?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Ноев. 17, 2016, 10:09 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Ноев. 17, 2016, 10:09 след обяд)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
>   karbon/CMakeLists.txt ba775ad 
>   karbon/main.cpp 2fa3f4d 
>   karbon/ui/KarbonAboutData.h aa96ee1 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Camilla Boemann


> On Nov. 17, 2016, 10:09 p.m., Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!
> 
> Anthony Fieroni wrote:
> So you want to return warn message on non-Release builds?

I'm sorry I don't understand what you mean? Also karbon doesn't have a 
maintainter. That webpage is wrong/out of date. You are very welcome to become 
the new maintainer, but let's not remove that message until we have seen that 
you are staying with us


- Camilla


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Nov. 17, 2016, 8:09 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 17, 2016, 8:09 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
>   karbon/CMakeLists.txt ba775ad 
>   karbon/main.cpp 2fa3f4d 
>   karbon/ui/KarbonAboutData.h aa96ee1 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-19 Thread Anthony Fieroni


> On Ноев. 18, 2016, 12:09 преди обяд, Camilla Boemann wrote:
> > It's great that you want to co maintain - i think you could even apply for 
> > maintaining without the "co-", but i also think it's a bit premature to 
> > remove that message. Maintain (be ambassador, fix bugs etc) for a month or 
> > so and if you are still warm about the idea we can remove the message.I 
> > mean the spot is yours if you want but make yourself a maintainer by deed 
> > before we make you one by name. Deal?
> > 
> > And just to emphazise it would be really great to see you work on karbon - 
> > it deserves to come to full glory!

So you want to return warn message on non-Release builds?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---


On Ноев. 17, 2016, 10:09 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Ноев. 17, 2016, 10:09 след обяд)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
>   karbon/CMakeLists.txt ba775ad 
>   karbon/main.cpp 2fa3f4d 
>   karbon/ui/KarbonAboutData.h aa96ee1 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>



Re: Review Request 129421: [karbon] Returning of Karbon as maintained product

2016-11-17 Thread Camilla Boemann

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129421/#review100920
---



It's great that you want to co maintain - i think you could even apply for 
maintaining without the "co-", but i also think it's a bit premature to remove 
that message. Maintain (be ambassador, fix bugs etc) for a month or so and if 
you are still warm about the idea we can remove the message.I mean the spot is 
yours if you want but make yourself a maintainer by deed before we make you one 
by name. Deal?

And just to emphazise it would be really great to see you work on karbon - it 
deserves to come to full glory!

- Camilla Boemann


On Nov. 17, 2016, 8:09 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129421/
> ---
> 
> (Updated Nov. 17, 2016, 8:09 p.m.)
> 
> 
> Review request for Calligra, Camilla Boemann and Friedrich W. H. Kossebau.
> 
> 
> Repository: calligra
> 
> 
> Description
> ---
> 
> As https://community.kde.org/Calligra/Maintainers Karbon has a maintainer, so 
> i can be Co-Maintainer, i'm missing experience with graphics nor vector 
> graphics software but i will try to help and fixing bugs.
> 
> 
> Diffs
> -
> 
>   CalligraProducts.cmake 965e9d8 
>   karbon/CMakeLists.txt ba775ad 
>   karbon/main.cpp 2fa3f4d 
>   karbon/ui/KarbonAboutData.h aa96ee1 
> 
> Diff: https://git.reviewboard.kde.org/r/129421/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>